Re: [PATCH 01/26] perf tools: Change thread_map::map into struct

2015-06-22 Thread Arnaldo Carvalho de Melo
Em Mon, Jun 22, 2015 at 07:37:45PM +0200, Jiri Olsa escreveu: > On Mon, Jun 22, 2015 at 11:40:16AM -0300, Arnaldo Carvalho de Melo wrote: > > > get/set functions seem like overkill.. we could use upper case to state > > > that it's a macro: > > > THREAD_MAP__PID(evlist->threads, 0) = getpid();

Re: [PATCH 01/26] perf tools: Change thread_map::map into struct

2015-06-22 Thread Jiri Olsa
On Mon, Jun 22, 2015 at 11:40:16AM -0300, Arnaldo Carvalho de Melo wrote: SNIP > > > > +++ b/tools/perf/tests/openat-syscall-tp-fields.c > > > > @@ -45,7 +45,7 @@ int test__syscall_openat_tp_fields(void) > > > > > > > > perf_evsel__config(evsel, ); > > > > > > > > -

Re: [PATCH 01/26] perf tools: Change thread_map::map into struct

2015-06-22 Thread Arnaldo Carvalho de Melo
Em Sat, Jun 20, 2015 at 12:05:31AM +0200, Jiri Olsa escreveu: > On Fri, Jun 19, 2015 at 06:07:13PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Thu, Jun 18, 2015 at 11:48:40PM +0200, Jiri Olsa escreveu: > > > We need to store command names with the pid. Changing > > > map to be struct holding

Re: [PATCH 01/26] perf tools: Change thread_map::map into struct

2015-06-22 Thread Jiri Olsa
On Mon, Jun 22, 2015 at 11:40:16AM -0300, Arnaldo Carvalho de Melo wrote: SNIP +++ b/tools/perf/tests/openat-syscall-tp-fields.c @@ -45,7 +45,7 @@ int test__syscall_openat_tp_fields(void) perf_evsel__config(evsel, opts); - evlist-threads-map[0] =

Re: [PATCH 01/26] perf tools: Change thread_map::map into struct

2015-06-22 Thread Arnaldo Carvalho de Melo
Em Mon, Jun 22, 2015 at 07:37:45PM +0200, Jiri Olsa escreveu: On Mon, Jun 22, 2015 at 11:40:16AM -0300, Arnaldo Carvalho de Melo wrote: get/set functions seem like overkill.. we could use upper case to state that it's a macro: THREAD_MAP__PID(evlist-threads, 0) = getpid(); anyway

Re: [PATCH 01/26] perf tools: Change thread_map::map into struct

2015-06-22 Thread Arnaldo Carvalho de Melo
Em Sat, Jun 20, 2015 at 12:05:31AM +0200, Jiri Olsa escreveu: On Fri, Jun 19, 2015 at 06:07:13PM -0300, Arnaldo Carvalho de Melo wrote: Em Thu, Jun 18, 2015 at 11:48:40PM +0200, Jiri Olsa escreveu: We need to store command names with the pid. Changing map to be struct holding pid. Process

Re: [PATCH 01/26] perf tools: Change thread_map::map into struct

2015-06-19 Thread Jiri Olsa
On Fri, Jun 19, 2015 at 06:07:13PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Jun 18, 2015 at 11:48:40PM +0200, Jiri Olsa escreveu: > > We need to store command names with the pid. Changing > > map to be struct holding pid. Process name is coming > > in shortly. > > > > Link:

Re: [PATCH 01/26] perf tools: Change thread_map::map into struct

2015-06-19 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 18, 2015 at 11:48:40PM +0200, Jiri Olsa escreveu: > We need to store command names with the pid. Changing > map to be struct holding pid. Process name is coming > in shortly. > > Link: http://lkml.kernel.org/n/tip-z4zuyvcxa6glzqm8qubk6...@git.kernel.org > Signed-off-by: Jiri Olsa >

Re: [PATCH 01/26] perf tools: Change thread_map::map into struct

2015-06-19 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 18, 2015 at 11:48:40PM +0200, Jiri Olsa escreveu: We need to store command names with the pid. Changing map to be struct holding pid. Process name is coming in shortly. Link: http://lkml.kernel.org/n/tip-z4zuyvcxa6glzqm8qubk6...@git.kernel.org Signed-off-by: Jiri Olsa

Re: [PATCH 01/26] perf tools: Change thread_map::map into struct

2015-06-19 Thread Jiri Olsa
On Fri, Jun 19, 2015 at 06:07:13PM -0300, Arnaldo Carvalho de Melo wrote: Em Thu, Jun 18, 2015 at 11:48:40PM +0200, Jiri Olsa escreveu: We need to store command names with the pid. Changing map to be struct holding pid. Process name is coming in shortly. Link: