Re: [PATCH 02/12] media: hantro: Do not reorder H264 scaling list

2019-09-10 Thread Ezequiel Garcia
Hi Jonas, Thanks for your patch. On Mon, 2019-09-02 at 16:18 +, Jonas Karlman wrote: [..] > > > > diff --git a/drivers/staging/media/hantro/hantro_h264.c > > > b/drivers/staging/media/hantro/hantro_h264.c > > > index 0d758e0c0f99..e2d01145ac4f 100644 > > > ---

Re: [PATCH 02/12] media: hantro: Do not reorder H264 scaling list

2019-09-03 Thread Philipp Zabel
On Tue, 2019-09-03 at 07:54 +, Jonas Karlman wrote: [...] > After a closer look both ffmpeg and rkmpp only apply zig-zag scan and not > field scan, > ffmpeg will memcpy the scaling_matrix4/8 as is for vaapi, vdpau and nvdec, > for dxva2 there is a workaround flag that controls if zig-zag

Re: [PATCH 02/12] media: hantro: Do not reorder H264 scaling list

2019-09-03 Thread Philipp Zabel
On Mon, 2019-09-02 at 16:18 +, Jonas Karlman wrote: > On 2019-09-02 16:00, Philipp Zabel wrote: > > Hi Jonas, > > > > On Sun, 2019-09-01 at 12:45 +, Jonas Karlman wrote: > > > Scaling list supplied from userspace using ffmpeg and libva-v4l2-request > > > is already in matrix order and can

Re: [PATCH 02/12] media: hantro: Do not reorder H264 scaling list

2019-09-03 Thread Jonas Karlman
On 2019-09-02 18:18, Jonas Karlman wrote: > On 2019-09-02 16:00, Philipp Zabel wrote: >> Hi Jonas, >> >> On Sun, 2019-09-01 at 12:45 +, Jonas Karlman wrote: >>> Scaling list supplied from userspace using ffmpeg and libva-v4l2-request >>> is already in matrix order and can be used without

Re: [PATCH 02/12] media: hantro: Do not reorder H264 scaling list

2019-09-02 Thread Jonas Karlman
On 2019-09-02 16:00, Philipp Zabel wrote: > Hi Jonas, > > On Sun, 2019-09-01 at 12:45 +, Jonas Karlman wrote: >> Scaling list supplied from userspace using ffmpeg and libva-v4l2-request >> is already in matrix order and can be used without applying the inverse >> scanning process. > "in matrix

Re: [PATCH 02/12] media: hantro: Do not reorder H264 scaling list

2019-09-02 Thread Philipp Zabel
Hi Jonas, On Sun, 2019-09-01 at 12:45 +, Jonas Karlman wrote: > Scaling list supplied from userspace using ffmpeg and libva-v4l2-request > is already in matrix order and can be used without applying the inverse > scanning process. "in matrix order" is equivalent to "in raster scan order"?