Re: [PATCH 02/16] mm: vmstat: use s32 for vm_node_stat_diff in struct per_cpu_nodestat

2019-10-21 Thread Christopher Lameter
On Mon, 21 Oct 2019, Roman Gushchin wrote: > Sp far I haven't noticed any regression on the set of workloads where I did > test > the patchset, but if you know any benchmark or realistic test which can > affected > by this check, I'll be happy to try. > > Also, less-than-word-sized operations

Re: [PATCH 02/16] mm: vmstat: use s32 for vm_node_stat_diff in struct per_cpu_nodestat

2019-10-20 Thread Roman Gushchin
On Sun, Oct 20, 2019 at 10:51:10PM +, Christopher Lameter wrote: > On Thu, 17 Oct 2019, Roman Gushchin wrote: > > > Currently s8 type is used for per-cpu caching of per-node statistics. > > It works fine because the overfill threshold can't exceed 125. > > > > But if some counters are in

Re: [PATCH 02/16] mm: vmstat: use s32 for vm_node_stat_diff in struct per_cpu_nodestat

2019-10-20 Thread Roman Gushchin
On Sun, Oct 20, 2019 at 10:44:10PM +, Christopher Lameter wrote: > On Thu, 17 Oct 2019, Roman Gushchin wrote: > > > But if some counters are in bytes (and the next commit in the series > > will convert slab counters to bytes), it's not gonna work: > > value in bytes can easily exceed s8

Re: [PATCH 02/16] mm: vmstat: use s32 for vm_node_stat_diff in struct per_cpu_nodestat

2019-10-20 Thread Christopher Lameter
On Thu, 17 Oct 2019, Roman Gushchin wrote: > Currently s8 type is used for per-cpu caching of per-node statistics. > It works fine because the overfill threshold can't exceed 125. > > But if some counters are in bytes (and the next commit in the series > will convert slab counters to bytes), it's

Re: [PATCH 02/16] mm: vmstat: use s32 for vm_node_stat_diff in struct per_cpu_nodestat

2019-10-20 Thread Christopher Lameter
On Thu, 17 Oct 2019, Roman Gushchin wrote: > But if some counters are in bytes (and the next commit in the series > will convert slab counters to bytes), it's not gonna work: > value in bytes can easily exceed s8 without exceeding the threshold > converted to bytes. So to avoid overfilling