Re: [PATCH 1/1] PCI: Dynids - passing driver data

2005-02-09 Thread Brian King
Adam Belay wrote: On Mon, Feb 07, 2005 at 02:18:20PM -0800, Greg KH wrote: On Mon, Feb 07, 2005 at 04:00:27PM -0600, [EMAIL PROTECTED] wrote: Currently, code exists in the pci layer to allow userspace to specify driver data when adding a pci dynamic id from sysfs. However, this data is never used

Re: [PATCH 1/1] PCI: Dynids - passing driver data

2005-02-09 Thread Brian King
Adam Belay wrote: On Mon, Feb 07, 2005 at 02:18:20PM -0800, Greg KH wrote: On Mon, Feb 07, 2005 at 04:00:27PM -0600, [EMAIL PROTECTED] wrote: Currently, code exists in the pci layer to allow userspace to specify driver data when adding a pci dynamic id from sysfs. However, this data is never used

Re: [PATCH 1/1] PCI: Dynids - passing driver data

2005-02-08 Thread Adam Belay
On Mon, Feb 07, 2005 at 02:18:20PM -0800, Greg KH wrote: > On Mon, Feb 07, 2005 at 04:00:27PM -0600, [EMAIL PROTECTED] wrote: > > > > Currently, code exists in the pci layer to allow userspace to specify > > driver data when adding a pci dynamic id from sysfs. However, this data > > is never used

Re: [PATCH 1/1] PCI: Dynids - passing driver data

2005-02-08 Thread Adam Belay
On Mon, Feb 07, 2005 at 02:18:20PM -0800, Greg KH wrote: On Mon, Feb 07, 2005 at 04:00:27PM -0600, [EMAIL PROTECTED] wrote: Currently, code exists in the pci layer to allow userspace to specify driver data when adding a pci dynamic id from sysfs. However, this data is never used and

Re: [PATCH 1/1] PCI: Dynids - passing driver data

2005-02-07 Thread Brian King
Martin Mares wrote: Hello! Which is a good thing, right? "driver_data" is usually a pointer to somewhere. Having userspace specify it would not be a good thing. That depends on the driver usage, and the patch allows it to be configurable and defaults to not being used. Maybe we could just

Re: [PATCH 1/1] PCI: Dynids - passing driver data

2005-02-07 Thread Martin Mares
Hello! > >Which is a good thing, right? "driver_data" is usually a pointer to > >somewhere. Having userspace specify it would not be a good thing. > > That depends on the driver usage, and the patch allows it to be > configurable and defaults to not being used. Maybe we could just define the

Re: [PATCH 1/1] PCI: Dynids - passing driver data

2005-02-07 Thread Brian King
Greg KH wrote: On Mon, Feb 07, 2005 at 04:00:27PM -0600, [EMAIL PROTECTED] wrote: Currently, code exists in the pci layer to allow userspace to specify driver data when adding a pci dynamic id from sysfs. However, this data is never used and there exists no way in the existing code to use it.

Re: [PATCH 1/1] PCI: Dynids - passing driver data

2005-02-07 Thread Greg KH
On Mon, Feb 07, 2005 at 04:00:27PM -0600, [EMAIL PROTECTED] wrote: > > Currently, code exists in the pci layer to allow userspace to specify > driver data when adding a pci dynamic id from sysfs. However, this data > is never used and there exists no way in the existing code to use it. Which is

Re: [PATCH 1/1] PCI: Dynids - passing driver data

2005-02-07 Thread Greg KH
On Mon, Feb 07, 2005 at 04:00:27PM -0600, [EMAIL PROTECTED] wrote: Currently, code exists in the pci layer to allow userspace to specify driver data when adding a pci dynamic id from sysfs. However, this data is never used and there exists no way in the existing code to use it. Which is a

Re: [PATCH 1/1] PCI: Dynids - passing driver data

2005-02-07 Thread Brian King
Greg KH wrote: On Mon, Feb 07, 2005 at 04:00:27PM -0600, [EMAIL PROTECTED] wrote: Currently, code exists in the pci layer to allow userspace to specify driver data when adding a pci dynamic id from sysfs. However, this data is never used and there exists no way in the existing code to use it.

Re: [PATCH 1/1] PCI: Dynids - passing driver data

2005-02-07 Thread Martin Mares
Hello! Which is a good thing, right? driver_data is usually a pointer to somewhere. Having userspace specify it would not be a good thing. That depends on the driver usage, and the patch allows it to be configurable and defaults to not being used. Maybe we could just define the

Re: [PATCH 1/1] PCI: Dynids - passing driver data

2005-02-07 Thread Brian King
Martin Mares wrote: Hello! Which is a good thing, right? driver_data is usually a pointer to somewhere. Having userspace specify it would not be a good thing. That depends on the driver usage, and the patch allows it to be configurable and defaults to not being used. Maybe we could just