Re: [PATCH 1/1] hfsplus: incorrect return value

2015-03-25 Thread Viacheslav Dubeyko
On Tue, 2015-03-24 at 20:44 -0400, Chengyu Song wrote: > In case of memory allocation error, the return should be -ENOMEM, > instead of -ENOSPC. > To be honest, I am not fully sure that such fix makes sense. Of course, it is possible to exchange -ENOSPC on -ENOMEM. But principally it is not

Re: [PATCH 1/1] hfsplus: incorrect return value

2015-03-25 Thread Sergei Antonov
Reviewed-by: Sergei Antonov CC-ing Andrew Morton. On 25 March 2015 at 01:44, Chengyu Song wrote: > In case of memory allocation error, the return should be -ENOMEM, > instead of -ENOSPC. > > Signed-off-by: Chengyu Song > --- > fs/hfsplus/dir.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH 1/1] hfsplus: incorrect return value

2015-03-25 Thread Sergei Antonov
Reviewed-by: Sergei Antonov sap...@gmail.com CC-ing Andrew Morton. On 25 March 2015 at 01:44, Chengyu Song cson...@gatech.edu wrote: In case of memory allocation error, the return should be -ENOMEM, instead of -ENOSPC. Signed-off-by: Chengyu Song cson...@gatech.edu --- fs/hfsplus/dir.c |

Re: [PATCH 1/1] hfsplus: incorrect return value

2015-03-25 Thread Viacheslav Dubeyko
On Tue, 2015-03-24 at 20:44 -0400, Chengyu Song wrote: In case of memory allocation error, the return should be -ENOMEM, instead of -ENOSPC. To be honest, I am not fully sure that such fix makes sense. Of course, it is possible to exchange -ENOSPC on -ENOMEM. But principally it is not