Re: [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range_node().

2014-08-12 Thread tangchen
On 08/13/2014 06:03 AM, Andrew Morton wrote: On Sun, 10 Aug 2014 14:12:03 +0800 Tang Chen wrote: In memblock_find_in_range_node(), we defeind ret as int. But it shoule be phys_addr_t because it is used to store the return value from __memblock_find_range_bottom_up(). The bug has not been

Re: [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range_node().

2014-08-12 Thread Andrew Morton
On Sun, 10 Aug 2014 14:12:03 +0800 Tang Chen wrote: > In memblock_find_in_range_node(), we defeind ret as int. But it shoule > be phys_addr_t because it is used to store the return value from > __memblock_find_range_bottom_up(). > > The bug has not been triggered because when allocating low

Re: [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range_node().

2014-08-12 Thread Andrew Morton
On Sun, 10 Aug 2014 14:12:03 +0800 Tang Chen tangc...@cn.fujitsu.com wrote: In memblock_find_in_range_node(), we defeind ret as int. But it shoule be phys_addr_t because it is used to store the return value from __memblock_find_range_bottom_up(). The bug has not been triggered because when

Re: [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range_node().

2014-08-12 Thread tangchen
On 08/13/2014 06:03 AM, Andrew Morton wrote: On Sun, 10 Aug 2014 14:12:03 +0800 Tang Chen tangc...@cn.fujitsu.com wrote: In memblock_find_in_range_node(), we defeind ret as int. But it shoule be phys_addr_t because it is used to store the return value from __memblock_find_range_bottom_up().

Re: [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range_node().

2014-08-10 Thread Xishi Qiu
On 2014/8/10 14:14, tangchen wrote: > Sorry, add Xishi Qiu > > On 08/10/2014 02:12 PM, Tang Chen wrote: >> In memblock_find_in_range_node(), we defeind ret as int. But it shoule >> be phys_addr_t because it is used to store the return value from >> __memblock_find_range_bottom_up(). >> >> The

Re: [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range_node().

2014-08-10 Thread tangchen
Sorry, add Xishi Qiu On 08/10/2014 02:12 PM, Tang Chen wrote: In memblock_find_in_range_node(), we defeind ret as int. But it shoule be phys_addr_t because it is used to store the return value from __memblock_find_range_bottom_up(). The bug has not been triggered because when allocating low

Re: [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range_node().

2014-08-10 Thread tangchen
Sorry, add Xishi Qiu qiuxi...@huawei.com On 08/10/2014 02:12 PM, Tang Chen wrote: In memblock_find_in_range_node(), we defeind ret as int. But it shoule be phys_addr_t because it is used to store the return value from __memblock_find_range_bottom_up(). The bug has not been triggered because

Re: [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range_node().

2014-08-10 Thread Xishi Qiu
On 2014/8/10 14:14, tangchen wrote: Sorry, add Xishi Qiu qiuxi...@huawei.com On 08/10/2014 02:12 PM, Tang Chen wrote: In memblock_find_in_range_node(), we defeind ret as int. But it shoule be phys_addr_t because it is used to store the return value from __memblock_find_range_bottom_up().