Re: [PATCH 1/1] xhci: Unconditionally switch ports to xHCI on powerup

2012-08-22 Thread Manoj Iyer
If this is a must-to-do thing for Intel Panther Point platform, then we need to make sure it's called on power up and resume. Yes, I think moving the code below hc_init label should work and I think it's a better solution than your original patch. Yes it effects a lot of machines (Lenovo), I

Re: [PATCH 1/1] xhci: Unconditionally switch ports to xHCI on powerup

2012-08-22 Thread Manoj Iyer
If this is a must-to-do thing for Intel Panther Point platform, then we need to make sure it's called on power up and resume. Yes, I think moving the code below hc_init label should work and I think it's a better solution than your original patch. Yes it effects a lot of machines (Lenovo), I

Re: [PATCH 1/1] xhci: Unconditionally switch ports to xHCI on powerup

2012-08-21 Thread Andiry Xu
On Wed, Aug 22, 2012 at 12:16 AM, Manoj Iyer wrote: > > Looks like in pci-quirks.c, we enter the do() while() loop, reach the end of > extended capabilities and goto hc_init: label, skipping the switch. Probably > moving the switch under the hc_init label might work? Currently we switch >

Re: [PATCH 1/1] xhci: Unconditionally switch ports to xHCI on powerup

2012-08-21 Thread Manoj Iyer
Looks like in pci-quirks.c, we enter the do() while() loop, reach the end of extended capabilities and goto hc_init: label, skipping the switch. Probably moving the switch under the hc_init label might work? Currently we switch unconditionally on resume, so we could do the same at powerup as

Re: [PATCH 1/1] xhci: Unconditionally switch ports to xHCI on powerup

2012-08-21 Thread Andiry Xu
On Tue, Aug 21, 2012 at 12:06 PM, wrote: > From: Manoj Iyer > > USB 3.0 devices show up as high-speed devices on powerup, after an > s3 cycle they are correctly recognized as SuperSpeed. At powerup > unconditionally switch the port to xHCI like we do when we resume > from suspend. > > BugLink:

Re: [PATCH 1/1] xhci: Unconditionally switch ports to xHCI on powerup

2012-08-21 Thread Sergei Shtylyov
Hello. On 21-08-2012 8:06, manoj.i...@canonical.com wrote: From: Manoj Iyer USB 3.0 devices show up as high-speed devices on powerup, after an s3 cycle they are correctly recognized as SuperSpeed. At powerup unconditionally switch the port to xHCI like we do when we resume from suspend.

Re: [PATCH 1/1] xhci: Unconditionally switch ports to xHCI on powerup

2012-08-21 Thread Andiry Xu
On Wed, Aug 22, 2012 at 12:16 AM, Manoj Iyer manoj.i...@canonical.com wrote: Looks like in pci-quirks.c, we enter the do() while() loop, reach the end of extended capabilities and goto hc_init: label, skipping the switch. Probably moving the switch under the hc_init label might work? Currently

Re: [PATCH 1/1] xhci: Unconditionally switch ports to xHCI on powerup

2012-08-21 Thread Sergei Shtylyov
Hello. On 21-08-2012 8:06, manoj.i...@canonical.com wrote: From: Manoj Iyer manoj.i...@canonical.com USB 3.0 devices show up as high-speed devices on powerup, after an s3 cycle they are correctly recognized as SuperSpeed. At powerup unconditionally switch the port to xHCI like we do when we

Re: [PATCH 1/1] xhci: Unconditionally switch ports to xHCI on powerup

2012-08-21 Thread Andiry Xu
On Tue, Aug 21, 2012 at 12:06 PM, manoj.i...@canonical.com wrote: From: Manoj Iyer manoj.i...@canonical.com USB 3.0 devices show up as high-speed devices on powerup, after an s3 cycle they are correctly recognized as SuperSpeed. At powerup unconditionally switch the port to xHCI like we do

Re: [PATCH 1/1] xhci: Unconditionally switch ports to xHCI on powerup

2012-08-21 Thread Manoj Iyer
Looks like in pci-quirks.c, we enter the do() while() loop, reach the end of extended capabilities and goto hc_init: label, skipping the switch. Probably moving the switch under the hc_init label might work? Currently we switch unconditionally on resume, so we could do the same at powerup as