Re: [PATCH 1/2] ASoC: pxa: add binding for pxa2xx-ac97 audio complex

2018-06-14 Thread Mark Brown
On Wed, Jun 13, 2018 at 09:00:19PM +0200, Robert Jarzmik wrote: > Rob Herring writes: > > On Mon, Jun 11, 2018 at 10:22:10PM +0200, Robert Jarzmik wrote: > >> +Required properties: > >> + - compatible: "marvell,pxa2xx-ac97" > > Don't use wildcards in compatible strings. Though this is so

Re: [PATCH 1/2] ASoC: pxa: add binding for pxa2xx-ac97 audio complex

2018-06-14 Thread Mark Brown
On Wed, Jun 13, 2018 at 09:00:19PM +0200, Robert Jarzmik wrote: > Rob Herring writes: > > On Mon, Jun 11, 2018 at 10:22:10PM +0200, Robert Jarzmik wrote: > >> +Required properties: > >> + - compatible: "marvell,pxa2xx-ac97" > > Don't use wildcards in compatible strings. Though this is so

Re: [PATCH 1/2] ASoC: pxa: add binding for pxa2xx-ac97 audio complex

2018-06-13 Thread Robert Jarzmik
Rob Herring writes: > On Mon, Jun 11, 2018 at 10:22:10PM +0200, Robert Jarzmik wrote: >> This adds a binding for the Marvell PXA audio complex, available in >> pxa2xx and pxa3xx variants. >> +Required properties: >> + - compatible: "marvell,pxa2xx-ac97" > > Don't use wildcards in compatible

Re: [PATCH 1/2] ASoC: pxa: add binding for pxa2xx-ac97 audio complex

2018-06-13 Thread Robert Jarzmik
Rob Herring writes: > On Mon, Jun 11, 2018 at 10:22:10PM +0200, Robert Jarzmik wrote: >> This adds a binding for the Marvell PXA audio complex, available in >> pxa2xx and pxa3xx variants. >> +Required properties: >> + - compatible: "marvell,pxa2xx-ac97" > > Don't use wildcards in compatible

Re: [PATCH 1/2] ASoC: pxa: add binding for pxa2xx-ac97 audio complex

2018-06-12 Thread Rob Herring
On Mon, Jun 11, 2018 at 10:22:10PM +0200, Robert Jarzmik wrote: > This adds a binding for the Marvell PXA audio complex, available in > pxa2xx and pxa3xx variants. > > Signed-off-by: Robert Jarzmik > --- > .../bindings/sound/marvell,pxa2xx-ac97.txt | 25 > ++ > 1

Re: [PATCH 1/2] ASoC: pxa: add binding for pxa2xx-ac97 audio complex

2018-06-12 Thread Rob Herring
On Mon, Jun 11, 2018 at 10:22:10PM +0200, Robert Jarzmik wrote: > This adds a binding for the Marvell PXA audio complex, available in > pxa2xx and pxa3xx variants. > > Signed-off-by: Robert Jarzmik > --- > .../bindings/sound/marvell,pxa2xx-ac97.txt | 25 > ++ > 1