Re: [PATCH 1/2] HID: logitech-dj: prevent false errors to be shown

2014-08-25 Thread Jiri Kosina
On Mon, 25 Aug 2014, Markus Trippelsdorf wrote: > > > Commit "HID: logitech: perform bounds checking on device_id early > > > enough" unfortunately leaks some errors to dmesg which are not real > > > ones: > > > - if the report is not a DJ one, then there is not point in checking > > > the

Re: [PATCH 1/2] HID: logitech-dj: prevent false errors to be shown

2014-08-25 Thread Markus Trippelsdorf
On 2014.08.25 at 02:50 -0500, Jiri Kosina wrote: > On Fri, 22 Aug 2014, Benjamin Tissoires wrote: > > > Commit "HID: logitech: perform bounds checking on device_id early > > enough" unfortunately leaks some errors to dmesg which are not real > > ones: > > - if the report is not a DJ one, then

Re: [PATCH 1/2] HID: logitech-dj: prevent false errors to be shown

2014-08-25 Thread Jiri Kosina
On Fri, 22 Aug 2014, Benjamin Tissoires wrote: > Commit "HID: logitech: perform bounds checking on device_id early > enough" unfortunately leaks some errors to dmesg which are not real > ones: > - if the report is not a DJ one, then there is not point in checking > the device_id > - the

Re: [PATCH 1/2] HID: logitech-dj: prevent false errors to be shown

2014-08-25 Thread Jiri Kosina
On Fri, 22 Aug 2014, Benjamin Tissoires wrote: Commit HID: logitech: perform bounds checking on device_id early enough unfortunately leaks some errors to dmesg which are not real ones: - if the report is not a DJ one, then there is not point in checking the device_id - the receiver (index

Re: [PATCH 1/2] HID: logitech-dj: prevent false errors to be shown

2014-08-25 Thread Markus Trippelsdorf
On 2014.08.25 at 02:50 -0500, Jiri Kosina wrote: On Fri, 22 Aug 2014, Benjamin Tissoires wrote: Commit HID: logitech: perform bounds checking on device_id early enough unfortunately leaks some errors to dmesg which are not real ones: - if the report is not a DJ one, then there is not

Re: [PATCH 1/2] HID: logitech-dj: prevent false errors to be shown

2014-08-25 Thread Jiri Kosina
On Mon, 25 Aug 2014, Markus Trippelsdorf wrote: Commit HID: logitech: perform bounds checking on device_id early enough unfortunately leaks some errors to dmesg which are not real ones: - if the report is not a DJ one, then there is not point in checking the device_id - the