On Wednesday 17 of October 2012 12:03:31 Viresh Kumar wrote:
> On 17 October 2012 11:56, Joe Perches wrote:
> > Oh good, but please use a space between KBUILD_MODNAME
> > and the quoted ": ".
>
> Anything technical behind it or just for code formatting? As output is
> same in both cases :)
>
>
On Wednesday 17 of October 2012 12:03:31 Viresh Kumar wrote:
On 17 October 2012 11:56, Joe Perches j...@perches.com wrote:
Oh good, but please use a space between KBUILD_MODNAME
and the quoted : .
Anything technical behind it or just for code formatting? As output is
same in both cases :)
On 17 October 2012 15:28, Sudeep KarkadaNagesha
wrote:
> May be kernel/Documentation/dynamic-debug-howto.txt is more up-to-date.
yes.
>> My usecase is a bit different. I want to see all bootprints with
>> cpufreq pr_debug
>> prints. So, this prefixing will help there.
> The document covers
On 17/10/12 10:39, Viresh Kumar wrote:
On 17 October 2012 14:55, Sudeep KarkadaNagesha
wrote:
With CONFIG_DYNAMIC_DEBUG, you can control(enable/disable) debug
prints at different levels (file, module, line, function)
Quickly went through this :)
On 17 October 2012 14:55, Sudeep KarkadaNagesha
wrote:
> With CONFIG_DYNAMIC_DEBUG, you can control(enable/disable) debug
> prints at different levels (file, module, line, function)
Quickly went through this :)
http://www.kernel.org/doc/ols/2009/ols2009-pages-39-46.pdf
My usecase is a bit
On 17/10/12 06:20, Viresh Kumar wrote:
With debug options on, it is difficult to locate cpufreq core's debug prints.
Fix this by prefixing debug prints with:
"cpufreq:"
With CONFIG_DYNAMIC_DEBUG, you can control(enable/disable) debug
prints at different levels (file, module, line, function)
On Wed, 2012-10-17 at 12:03 +0530, Viresh Kumar wrote:
> On 17 October 2012 11:56, Joe Perches wrote:
> > Oh good, but please use a space between KBUILD_MODNAME
> > and the quoted ": ".
>
> Anything technical behind it or just for code formatting?
Just code formatting though it makes it easier
On 17 October 2012 11:56, Joe Perches wrote:
> Oh good, but please use a space between KBUILD_MODNAME
> and the quoted ": ".
Anything technical behind it or just for code formatting? As output is
same in both cases :)
8<--8<---
From:
On Wed, 2012-10-17 at 11:47 +0530, Viresh Kumar wrote:
> On 17 October 2012 11:34, Joe Perches wrote:
> > I believe you are quoting KBUILD_MODNAME
>
> Yes. :(
> Far better output with this. Thanks.
Oh good, but please use a space between KBUILD_MODNAME
and the quoted ": ".
#define pr_fmt(fmt)
On 17 October 2012 11:34, Joe Perches wrote:
> I believe you are quoting KBUILD_MODNAME
Yes. :(
Far better output with this. Thanks.
@Rafael: Please consider below patch instead:
From: Viresh Kumar
Date: Wed, 17 Oct 2012 10:38:31 +0530
Subject: [PATCH] cpufreq: Improve debug prints
With
On Wed, 2012-10-17 at 11:25 +0530, Viresh Kumar wrote:
> On 17 October 2012 11:09, Joe Perches wrote:
> > On Wed, 2012-10-17 at 10:50 +0530, Viresh Kumar wrote:
> >> With debug options on, it is difficult to locate cpufreq core's debug
> >> prints.
> > []
> >> diff --git
On Wed, 2012-10-17 at 11:25 +0530, Viresh Kumar wrote:
On 17 October 2012 11:09, Joe Perches j...@perches.com wrote:
On Wed, 2012-10-17 at 10:50 +0530, Viresh Kumar wrote:
With debug options on, it is difficult to locate cpufreq core's debug
prints.
[]
diff --git
On 17 October 2012 11:34, Joe Perches j...@perches.com wrote:
I believe you are quoting KBUILD_MODNAME
Yes. :(
Far better output with this. Thanks.
@Rafael: Please consider below patch instead:
From: Viresh Kumar viresh.ku...@linaro.org
Date: Wed, 17 Oct 2012 10:38:31 +0530
Subject: [PATCH]
On Wed, 2012-10-17 at 11:47 +0530, Viresh Kumar wrote:
On 17 October 2012 11:34, Joe Perches j...@perches.com wrote:
I believe you are quoting KBUILD_MODNAME
Yes. :(
Far better output with this. Thanks.
Oh good, but please use a space between KBUILD_MODNAME
and the quoted : .
#define
On 17 October 2012 11:56, Joe Perches j...@perches.com wrote:
Oh good, but please use a space between KBUILD_MODNAME
and the quoted : .
Anything technical behind it or just for code formatting? As output is
same in both cases :)
On Wed, 2012-10-17 at 12:03 +0530, Viresh Kumar wrote:
On 17 October 2012 11:56, Joe Perches j...@perches.com wrote:
Oh good, but please use a space between KBUILD_MODNAME
and the quoted : .
Anything technical behind it or just for code formatting?
Just code formatting though it makes it
On 17/10/12 06:20, Viresh Kumar wrote:
With debug options on, it is difficult to locate cpufreq core's debug prints.
Fix this by prefixing debug prints with:
cpufreq:
With CONFIG_DYNAMIC_DEBUG, you can control(enable/disable) debug
prints at different levels (file, module, line, function)
On 17 October 2012 14:55, Sudeep KarkadaNagesha
sudeep.karkadanage...@arm.com wrote:
With CONFIG_DYNAMIC_DEBUG, you can control(enable/disable) debug
prints at different levels (file, module, line, function)
Quickly went through this :)
http://www.kernel.org/doc/ols/2009/ols2009-pages-39-46.pdf
On 17/10/12 10:39, Viresh Kumar wrote:
On 17 October 2012 14:55, Sudeep KarkadaNagesha
sudeep.karkadanage...@arm.com wrote:
With CONFIG_DYNAMIC_DEBUG, you can control(enable/disable) debug
prints at different levels (file, module, line, function)
Quickly went through this :)
On 17 October 2012 15:28, Sudeep KarkadaNagesha
sudeep.karkadanage...@arm.com wrote:
May be kernel/Documentation/dynamic-debug-howto.txt is more up-to-date.
yes.
My usecase is a bit different. I want to see all bootprints with
cpufreq pr_debug
prints. So, this prefixing will help there.
On 17 October 2012 11:09, Joe Perches wrote:
> On Wed, 2012-10-17 at 10:50 +0530, Viresh Kumar wrote:
>> With debug options on, it is difficult to locate cpufreq core's debug prints.
> []
>> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> []
>> @@ -15,6 +15,8 @@
>> +#define
On Wed, 2012-10-17 at 10:50 +0530, Viresh Kumar wrote:
> With debug options on, it is difficult to locate cpufreq core's debug prints.
[]
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
[]
> @@ -15,6 +15,8 @@
> +#define pr_fmt(fmt) "cpufreq: " fmt
I'd prefer that
#define
On Wed, 2012-10-17 at 10:50 +0530, Viresh Kumar wrote:
With debug options on, it is difficult to locate cpufreq core's debug prints.
[]
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
[]
@@ -15,6 +15,8 @@
+#define pr_fmt(fmt) cpufreq: fmt
I'd prefer that
#define
On 17 October 2012 11:09, Joe Perches j...@perches.com wrote:
On Wed, 2012-10-17 at 10:50 +0530, Viresh Kumar wrote:
With debug options on, it is difficult to locate cpufreq core's debug prints.
[]
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
[]
@@ -15,6 +15,8 @@
24 matches
Mail list logo
