Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-02-08 Thread John Hubbard
On 2/8/19 2:32 AM, Mike Rapoport wrote: On Thu, Feb 07, 2019 at 11:56:48PM -0800, john.hubb...@gmail.com wrote: From: John Hubbard [...] +/** + * put_user_page() - release a gup-pinned page + * @page:pointer to page to be released + * + * Pages that were pinned via

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-02-08 Thread Mike Rapoport
On Thu, Feb 07, 2019 at 11:56:48PM -0800, john.hubb...@gmail.com wrote: > From: John Hubbard > > Introduces put_user_page(), which simply calls put_page(). > This provides a way to update all get_user_pages*() callers, > so that they call put_user_page(), instead of put_page(). > > Also

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-29 Thread John Hubbard
On 1/29/19 2:12 AM, Jan Kara wrote: > On Mon 28-01-19 22:41:41, John Hubbard wrote: [...] >> Here is the case I'm wondering about: >> >> thread A thread B >> >> gup_fast >> page_mkclean

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-29 Thread Jan Kara
On Mon 28-01-19 22:41:41, John Hubbard wrote: > On 1/28/19 5:23 PM, Jerome Glisse wrote: > > On Mon, Jan 28, 2019 at 04:22:16PM -0800, John Hubbard wrote: > > > On 1/23/19 11:04 AM, Jerome Glisse wrote: > > > > On Wed, Jan 23, 2019 at 07:02:30PM +0100, Jan Kara wrote: > > > > > On Tue 22-01-19

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-28 Thread John Hubbard
On 1/28/19 5:23 PM, Jerome Glisse wrote: On Mon, Jan 28, 2019 at 04:22:16PM -0800, John Hubbard wrote: On 1/23/19 11:04 AM, Jerome Glisse wrote: On Wed, Jan 23, 2019 at 07:02:30PM +0100, Jan Kara wrote: On Tue 22-01-19 11:46:13, Jerome Glisse wrote: On Tue, Jan 22, 2019 at 04:24:59PM +0100,

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-28 Thread Jerome Glisse
On Mon, Jan 28, 2019 at 04:22:16PM -0800, John Hubbard wrote: > On 1/23/19 11:04 AM, Jerome Glisse wrote: > > On Wed, Jan 23, 2019 at 07:02:30PM +0100, Jan Kara wrote: > >> On Tue 22-01-19 11:46:13, Jerome Glisse wrote: > >>> On Tue, Jan 22, 2019 at 04:24:59PM +0100, Jan Kara wrote: > On Thu

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-28 Thread John Hubbard
On 1/23/19 11:04 AM, Jerome Glisse wrote: > On Wed, Jan 23, 2019 at 07:02:30PM +0100, Jan Kara wrote: >> On Tue 22-01-19 11:46:13, Jerome Glisse wrote: >>> On Tue, Jan 22, 2019 at 04:24:59PM +0100, Jan Kara wrote: On Thu 17-01-19 10:17:59, Jerome Glisse wrote: > On Thu, Jan 17, 2019 at

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-23 Thread Jerome Glisse
On Wed, Jan 23, 2019 at 07:02:30PM +0100, Jan Kara wrote: > On Tue 22-01-19 11:46:13, Jerome Glisse wrote: > > On Tue, Jan 22, 2019 at 04:24:59PM +0100, Jan Kara wrote: > > > On Thu 17-01-19 10:17:59, Jerome Glisse wrote: > > > > On Thu, Jan 17, 2019 at 10:30:47AM +0100, Jan Kara wrote: > > > > >

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-23 Thread Jan Kara
On Tue 22-01-19 11:46:13, Jerome Glisse wrote: > On Tue, Jan 22, 2019 at 04:24:59PM +0100, Jan Kara wrote: > > On Thu 17-01-19 10:17:59, Jerome Glisse wrote: > > > On Thu, Jan 17, 2019 at 10:30:47AM +0100, Jan Kara wrote: > > > > On Wed 16-01-19 08:08:14, Jerome Glisse wrote: > > > > > On Wed, Jan

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-22 Thread Jerome Glisse
On Tue, Jan 22, 2019 at 04:24:59PM +0100, Jan Kara wrote: > On Thu 17-01-19 10:17:59, Jerome Glisse wrote: > > On Thu, Jan 17, 2019 at 10:30:47AM +0100, Jan Kara wrote: > > > On Wed 16-01-19 08:08:14, Jerome Glisse wrote: > > > > On Wed, Jan 16, 2019 at 12:38:19PM +0100, Jan Kara wrote: > > > > >

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-22 Thread Jan Kara
On Thu 17-01-19 10:17:59, Jerome Glisse wrote: > On Thu, Jan 17, 2019 at 10:30:47AM +0100, Jan Kara wrote: > > On Wed 16-01-19 08:08:14, Jerome Glisse wrote: > > > On Wed, Jan 16, 2019 at 12:38:19PM +0100, Jan Kara wrote: > > > > On Tue 15-01-19 09:07:59, Jan Kara wrote: > > > > > Agreed. So with

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-17 Thread Jerome Glisse
On Fri, Jan 18, 2019 at 11:16:08AM +1100, Dave Chinner wrote: > On Thu, Jan 17, 2019 at 10:21:08AM -0500, Jerome Glisse wrote: > > On Wed, Jan 16, 2019 at 09:42:25PM -0800, John Hubbard wrote: > > > On 1/16/19 5:08 AM, Jerome Glisse wrote: > > > > On Wed, Jan 16, 2019 at 12:38:19PM +0100, Jan Kara

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-17 Thread Dave Chinner
On Thu, Jan 17, 2019 at 10:21:08AM -0500, Jerome Glisse wrote: > On Wed, Jan 16, 2019 at 09:42:25PM -0800, John Hubbard wrote: > > On 1/16/19 5:08 AM, Jerome Glisse wrote: > > > On Wed, Jan 16, 2019 at 12:38:19PM +0100, Jan Kara wrote: > > >> That actually touches on another question I wanted to

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-17 Thread Jerome Glisse
On Wed, Jan 16, 2019 at 09:42:25PM -0800, John Hubbard wrote: > On 1/16/19 5:08 AM, Jerome Glisse wrote: > > On Wed, Jan 16, 2019 at 12:38:19PM +0100, Jan Kara wrote: > >> On Tue 15-01-19 09:07:59, Jan Kara wrote: > >>> Agreed. So with page lock it would actually look like: > >>> > >>>

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-17 Thread Jerome Glisse
On Thu, Jan 17, 2019 at 10:30:47AM +0100, Jan Kara wrote: > On Wed 16-01-19 08:08:14, Jerome Glisse wrote: > > On Wed, Jan 16, 2019 at 12:38:19PM +0100, Jan Kara wrote: > > > On Tue 15-01-19 09:07:59, Jan Kara wrote: > > > > Agreed. So with page lock it would actually look like: > > > > > > > >

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-17 Thread Jan Kara
On Wed 16-01-19 08:08:14, Jerome Glisse wrote: > On Wed, Jan 16, 2019 at 12:38:19PM +0100, Jan Kara wrote: > > On Tue 15-01-19 09:07:59, Jan Kara wrote: > > > Agreed. So with page lock it would actually look like: > > > > > > get_page_pin() > > > lock_page(page); > > > wait_for_stable_page();

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-17 Thread Jan Kara
On Wed 16-01-19 21:25:05, John Hubbard wrote: > On 1/15/19 12:07 AM, Jan Kara wrote: > > [...] > >>> Also there is one more idea I had how to record number of pins in the > >>> page: > >>> > >>> #define PAGE_PIN_BIAS 1024 > >>> > >>> get_page_pin() > >>> atomic_add(>_refcount,

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-16 Thread John Hubbard
On 1/16/19 5:08 AM, Jerome Glisse wrote: > On Wed, Jan 16, 2019 at 12:38:19PM +0100, Jan Kara wrote: >> On Tue 15-01-19 09:07:59, Jan Kara wrote: >>> Agreed. So with page lock it would actually look like: >>> >>> get_page_pin() >>> lock_page(page); >>> wait_for_stable_page(); >>>

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-16 Thread John Hubbard
On 1/15/19 12:07 AM, Jan Kara wrote: > [...] >>> Also there is one more idea I had how to record number of pins in the page: >>> >>> #define PAGE_PIN_BIAS 1024 >>> >>> get_page_pin() >>> atomic_add(>_refcount, PAGE_PIN_BIAS); >>> >>> put_page_pin(); >>> atomic_add(>_refcount,

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-16 Thread Dave Chinner
On Wed, Jan 16, 2019 at 09:50:16AM -0500, Jerome Glisse wrote: > On Wed, Jan 16, 2019 at 03:34:55PM +1100, Dave Chinner wrote: > > On Tue, Jan 15, 2019 at 09:23:12PM -0500, Jerome Glisse wrote: > > > On Tue, Jan 15, 2019 at 06:01:09PM -0800, Dan Williams wrote: > > > > On Tue, Jan 15, 2019 at 5:56

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-16 Thread Jerome Glisse
On Wed, Jan 16, 2019 at 03:34:55PM +1100, Dave Chinner wrote: > On Tue, Jan 15, 2019 at 09:23:12PM -0500, Jerome Glisse wrote: > > On Tue, Jan 15, 2019 at 06:01:09PM -0800, Dan Williams wrote: > > > On Tue, Jan 15, 2019 at 5:56 PM Jerome Glisse wrote: > > > > On Tue, Jan 15, 2019 at 04:44:41PM

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-16 Thread Jerome Glisse
On Wed, Jan 16, 2019 at 12:38:19PM +0100, Jan Kara wrote: > On Tue 15-01-19 09:07:59, Jan Kara wrote: > > Agreed. So with page lock it would actually look like: > > > > get_page_pin() > > lock_page(page); > > wait_for_stable_page(); > > atomic_add(>_refcount, PAGE_PIN_BIAS); > >

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-16 Thread Jan Kara
On Tue 15-01-19 09:07:59, Jan Kara wrote: > Agreed. So with page lock it would actually look like: > > get_page_pin() > lock_page(page); > wait_for_stable_page(); > atomic_add(>_refcount, PAGE_PIN_BIAS); > unlock_page(page); > > And if we perform page_pinned() check under

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-15 Thread Dave Chinner
On Tue, Jan 15, 2019 at 09:23:12PM -0500, Jerome Glisse wrote: > On Tue, Jan 15, 2019 at 06:01:09PM -0800, Dan Williams wrote: > > On Tue, Jan 15, 2019 at 5:56 PM Jerome Glisse wrote: > > > On Tue, Jan 15, 2019 at 04:44:41PM -0800, John Hubbard wrote: > > [..] > > > To make it clear. > > > > > >

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-15 Thread Jerome Glisse
On Tue, Jan 15, 2019 at 06:01:09PM -0800, Dan Williams wrote: > On Tue, Jan 15, 2019 at 5:56 PM Jerome Glisse wrote: > > On Tue, Jan 15, 2019 at 04:44:41PM -0800, John Hubbard wrote: > [..] > > To make it clear. > > > > Lock code: > > GUP() > > ... > > lock_page(page); > >

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-15 Thread Dan Williams
On Tue, Jan 15, 2019 at 5:56 PM Jerome Glisse wrote: > On Tue, Jan 15, 2019 at 04:44:41PM -0800, John Hubbard wrote: [..] > To make it clear. > > Lock code: > GUP() > ... > lock_page(page); > if (PageWriteback(page)) { > unlock_page(page); >

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-15 Thread Jerome Glisse
On Tue, Jan 15, 2019 at 04:44:41PM -0800, John Hubbard wrote: > On 1/15/19 2:12 PM, Jerome Glisse wrote: > > On Tue, Jan 15, 2019 at 01:56:51PM -0800, John Hubbard wrote: > >> On 1/15/19 9:15 AM, Jerome Glisse wrote: > >>> On Tue, Jan 15, 2019 at 09:07:59AM +0100, Jan Kara wrote: > On Mon

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-15 Thread John Hubbard
On 1/15/19 2:12 PM, Jerome Glisse wrote: > On Tue, Jan 15, 2019 at 01:56:51PM -0800, John Hubbard wrote: >> On 1/15/19 9:15 AM, Jerome Glisse wrote: >>> On Tue, Jan 15, 2019 at 09:07:59AM +0100, Jan Kara wrote: On Mon 14-01-19 12:21:25, Jerome Glisse wrote: > On Mon, Jan 14, 2019 at

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-15 Thread Jerome Glisse
On Tue, Jan 15, 2019 at 01:56:51PM -0800, John Hubbard wrote: > On 1/15/19 9:15 AM, Jerome Glisse wrote: > > On Tue, Jan 15, 2019 at 09:07:59AM +0100, Jan Kara wrote: > >> On Mon 14-01-19 12:21:25, Jerome Glisse wrote: > >>> On Mon, Jan 14, 2019 at 03:54:47PM +0100, Jan Kara wrote: > On Fri

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-15 Thread John Hubbard
On 1/15/19 9:15 AM, Jerome Glisse wrote: > On Tue, Jan 15, 2019 at 09:07:59AM +0100, Jan Kara wrote: >> On Mon 14-01-19 12:21:25, Jerome Glisse wrote: >>> On Mon, Jan 14, 2019 at 03:54:47PM +0100, Jan Kara wrote: On Fri 11-01-19 19:06:08, John Hubbard wrote: > On 1/11/19 6:46 PM, Jerome

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-15 Thread John Hubbard
On 1/15/19 12:34 AM, Jan Kara wrote: > On Mon 14-01-19 11:09:20, John Hubbard wrote: >> On 1/14/19 9:21 AM, Jerome Glisse wrote: [...] > >> For example, the following already survives a basic boot to graphics mode. >> It requires a bunch of callsite conversions, and a page flag (neither of

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-15 Thread Jerome Glisse
On Tue, Jan 15, 2019 at 09:07:59AM +0100, Jan Kara wrote: > On Mon 14-01-19 12:21:25, Jerome Glisse wrote: > > On Mon, Jan 14, 2019 at 03:54:47PM +0100, Jan Kara wrote: > > > On Fri 11-01-19 19:06:08, John Hubbard wrote: > > > > On 1/11/19 6:46 PM, Jerome Glisse wrote: > > > > > On Fri, Jan 11,

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-15 Thread Jan Kara
On Mon 14-01-19 11:09:20, John Hubbard wrote: > On 1/14/19 9:21 AM, Jerome Glisse wrote: > >> > >> Also there is one more idea I had how to record number of pins in the page: > >> > >> #define PAGE_PIN_BIAS 1024 > >> > >> get_page_pin() > >>atomic_add(>_refcount, PAGE_PIN_BIAS); > >> > >>

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-15 Thread Jan Kara
On Mon 14-01-19 12:21:25, Jerome Glisse wrote: > On Mon, Jan 14, 2019 at 03:54:47PM +0100, Jan Kara wrote: > > On Fri 11-01-19 19:06:08, John Hubbard wrote: > > > On 1/11/19 6:46 PM, Jerome Glisse wrote: > > > > On Fri, Jan 11, 2019 at 06:38:44PM -0800, John Hubbard wrote: > > > > [...] > > > > >

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-14 Thread John Hubbard
On 1/14/19 9:21 AM, Jerome Glisse wrote: > On Mon, Jan 14, 2019 at 03:54:47PM +0100, Jan Kara wrote: >> On Fri 11-01-19 19:06:08, John Hubbard wrote: >>> On 1/11/19 6:46 PM, Jerome Glisse wrote: On Fri, Jan 11, 2019 at 06:38:44PM -0800, John Hubbard wrote: [...] >>> The other

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-14 Thread Jerome Glisse
On Mon, Jan 14, 2019 at 03:54:47PM +0100, Jan Kara wrote: > On Fri 11-01-19 19:06:08, John Hubbard wrote: > > On 1/11/19 6:46 PM, Jerome Glisse wrote: > > > On Fri, Jan 11, 2019 at 06:38:44PM -0800, John Hubbard wrote: > > > [...] > > > > > The other idea that you and Dan (and maybe others)

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-14 Thread Jan Kara
On Fri 11-01-19 19:06:08, John Hubbard wrote: > On 1/11/19 6:46 PM, Jerome Glisse wrote: > > On Fri, Jan 11, 2019 at 06:38:44PM -0800, John Hubbard wrote: > > [...] > > > The other idea that you and Dan (and maybe others) pointed out was a > debug > option, which we'll certainly

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-12 Thread John Hubbard
On 1/11/19 7:25 PM, Jerome Glisse wrote: [...] Why is it that page lock cannot be used for gup fast, btw? >>> >>> Well it can not happen within the preempt disable section. But after >>> as a post pass before GUP_fast return and after reenabling preempt then >>> it is fine like it would be

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-11 Thread Jerome Glisse
On Fri, Jan 11, 2019 at 07:06:08PM -0800, John Hubbard wrote: > On 1/11/19 6:46 PM, Jerome Glisse wrote: > > On Fri, Jan 11, 2019 at 06:38:44PM -0800, John Hubbard wrote: > >> On 1/11/19 6:02 PM, Jerome Glisse wrote: > >>> On Fri, Jan 11, 2019 at 05:04:05PM -0800, John Hubbard wrote: > On

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-11 Thread Jerome Glisse
On Fri, Jan 11, 2019 at 06:38:44PM -0800, John Hubbard wrote: > On 1/11/19 6:02 PM, Jerome Glisse wrote: > > On Fri, Jan 11, 2019 at 05:04:05PM -0800, John Hubbard wrote: > >> On 1/11/19 8:51 AM, Jerome Glisse wrote: > >>> On Thu, Jan 10, 2019 at 06:59:31PM -0800, John Hubbard wrote: > On

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-11 Thread John Hubbard
On 1/11/19 6:46 PM, Jerome Glisse wrote: > On Fri, Jan 11, 2019 at 06:38:44PM -0800, John Hubbard wrote: >> On 1/11/19 6:02 PM, Jerome Glisse wrote: >>> On Fri, Jan 11, 2019 at 05:04:05PM -0800, John Hubbard wrote: On 1/11/19 8:51 AM, Jerome Glisse wrote: > On Thu, Jan 10, 2019 at

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-11 Thread Jerome Glisse
On Fri, Jan 11, 2019 at 06:38:44PM -0800, John Hubbard wrote: > On 1/11/19 6:02 PM, Jerome Glisse wrote: > > On Fri, Jan 11, 2019 at 05:04:05PM -0800, John Hubbard wrote: > >> On 1/11/19 8:51 AM, Jerome Glisse wrote: > >>> On Thu, Jan 10, 2019 at 06:59:31PM -0800, John Hubbard wrote: > On

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-11 Thread John Hubbard
On 1/11/19 6:02 PM, Jerome Glisse wrote: > On Fri, Jan 11, 2019 at 05:04:05PM -0800, John Hubbard wrote: >> On 1/11/19 8:51 AM, Jerome Glisse wrote: >>> On Thu, Jan 10, 2019 at 06:59:31PM -0800, John Hubbard wrote: On 1/3/19 6:44 AM, Jerome Glisse wrote: > On Thu, Jan 03, 2019 at

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-11 Thread Jerome Glisse
On Fri, Jan 11, 2019 at 05:04:05PM -0800, John Hubbard wrote: > On 1/11/19 8:51 AM, Jerome Glisse wrote: > > On Thu, Jan 10, 2019 at 06:59:31PM -0800, John Hubbard wrote: > >> On 1/3/19 6:44 AM, Jerome Glisse wrote: > >>> On Thu, Jan 03, 2019 at 10:26:54AM +0100, Jan Kara wrote: > On Wed

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-11 Thread John Hubbard
On 1/11/19 8:51 AM, Jerome Glisse wrote: > On Thu, Jan 10, 2019 at 06:59:31PM -0800, John Hubbard wrote: >> On 1/3/19 6:44 AM, Jerome Glisse wrote: >>> On Thu, Jan 03, 2019 at 10:26:54AM +0100, Jan Kara wrote: On Wed 02-01-19 20:55:33, Jerome Glisse wrote: > On Wed, Dec 19, 2018 at

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-11 Thread Jerome Glisse
On Thu, Jan 10, 2019 at 06:59:31PM -0800, John Hubbard wrote: > On 1/3/19 6:44 AM, Jerome Glisse wrote: > > On Thu, Jan 03, 2019 at 10:26:54AM +0100, Jan Kara wrote: > >> On Wed 02-01-19 20:55:33, Jerome Glisse wrote: > >>> On Wed, Dec 19, 2018 at 12:08:56PM +0100, Jan Kara wrote: > On Tue

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-10 Thread John Hubbard
On 1/3/19 6:44 AM, Jerome Glisse wrote: > On Thu, Jan 03, 2019 at 10:26:54AM +0100, Jan Kara wrote: >> On Wed 02-01-19 20:55:33, Jerome Glisse wrote: >>> On Wed, Dec 19, 2018 at 12:08:56PM +0100, Jan Kara wrote: On Tue 18-12-18 21:07:24, Jerome Glisse wrote: > On Tue, Dec 18, 2018 at

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-03 Thread Jerome Glisse
On Wed, Jan 02, 2019 at 07:27:17PM -0800, John Hubbard wrote: > On 1/2/19 5:55 PM, Jerome Glisse wrote: > > On Wed, Dec 19, 2018 at 12:08:56PM +0100, Jan Kara wrote: > >> On Tue 18-12-18 21:07:24, Jerome Glisse wrote: > >>> On Tue, Dec 18, 2018 at 03:29:34PM -0800, John Hubbard wrote: > OK,

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-03 Thread Jerome Glisse
On Thu, Jan 03, 2019 at 10:26:54AM +0100, Jan Kara wrote: > On Wed 02-01-19 20:55:33, Jerome Glisse wrote: > > On Wed, Dec 19, 2018 at 12:08:56PM +0100, Jan Kara wrote: > > > On Tue 18-12-18 21:07:24, Jerome Glisse wrote: > > > > On Tue, Dec 18, 2018 at 03:29:34PM -0800, John Hubbard wrote: > > >

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-03 Thread Jan Kara
On Wed 02-01-19 20:55:33, Jerome Glisse wrote: > On Wed, Dec 19, 2018 at 12:08:56PM +0100, Jan Kara wrote: > > On Tue 18-12-18 21:07:24, Jerome Glisse wrote: > > > On Tue, Dec 18, 2018 at 03:29:34PM -0800, John Hubbard wrote: > > > > OK, so let's take another look at Jerome's _mapcount idea all by

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-02 Thread John Hubbard
On 1/2/19 5:55 PM, Jerome Glisse wrote: > On Wed, Dec 19, 2018 at 12:08:56PM +0100, Jan Kara wrote: >> On Tue 18-12-18 21:07:24, Jerome Glisse wrote: >>> On Tue, Dec 18, 2018 at 03:29:34PM -0800, John Hubbard wrote: OK, so let's take another look at Jerome's _mapcount idea all by itself

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-02 Thread Jerome Glisse
On Wed, Dec 19, 2018 at 12:08:56PM +0100, Jan Kara wrote: > On Tue 18-12-18 21:07:24, Jerome Glisse wrote: > > On Tue, Dec 18, 2018 at 03:29:34PM -0800, John Hubbard wrote: > > > OK, so let's take another look at Jerome's _mapcount idea all by itself > > > (using > > > *only* the tracking pinned

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-20 Thread Dan Williams
On Thu, Dec 20, 2018 at 8:50 AM Jerome Glisse wrote: > > On Thu, Dec 20, 2018 at 02:54:49AM -0800, John Hubbard wrote: > > On 12/19/18 3:08 AM, Jan Kara wrote: > > > On Tue 18-12-18 21:07:24, Jerome Glisse wrote: > > >> On Tue, Dec 18, 2018 at 03:29:34PM -0800, John Hubbard wrote: > > >>> OK, so

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-20 Thread Jerome Glisse
On Thu, Dec 20, 2018 at 09:33:12AM +1100, Dave Chinner wrote: > On Wed, Dec 19, 2018 at 12:35:40PM +0100, Jan Kara wrote: > > On Wed 19-12-18 21:28:25, Dave Chinner wrote: > > > On Tue, Dec 18, 2018 at 08:03:29PM -0700, Jason Gunthorpe wrote: > > > > On Wed, Dec 19, 2018 at 10:42:54AM +1100, Dave

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-20 Thread Jerome Glisse
On Thu, Dec 20, 2018 at 02:54:49AM -0800, John Hubbard wrote: > On 12/19/18 3:08 AM, Jan Kara wrote: > > On Tue 18-12-18 21:07:24, Jerome Glisse wrote: > >> On Tue, Dec 18, 2018 at 03:29:34PM -0800, John Hubbard wrote: > >>> OK, so let's take another look at Jerome's _mapcount idea all by itself

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-20 Thread Jerome Glisse
On Wed, Dec 19, 2018 at 12:08:56PM +0100, Jan Kara wrote: > On Tue 18-12-18 21:07:24, Jerome Glisse wrote: > > On Tue, Dec 18, 2018 at 03:29:34PM -0800, John Hubbard wrote: > > > OK, so let's take another look at Jerome's _mapcount idea all by itself > > > (using > > > *only* the tracking pinned

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-20 Thread John Hubbard
On 12/19/18 3:08 AM, Jan Kara wrote: > On Tue 18-12-18 21:07:24, Jerome Glisse wrote: >> On Tue, Dec 18, 2018 at 03:29:34PM -0800, John Hubbard wrote: >>> OK, so let's take another look at Jerome's _mapcount idea all by itself >>> (using >>> *only* the tracking pinned pages aspect), given that it

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-20 Thread Jan Kara
On Thu 20-12-18 09:33:12, Dave Chinner wrote: > On Wed, Dec 19, 2018 at 12:35:40PM +0100, Jan Kara wrote: > > On Wed 19-12-18 21:28:25, Dave Chinner wrote: > > > On Tue, Dec 18, 2018 at 08:03:29PM -0700, Jason Gunthorpe wrote: > > > > On Wed, Dec 19, 2018 at 10:42:54AM +1100, Dave Chinner wrote: >

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-19 Thread Dave Chinner
On Wed, Dec 19, 2018 at 12:35:40PM +0100, Jan Kara wrote: > On Wed 19-12-18 21:28:25, Dave Chinner wrote: > > On Tue, Dec 18, 2018 at 08:03:29PM -0700, Jason Gunthorpe wrote: > > > On Wed, Dec 19, 2018 at 10:42:54AM +1100, Dave Chinner wrote: > > > > > > > Essentially, what we are talking about

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-19 Thread Jason Gunthorpe
On Wed, Dec 19, 2018 at 12:35:40PM +0100, Jan Kara wrote: > On Wed 19-12-18 21:28:25, Dave Chinner wrote: > > On Tue, Dec 18, 2018 at 08:03:29PM -0700, Jason Gunthorpe wrote: > > > On Wed, Dec 19, 2018 at 10:42:54AM +1100, Dave Chinner wrote: > > > > > > > Essentially, what we are talking about

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-19 Thread Jan Kara
On Wed 19-12-18 10:42:54, Dave Chinner wrote: > On Tue, Dec 18, 2018 at 11:33:06AM +0100, Jan Kara wrote: > > On Mon 17-12-18 08:58:19, Dave Chinner wrote: > > > On Fri, Dec 14, 2018 at 04:43:21PM +0100, Jan Kara wrote: > > > > Yes, for filesystem it is too late. But the plan we figured back in >

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-19 Thread Jan Kara
On Wed 19-12-18 21:28:25, Dave Chinner wrote: > On Tue, Dec 18, 2018 at 08:03:29PM -0700, Jason Gunthorpe wrote: > > On Wed, Dec 19, 2018 at 10:42:54AM +1100, Dave Chinner wrote: > > > > > Essentially, what we are talking about is how to handle broken > > > hardware. I say we should just brun it

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-19 Thread Jan Kara
On Tue 18-12-18 21:26:28, Dan Williams wrote: > On Tue, Dec 18, 2018 at 7:03 PM Jason Gunthorpe wrote: > > > > On Wed, Dec 19, 2018 at 10:42:54AM +1100, Dave Chinner wrote: > > > > > Essentially, what we are talking about is how to handle broken > > > hardware. I say we should just brun it with

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-19 Thread Jan Kara
On Tue 18-12-18 21:07:24, Jerome Glisse wrote: > On Tue, Dec 18, 2018 at 03:29:34PM -0800, John Hubbard wrote: > > OK, so let's take another look at Jerome's _mapcount idea all by itself > > (using > > *only* the tracking pinned pages aspect), given that it is the lightest > > weight > >

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-19 Thread Dave Chinner
On Tue, Dec 18, 2018 at 08:03:29PM -0700, Jason Gunthorpe wrote: > On Wed, Dec 19, 2018 at 10:42:54AM +1100, Dave Chinner wrote: > > > Essentially, what we are talking about is how to handle broken > > hardware. I say we should just brun it with napalm and thermite > > (i.e. taint the kernel with

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-18 Thread Dan Williams
On Tue, Dec 18, 2018 at 7:03 PM Jason Gunthorpe wrote: > > On Wed, Dec 19, 2018 at 10:42:54AM +1100, Dave Chinner wrote: > > > Essentially, what we are talking about is how to handle broken > > hardware. I say we should just brun it with napalm and thermite > > (i.e. taint the kernel with

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-18 Thread Jason Gunthorpe
On Wed, Dec 19, 2018 at 10:42:54AM +1100, Dave Chinner wrote: > Essentially, what we are talking about is how to handle broken > hardware. I say we should just brun it with napalm and thermite > (i.e. taint the kernel with "unsupportable hardware") and force > wait_for_stable_page() to trigger

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-18 Thread Jerome Glisse
On Tue, Dec 18, 2018 at 03:29:34PM -0800, John Hubbard wrote: > On 12/18/18 1:30 AM, Jan Kara wrote: > > On Mon 17-12-18 10:34:43, Matthew Wilcox wrote: > >> On Mon, Dec 17, 2018 at 01:11:50PM -0500, Jerome Glisse wrote: > >>> On Mon, Dec 17, 2018 at 08:58:19AM +1100, Dave Chinner wrote: >

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-18 Thread Dave Chinner
On Tue, Dec 18, 2018 at 11:33:06AM +0100, Jan Kara wrote: > On Mon 17-12-18 08:58:19, Dave Chinner wrote: > > On Fri, Dec 14, 2018 at 04:43:21PM +0100, Jan Kara wrote: > > > Hi! > > > > > > On Thu 13-12-18 08:46:41, Dave Chinner wrote: > > > > On Wed, Dec 12, 2018 at 10:03:20AM -0500, Jerome

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-18 Thread John Hubbard
On 12/18/18 1:30 AM, Jan Kara wrote: > On Mon 17-12-18 10:34:43, Matthew Wilcox wrote: >> On Mon, Dec 17, 2018 at 01:11:50PM -0500, Jerome Glisse wrote: >>> On Mon, Dec 17, 2018 at 08:58:19AM +1100, Dave Chinner wrote: Sure, that's a possibility, but that doesn't close off any race

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-18 Thread Jan Kara
On Mon 17-12-18 08:58:19, Dave Chinner wrote: > On Fri, Dec 14, 2018 at 04:43:21PM +0100, Jan Kara wrote: > > Hi! > > > > On Thu 13-12-18 08:46:41, Dave Chinner wrote: > > > On Wed, Dec 12, 2018 at 10:03:20AM -0500, Jerome Glisse wrote: > > > > On Mon, Dec 10, 2018 at 11:28:46AM +0100, Jan Kara

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-18 Thread Jan Kara
On Mon 17-12-18 10:34:43, Matthew Wilcox wrote: > On Mon, Dec 17, 2018 at 01:11:50PM -0500, Jerome Glisse wrote: > > On Mon, Dec 17, 2018 at 08:58:19AM +1100, Dave Chinner wrote: > > > Sure, that's a possibility, but that doesn't close off any race > > > conditions because there can be DMA into

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-17 Thread Darrick J. Wong
On Mon, Dec 17, 2018 at 10:34:43AM -0800, Matthew Wilcox wrote: > On Mon, Dec 17, 2018 at 01:11:50PM -0500, Jerome Glisse wrote: > > On Mon, Dec 17, 2018 at 08:58:19AM +1100, Dave Chinner wrote: > > > Sure, that's a possibility, but that doesn't close off any race > > > conditions because there

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-17 Thread Dave Chinner
On Mon, Dec 17, 2018 at 10:34:43AM -0800, Matthew Wilcox wrote: > On Mon, Dec 17, 2018 at 01:11:50PM -0500, Jerome Glisse wrote: > > On Mon, Dec 17, 2018 at 08:58:19AM +1100, Dave Chinner wrote: > > > Sure, that's a possibility, but that doesn't close off any race > > > conditions because there

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-17 Thread Jerome Glisse
On Mon, Dec 17, 2018 at 01:03:58PM -0800, Matthew Wilcox wrote: > On Mon, Dec 17, 2018 at 03:55:01PM -0500, Jerome Glisse wrote: > > On Mon, Dec 17, 2018 at 11:59:22AM -0800, Matthew Wilcox wrote: > > > On Mon, Dec 17, 2018 at 02:54:08PM -0500, Jerome Glisse wrote: > > > > On Mon, Dec 17, 2018 at

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-17 Thread Matthew Wilcox
On Mon, Dec 17, 2018 at 03:55:01PM -0500, Jerome Glisse wrote: > On Mon, Dec 17, 2018 at 11:59:22AM -0800, Matthew Wilcox wrote: > > On Mon, Dec 17, 2018 at 02:54:08PM -0500, Jerome Glisse wrote: > > > On Mon, Dec 17, 2018 at 11:51:51AM -0800, Matthew Wilcox wrote: > > > > On Mon, Dec 17, 2018 at

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-17 Thread Jerome Glisse
On Mon, Dec 17, 2018 at 11:59:22AM -0800, Matthew Wilcox wrote: > On Mon, Dec 17, 2018 at 02:54:08PM -0500, Jerome Glisse wrote: > > On Mon, Dec 17, 2018 at 11:51:51AM -0800, Matthew Wilcox wrote: > > > On Mon, Dec 17, 2018 at 02:48:00PM -0500, Jerome Glisse wrote: > > > > On Mon, Dec 17, 2018 at

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-17 Thread Matthew Wilcox
On Mon, Dec 17, 2018 at 02:54:08PM -0500, Jerome Glisse wrote: > On Mon, Dec 17, 2018 at 11:51:51AM -0800, Matthew Wilcox wrote: > > On Mon, Dec 17, 2018 at 02:48:00PM -0500, Jerome Glisse wrote: > > > On Mon, Dec 17, 2018 at 10:34:43AM -0800, Matthew Wilcox wrote: > > > > No. The solution John,

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-17 Thread Jerome Glisse
On Mon, Dec 17, 2018 at 11:51:51AM -0800, Matthew Wilcox wrote: > On Mon, Dec 17, 2018 at 02:48:00PM -0500, Jerome Glisse wrote: > > On Mon, Dec 17, 2018 at 10:34:43AM -0800, Matthew Wilcox wrote: > > > On Mon, Dec 17, 2018 at 01:11:50PM -0500, Jerome Glisse wrote: > > > > On Mon, Dec 17, 2018 at

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-17 Thread Matthew Wilcox
On Mon, Dec 17, 2018 at 02:48:00PM -0500, Jerome Glisse wrote: > On Mon, Dec 17, 2018 at 10:34:43AM -0800, Matthew Wilcox wrote: > > On Mon, Dec 17, 2018 at 01:11:50PM -0500, Jerome Glisse wrote: > > > On Mon, Dec 17, 2018 at 08:58:19AM +1100, Dave Chinner wrote: > > > > Sure, that's a

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-17 Thread Jerome Glisse
On Mon, Dec 17, 2018 at 10:34:43AM -0800, Matthew Wilcox wrote: > On Mon, Dec 17, 2018 at 01:11:50PM -0500, Jerome Glisse wrote: > > On Mon, Dec 17, 2018 at 08:58:19AM +1100, Dave Chinner wrote: > > > Sure, that's a possibility, but that doesn't close off any race > > > conditions because there

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-17 Thread Matthew Wilcox
On Mon, Dec 17, 2018 at 01:11:50PM -0500, Jerome Glisse wrote: > On Mon, Dec 17, 2018 at 08:58:19AM +1100, Dave Chinner wrote: > > Sure, that's a possibility, but that doesn't close off any race > > conditions because there can be DMA into the page in progress while > > the page is being bounced,

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-17 Thread Dan Williams
On Mon, Dec 17, 2018 at 12:57 AM Jan Kara wrote: > > On Fri 14-12-18 11:38:59, Dan Williams wrote: > > On Thu, Dec 13, 2018 at 10:11 PM John Hubbard wrote: > > > > > > On 12/13/18 9:21 PM, Dan Williams wrote: > > > > On Thu, Dec 13, 2018 at 7:53 PM John Hubbard > > > > wrote: > > > >> > > > >>

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-17 Thread Jerome Glisse
On Mon, Dec 17, 2018 at 08:58:19AM +1100, Dave Chinner wrote: > On Fri, Dec 14, 2018 at 04:43:21PM +0100, Jan Kara wrote: > > Hi! > > > > On Thu 13-12-18 08:46:41, Dave Chinner wrote: > > > On Wed, Dec 12, 2018 at 10:03:20AM -0500, Jerome Glisse wrote: > > > > On Mon, Dec 10, 2018 at 11:28:46AM

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-17 Thread Jan Kara
On Fri 14-12-18 11:38:59, Dan Williams wrote: > On Thu, Dec 13, 2018 at 10:11 PM John Hubbard wrote: > > > > On 12/13/18 9:21 PM, Dan Williams wrote: > > > On Thu, Dec 13, 2018 at 7:53 PM John Hubbard wrote: > > >> > > >> On 12/12/18 4:51 PM, Dave Chinner wrote: > > >>> On Wed, Dec 12, 2018 at

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-16 Thread Dave Chinner
On Fri, Dec 14, 2018 at 04:43:21PM +0100, Jan Kara wrote: > Hi! > > On Thu 13-12-18 08:46:41, Dave Chinner wrote: > > On Wed, Dec 12, 2018 at 10:03:20AM -0500, Jerome Glisse wrote: > > > On Mon, Dec 10, 2018 at 11:28:46AM +0100, Jan Kara wrote: > > > > On Fri 07-12-18 21:24:46, Jerome Glisse

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-14 Thread John Hubbard
On 12/14/18 12:03 PM, Matthew Wilcox wrote: > On Fri, Dec 14, 2018 at 11:53:31AM -0800, Dave Hansen wrote: >> On 12/14/18 11:48 AM, Matthew Wilcox wrote: >>> I think we can do better than a proxy object with bit 0 set. I'd go >>> for allocating something like this: >>> >>> struct dynamic_page {

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-14 Thread Matthew Wilcox
On Fri, Dec 14, 2018 at 12:17:08PM -0800, Dan Williams wrote: > On Fri, Dec 14, 2018 at 12:03 PM Matthew Wilcox wrote: > > Yes; working on the pfn-to-page structure right now as it happens ... > > in the meantime, an XArray for it probably wouldn't be _too_ bad. > > It might... see the recent

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-14 Thread Dan Williams
On Fri, Dec 14, 2018 at 12:03 PM Matthew Wilcox wrote: > > On Fri, Dec 14, 2018 at 11:53:31AM -0800, Dave Hansen wrote: > > On 12/14/18 11:48 AM, Matthew Wilcox wrote: > > > I think we can do better than a proxy object with bit 0 set. I'd go > > > for allocating something like this: > > > > > >

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-14 Thread Matthew Wilcox
On Fri, Dec 14, 2018 at 11:53:31AM -0800, Dave Hansen wrote: > On 12/14/18 11:48 AM, Matthew Wilcox wrote: > > I think we can do better than a proxy object with bit 0 set. I'd go > > for allocating something like this: > > > > struct dynamic_page { > > struct page; > > unsigned long

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-14 Thread Dave Hansen
On 12/14/18 11:48 AM, Matthew Wilcox wrote: > I think we can do better than a proxy object with bit 0 set. I'd go > for allocating something like this: > > struct dynamic_page { > struct page; > unsigned long vaddr; > unsigned long pfn; > ... > }; > > and use a bit in

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-14 Thread Matthew Wilcox
On Fri, Dec 14, 2018 at 11:38:59AM -0800, Dan Williams wrote: > On Thu, Dec 13, 2018 at 10:11 PM John Hubbard wrote: > > I don't have an answer for that, so maybe the page->mapping idea is dead > > already. > > > > So in that case, there is still one more way to do all of this, which is to > >

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-14 Thread Dan Williams
On Thu, Dec 13, 2018 at 10:11 PM John Hubbard wrote: > > On 12/13/18 9:21 PM, Dan Williams wrote: > > On Thu, Dec 13, 2018 at 7:53 PM John Hubbard wrote: > >> > >> On 12/12/18 4:51 PM, Dave Chinner wrote: > >>> On Wed, Dec 12, 2018 at 04:59:31PM -0500, Jerome Glisse wrote: > On Thu, Dec 13,

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-14 Thread Jan Kara
Hi! On Thu 13-12-18 08:46:41, Dave Chinner wrote: > On Wed, Dec 12, 2018 at 10:03:20AM -0500, Jerome Glisse wrote: > > On Mon, Dec 10, 2018 at 11:28:46AM +0100, Jan Kara wrote: > > > On Fri 07-12-18 21:24:46, Jerome Glisse wrote: > > > So this approach doesn't look like a win to me over using

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-14 Thread Jerome Glisse
On Fri, Dec 14, 2018 at 11:41:25AM +0100, Jan Kara wrote: > On Thu 13-12-18 07:43:25, Jerome Glisse wrote: > > On Wed, Dec 12, 2018 at 08:20:43PM -0700, Jason Gunthorpe wrote: > > > On Wed, Dec 12, 2018 at 07:01:09PM -0500, Jerome Glisse wrote: > > > > > Even the IOMMU idea probably doesn't work,

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-14 Thread Jerome Glisse
On Thu, Dec 13, 2018 at 10:11:09PM -0800, John Hubbard wrote: > On 12/13/18 9:21 PM, Dan Williams wrote: > > On Thu, Dec 13, 2018 at 7:53 PM John Hubbard wrote: > >> > >> On 12/12/18 4:51 PM, Dave Chinner wrote: > >>> On Wed, Dec 12, 2018 at 04:59:31PM -0500, Jerome Glisse wrote: > On Thu,

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-14 Thread Jerome Glisse
On Fri, Dec 14, 2018 at 05:00:12PM +1100, Dave Chinner wrote: > On Wed, Dec 12, 2018 at 09:02:29PM -0500, Jerome Glisse wrote: > > On Thu, Dec 13, 2018 at 11:51:19AM +1100, Dave Chinner wrote: > > > On Wed, Dec 12, 2018 at 04:59:31PM -0500, Jerome Glisse wrote: > > > > On Thu, Dec 13, 2018 at

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-14 Thread Jan Kara
On Thu 13-12-18 07:43:25, Jerome Glisse wrote: > On Wed, Dec 12, 2018 at 08:20:43PM -0700, Jason Gunthorpe wrote: > > On Wed, Dec 12, 2018 at 07:01:09PM -0500, Jerome Glisse wrote: > > > > Even the IOMMU idea probably doesn't work, I doubt all current > > > > hardware can handle a PCI-E error TLP

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-13 Thread John Hubbard
On 12/13/18 9:21 PM, Dan Williams wrote: > On Thu, Dec 13, 2018 at 7:53 PM John Hubbard wrote: >> >> On 12/12/18 4:51 PM, Dave Chinner wrote: >>> On Wed, Dec 12, 2018 at 04:59:31PM -0500, Jerome Glisse wrote: On Thu, Dec 13, 2018 at 08:46:41AM +1100, Dave Chinner wrote: > On Wed, Dec 12,

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-13 Thread Dave Chinner
On Wed, Dec 12, 2018 at 09:02:29PM -0500, Jerome Glisse wrote: > On Thu, Dec 13, 2018 at 11:51:19AM +1100, Dave Chinner wrote: > > On Wed, Dec 12, 2018 at 04:59:31PM -0500, Jerome Glisse wrote: > > > On Thu, Dec 13, 2018 at 08:46:41AM +1100, Dave Chinner wrote: > > > > On Wed, Dec 12, 2018 at

  1   2   3   >