Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user

2016-10-24 Thread Michael Zoran
At this point, I need to take a step back from this whole thing and evaluate where this is all going. I started this arm64 thing for fun as a tinker idea, and it is quickly becoming more then I think I want to get involved with at this time. I'm not saying I won't return to this at a later time

Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user

2016-10-24 Thread Michael Zoran
At this point, I need to take a step back from this whole thing and evaluate where this is all going. I started this arm64 thing for fun as a tinker idea, and it is quickly becoming more then I think I want to get involved with at this time. I'm not saying I won't return to this at a later time

Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user

2016-10-24 Thread Dan Carpenter
If you want to wait for someone else to take over that's fine. If you want to send a patch that's also fine. There is not really strict ownership of anything in the kernel. Greg will take patches from anyone and he gets the last word wrt to drivers/staging/ (which sort of contradicts what I

Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user

2016-10-24 Thread Dan Carpenter
If you want to wait for someone else to take over that's fine. If you want to send a patch that's also fine. There is not really strict ownership of anything in the kernel. Greg will take patches from anyone and he gets the last word wrt to drivers/staging/ (which sort of contradicts what I

Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user

2016-10-24 Thread Michael Zoran
On Mon, 2016-10-24 at 15:23 +0200, Greg KH wrote: > On Sun, Oct 23, 2016 at 10:29:18PM -0700, mzo...@crowfest.net wrote: > > From: Michael Zoran > > > > Signed-off-by: Michael Zoran > > --- > >  

Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user

2016-10-24 Thread Michael Zoran
On Mon, 2016-10-24 at 15:23 +0200, Greg KH wrote: > On Sun, Oct 23, 2016 at 10:29:18PM -0700, mzo...@crowfest.net wrote: > > From: Michael Zoran > > > > Signed-off-by: Michael Zoran > > --- > >  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c > > | 2 +- > >  1 file changed, 1

Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user

2016-10-24 Thread Greg KH
On Sun, Oct 23, 2016 at 10:29:18PM -0700, mzo...@crowfest.net wrote: > From: Michael Zoran > > Signed-off-by: Michael Zoran > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user

2016-10-24 Thread Greg KH
On Sun, Oct 23, 2016 at 10:29:18PM -0700, mzo...@crowfest.net wrote: > From: Michael Zoran > > Signed-off-by: Michael Zoran > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git >

Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user

2016-10-24 Thread Dan Carpenter
I'm saying just be patient a bit. The devs are probably in CA and it's still 5:30 AM there... regards, dan carpenter

Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user

2016-10-24 Thread Dan Carpenter
I'm saying just be patient a bit. The devs are probably in CA and it's still 5:30 AM there... regards, dan carpenter

Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user

2016-10-24 Thread Michael Zoran
On Mon, 2016-10-24 at 14:58 +0300, Dan Carpenter wrote: > On Mon, Oct 24, 2016 at 04:39:49AM -0700, Michael Zoran wrote: > > On Mon, 2016-10-24 at 14:36 +0300, Dan Carpenter wrote: > > > On Mon, Oct 24, 2016 at 04:09:37AM -0700, Michael Zoran wrote: > > > > I didn't think it looked totally

Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user

2016-10-24 Thread Michael Zoran
On Mon, 2016-10-24 at 14:58 +0300, Dan Carpenter wrote: > On Mon, Oct 24, 2016 at 04:39:49AM -0700, Michael Zoran wrote: > > On Mon, 2016-10-24 at 14:36 +0300, Dan Carpenter wrote: > > > On Mon, Oct 24, 2016 at 04:09:37AM -0700, Michael Zoran wrote: > > > > I didn't think it looked totally

Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user

2016-10-24 Thread Dan Carpenter
On Mon, Oct 24, 2016 at 04:39:49AM -0700, Michael Zoran wrote: > On Mon, 2016-10-24 at 14:36 +0300, Dan Carpenter wrote: > > On Mon, Oct 24, 2016 at 04:09:37AM -0700, Michael Zoran wrote: > > > I didn't think it looked totally correct, but I'm not sure it's any > > > more broken then what is

Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user

2016-10-24 Thread Dan Carpenter
On Mon, Oct 24, 2016 at 04:39:49AM -0700, Michael Zoran wrote: > On Mon, 2016-10-24 at 14:36 +0300, Dan Carpenter wrote: > > On Mon, Oct 24, 2016 at 04:09:37AM -0700, Michael Zoran wrote: > > > I didn't think it looked totally correct, but I'm not sure it's any > > > more broken then what is

Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user

2016-10-24 Thread Michael Zoran
On Mon, 2016-10-24 at 14:36 +0300, Dan Carpenter wrote: > On Mon, Oct 24, 2016 at 04:09:37AM -0700, Michael Zoran wrote: > > I didn't think it looked totally correct, but I'm not sure it's any > > more broken then what is already in the tree. > > It's not more broken.  But better to leave the

Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user

2016-10-24 Thread Michael Zoran
On Mon, 2016-10-24 at 14:36 +0300, Dan Carpenter wrote: > On Mon, Oct 24, 2016 at 04:09:37AM -0700, Michael Zoran wrote: > > I didn't think it looked totally correct, but I'm not sure it's any > > more broken then what is already in the tree. > > It's not more broken.  But better to leave the

Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user

2016-10-24 Thread Dan Carpenter
On Mon, Oct 24, 2016 at 04:09:37AM -0700, Michael Zoran wrote: > I didn't think it looked totally correct, but I'm not sure it's any > more broken then what is already in the tree. It's not more broken. But better to leave the compile warning there to mark that it is an obvious security problem.

Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user

2016-10-24 Thread Dan Carpenter
On Mon, Oct 24, 2016 at 04:09:37AM -0700, Michael Zoran wrote: > I didn't think it looked totally correct, but I'm not sure it's any > more broken then what is already in the tree. It's not more broken. But better to leave the compile warning there to mark that it is an obvious security problem.

Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user

2016-10-24 Thread Michael Zoran
On Mon, 2016-10-24 at 13:54 +0300, Dan Carpenter wrote: > On Sun, Oct 23, 2016 at 10:29:18PM -0700, mzo...@crowfest.net wrote: > > From: Michael Zoran > > > > Signed-off-by: Michael Zoran > > --- > >  

Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user

2016-10-24 Thread Michael Zoran
On Mon, 2016-10-24 at 13:54 +0300, Dan Carpenter wrote: > On Sun, Oct 23, 2016 at 10:29:18PM -0700, mzo...@crowfest.net wrote: > > From: Michael Zoran > > > > Signed-off-by: Michael Zoran > > --- > >  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c > > | 2 +- > >  1 file

Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user

2016-10-24 Thread Dan Carpenter
On Sun, Oct 23, 2016 at 10:29:18PM -0700, mzo...@crowfest.net wrote: > From: Michael Zoran > > Signed-off-by: Michael Zoran > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user

2016-10-24 Thread Dan Carpenter
On Sun, Oct 23, 2016 at 10:29:18PM -0700, mzo...@crowfest.net wrote: > From: Michael Zoran > > Signed-off-by: Michael Zoran > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git >