Re: [PATCH 1/3] KVM - Add missing kvm_run initializations

2007-07-18 Thread Avi Kivity
Jeff Dike wrote: > On Tue, Jul 17, 2007 at 11:12:53AM +0300, Avi Kivity wrote: > >> I believe that emulate_instruction will set run->mmio if it returns >> EMULATE_DO_MMIO. >> > > Righto, forgot to check that. How about this patch instead? > > Set exit_reason to KVM_EXIT_MMIO where

Re: [PATCH 1/3] KVM - Add missing kvm_run initializations

2007-07-18 Thread Avi Kivity
Jeff Dike wrote: On Tue, Jul 17, 2007 at 11:12:53AM +0300, Avi Kivity wrote: I believe that emulate_instruction will set run-mmio if it returns EMULATE_DO_MMIO. Righto, forgot to check that. How about this patch instead? Set exit_reason to KVM_EXIT_MMIO where run-mmio is

Re: [PATCH 1/3] KVM - Add missing kvm_run initializations

2007-07-17 Thread Jeff Dike
On Tue, Jul 17, 2007 at 11:12:53AM +0300, Avi Kivity wrote: > I believe that emulate_instruction will set run->mmio if it returns > EMULATE_DO_MMIO. Righto, forgot to check that. How about this patch instead? Set exit_reason to KVM_EXIT_MMIO where run->mmio is initialized. Signed-off-by: Jeff

Re: [PATCH 1/3] KVM - Add missing kvm_run initializations

2007-07-17 Thread Avi Kivity
Jeff Dike wrote: There are a bunch of missing initializations of run->exit_reason and associated data. kvm_hypercall wasn't setting exit_reason at all. When exit_reason is KVM_EXIT_MMIO, the mmio data isn't initialized. I don't know what it should be, so I just stuck a FIXME in there. There

Re: [PATCH 1/3] KVM - Add missing kvm_run initializations

2007-07-17 Thread Avi Kivity
Jeff Dike wrote: There are a bunch of missing initializations of run-exit_reason and associated data. kvm_hypercall wasn't setting exit_reason at all. When exit_reason is KVM_EXIT_MMIO, the mmio data isn't initialized. I don't know what it should be, so I just stuck a FIXME in there. There

Re: [PATCH 1/3] KVM - Add missing kvm_run initializations

2007-07-17 Thread Jeff Dike
On Tue, Jul 17, 2007 at 11:12:53AM +0300, Avi Kivity wrote: I believe that emulate_instruction will set run-mmio if it returns EMULATE_DO_MMIO. Righto, forgot to check that. How about this patch instead? Set exit_reason to KVM_EXIT_MMIO where run-mmio is initialized. Signed-off-by: Jeff