Re: [PATCH 1/3] dt-bindings: added new pwm-sifive driver documentation

On Mon, Apr 30, 2018 at 12:45:20PM +0200, Andreas Färber wrote: > Am 30.04.2018 um 10:19 schrieb Thierry Reding: > > On Sun, Apr 29, 2018 at 02:08:07PM -0700, Wesley Terpstra wrote: > >> On Sun, Apr 29, 2018 at 2:01 PM, Andreas Färber wrote: > >>> "pwm0" sounds like a

Re: [PATCH 1/3] dt-bindings: added new pwm-sifive driver documentation

On Mon, Apr 30, 2018 at 12:45:20PM +0200, Andreas Färber wrote: > Am 30.04.2018 um 10:19 schrieb Thierry Reding: > > On Sun, Apr 29, 2018 at 02:08:07PM -0700, Wesley Terpstra wrote: > >> On Sun, Apr 29, 2018 at 2:01 PM, Andreas Färber wrote: > >>> "pwm0" sounds like a zero-indexed instance of

Re: [PATCH 1/3] dt-bindings: added new pwm-sifive driver documentation

On Mon, Apr 30, 2018 at 1:27 AM, Thierry Reding wrote: > I don't like the idea of specifying something in DT that is completely > approximate because it doesn't give users any kind of control over what > is considered acceptable. In some cases an approximation to within

Re: [PATCH 1/3] dt-bindings: added new pwm-sifive driver documentation

On Mon, Apr 30, 2018 at 1:27 AM, Thierry Reding wrote: > I don't like the idea of specifying something in DT that is completely > approximate because it doesn't give users any kind of control over what > is considered acceptable. In some cases an approximation to within 10% > might be acceptable,

Re: [PATCH 1/3] dt-bindings: added new pwm-sifive driver documentation

Am 30.04.2018 um 10:19 schrieb Thierry Reding: > On Sun, Apr 29, 2018 at 02:08:07PM -0700, Wesley Terpstra wrote: >> On Sun, Apr 29, 2018 at 2:01 PM, Andreas Färber wrote: >>> "pwm0" sounds like a zero-indexed instance of some pwm block. If 0 is >>> the version here, I'd suggest

Re: [PATCH 1/3] dt-bindings: added new pwm-sifive driver documentation

Am 30.04.2018 um 10:19 schrieb Thierry Reding: > On Sun, Apr 29, 2018 at 02:08:07PM -0700, Wesley Terpstra wrote: >> On Sun, Apr 29, 2018 at 2:01 PM, Andreas Färber wrote: >>> "pwm0" sounds like a zero-indexed instance of some pwm block. If 0 is >>> the version here, I'd suggest to make it

Re: [PATCH 1/3] dt-bindings: added new pwm-sifive driver documentation

On Fri, Apr 27, 2018 at 03:59:56PM -0700, Wesley W. Terpstra wrote: > Document new PWM device tree bindings for SiFive SoCs. > > Signed-off-by: Wesley W. Terpstra > --- > .../devicetree/bindings/pwm/pwm-sifive.txt | 28 > ++ > 1 file changed, 28

Re: [PATCH 1/3] dt-bindings: added new pwm-sifive driver documentation

On Fri, Apr 27, 2018 at 03:59:56PM -0700, Wesley W. Terpstra wrote: > Document new PWM device tree bindings for SiFive SoCs. > > Signed-off-by: Wesley W. Terpstra > --- > .../devicetree/bindings/pwm/pwm-sifive.txt | 28 > ++ > 1 file changed, 28 insertions(+) >

Re: [PATCH 1/3] dt-bindings: added new pwm-sifive driver documentation

On Sun, Apr 29, 2018 at 01:51:34PM -0700, Wesley Terpstra wrote: > On Sat, Apr 28, 2018 at 10:54 PM, Thierry Reding > wrote: > > On Fri, Apr 27, 2018 at 03:59:56PM -0700, Wesley W. Terpstra wrote: > >> +Unlike most other PWM controllers, the SiFive PWM controller

Re: [PATCH 1/3] dt-bindings: added new pwm-sifive driver documentation

On Sun, Apr 29, 2018 at 01:51:34PM -0700, Wesley Terpstra wrote: > On Sat, Apr 28, 2018 at 10:54 PM, Thierry Reding > wrote: > > On Fri, Apr 27, 2018 at 03:59:56PM -0700, Wesley W. Terpstra wrote: > >> +Unlike most other PWM controllers, the SiFive PWM controller currently > >> only > >>

Re: [PATCH 1/3] dt-bindings: added new pwm-sifive driver documentation

On Sun, Apr 29, 2018 at 02:08:07PM -0700, Wesley Terpstra wrote: > On Sun, Apr 29, 2018 at 2:01 PM, Andreas Färber wrote: > > "pwm0" sounds like a zero-indexed instance of some pwm block. If 0 is > > the version here, I'd suggest to make it "pwm-0" for example - you might > >

Re: [PATCH 1/3] dt-bindings: added new pwm-sifive driver documentation

On Sun, Apr 29, 2018 at 02:08:07PM -0700, Wesley Terpstra wrote: > On Sun, Apr 29, 2018 at 2:01 PM, Andreas Färber wrote: > > "pwm0" sounds like a zero-indexed instance of some pwm block. If 0 is > > the version here, I'd suggest to make it "pwm-0" for example - you might > > want to take a look

Re: [PATCH 1/3] dt-bindings: added new pwm-sifive driver documentation

On Sun, Apr 29, 2018 at 2:01 PM, Andreas Färber wrote: > "pwm0" sounds like a zero-indexed instance of some pwm block. If 0 is > the version here, I'd suggest to make it "pwm-0" for example - you might > want to take a look at the Xilinx bindings, which use a strict x.yy suffix.

Re: [PATCH 1/3] dt-bindings: added new pwm-sifive driver documentation

On Sun, Apr 29, 2018 at 2:01 PM, Andreas Färber wrote: > "pwm0" sounds like a zero-indexed instance of some pwm block. If 0 is > the version here, I'd suggest to make it "pwm-0" for example - you might > want to take a look at the Xilinx bindings, which use a strict x.yy suffix. That's fine.

Re: [PATCH 1/3] dt-bindings: added new pwm-sifive driver documentation

Am 29.04.2018 um 22:51 schrieb Wesley Terpstra: > On Sat, Apr 28, 2018 at 10:54 PM, Thierry Reding > wrote: >> On Fri, Apr 27, 2018 at 03:59:56PM -0700, Wesley W. Terpstra wrote: >>> +Required properties: >>> +- compatible: should be "sifive,pwm0" >> >> Why not simply

Re: [PATCH 1/3] dt-bindings: added new pwm-sifive driver documentation

Am 29.04.2018 um 22:51 schrieb Wesley Terpstra: > On Sat, Apr 28, 2018 at 10:54 PM, Thierry Reding > wrote: >> On Fri, Apr 27, 2018 at 03:59:56PM -0700, Wesley W. Terpstra wrote: >>> +Required properties: >>> +- compatible: should be "sifive,pwm0" >> >> Why not simply "sifive,pwm"? If this is

Re: [PATCH 1/3] dt-bindings: added new pwm-sifive driver documentation

On Sat, Apr 28, 2018 at 10:54 PM, Thierry Reding wrote: > On Fri, Apr 27, 2018 at 03:59:56PM -0700, Wesley W. Terpstra wrote: >> +Unlike most other PWM controllers, the SiFive PWM controller currently only >> +supports one period for all channels in the PWM. This is set

Re: [PATCH 1/3] dt-bindings: added new pwm-sifive driver documentation

On Sat, Apr 28, 2018 at 10:54 PM, Thierry Reding wrote: > On Fri, Apr 27, 2018 at 03:59:56PM -0700, Wesley W. Terpstra wrote: >> +Unlike most other PWM controllers, the SiFive PWM controller currently only >> +supports one period for all channels in the PWM. This is set globally in >> DTS. >>

Re: [PATCH 1/3] dt-bindings: added new pwm-sifive driver documentation

On Fri, Apr 27, 2018 at 03:59:56PM -0700, Wesley W. Terpstra wrote: > Document new PWM device tree bindings for SiFive SoCs. > > Signed-off-by: Wesley W. Terpstra > --- > .../devicetree/bindings/pwm/pwm-sifive.txt | 28 > ++ > 1 file changed, 28

Re: [PATCH 1/3] dt-bindings: added new pwm-sifive driver documentation

On Fri, Apr 27, 2018 at 03:59:56PM -0700, Wesley W. Terpstra wrote: > Document new PWM device tree bindings for SiFive SoCs. > > Signed-off-by: Wesley W. Terpstra > --- > .../devicetree/bindings/pwm/pwm-sifive.txt | 28 > ++ > 1 file changed, 28 insertions(+) >