Re: [PATCH 1/5] kfifo: remove unnecessary type check

2013-01-09 Thread Yuanhan Liu
On Wed, Jan 09, 2013 at 04:29:39PM +0100, Stefani Seibold wrote: > Am Mittwoch, den 09.01.2013, 10:35 +0800 schrieb Yuanhan Liu: > > On Tue, Jan 08, 2013 at 10:51:04PM +0100, Stefani Seibold wrote: > > > Am Dienstag, den 08.01.2013, 22:57 +0800 schrieb Yuanhan Liu: > > > > Firstly, this kind of

Re: [PATCH 1/5] kfifo: remove unnecessary type check

2013-01-09 Thread Stefani Seibold
Am Mittwoch, den 09.01.2013, 10:35 +0800 schrieb Yuanhan Liu: > On Tue, Jan 08, 2013 at 10:51:04PM +0100, Stefani Seibold wrote: > > Am Dienstag, den 08.01.2013, 22:57 +0800 schrieb Yuanhan Liu: > > > Firstly, this kind of type check doesn't work. It does something similar > > > as following: > >

Re: [PATCH 1/5] kfifo: remove unnecessary type check

2013-01-09 Thread Stefani Seibold
Am Mittwoch, den 09.01.2013, 10:35 +0800 schrieb Yuanhan Liu: On Tue, Jan 08, 2013 at 10:51:04PM +0100, Stefani Seibold wrote: Am Dienstag, den 08.01.2013, 22:57 +0800 schrieb Yuanhan Liu: Firstly, this kind of type check doesn't work. It does something similar as following: void *

Re: [PATCH 1/5] kfifo: remove unnecessary type check

2013-01-09 Thread Yuanhan Liu
On Wed, Jan 09, 2013 at 04:29:39PM +0100, Stefani Seibold wrote: Am Mittwoch, den 09.01.2013, 10:35 +0800 schrieb Yuanhan Liu: On Tue, Jan 08, 2013 at 10:51:04PM +0100, Stefani Seibold wrote: Am Dienstag, den 08.01.2013, 22:57 +0800 schrieb Yuanhan Liu: Firstly, this kind of type check

Re: [PATCH 1/5] kfifo: remove unnecessary type check

2013-01-08 Thread Yuanhan Liu
On Tue, Jan 08, 2013 at 10:51:04PM +0100, Stefani Seibold wrote: > Am Dienstag, den 08.01.2013, 22:57 +0800 schrieb Yuanhan Liu: > > Firstly, this kind of type check doesn't work. It does something similar > > as following: > > void * __dummy = NULL; > > __buf = __dummy; > > > > __dummy

Re: [PATCH 1/5] kfifo: remove unnecessary type check

2013-01-08 Thread Stefani Seibold
Am Dienstag, den 08.01.2013, 22:57 +0800 schrieb Yuanhan Liu: > Firstly, this kind of type check doesn't work. It does something similar > as following: > void * __dummy = NULL; > __buf = __dummy; > > __dummy is defined as void *. Thus it will not trigger warnings as > expected. > >

Re: [PATCH 1/5] kfifo: remove unnecessary type check

2013-01-08 Thread Stefani Seibold
Am Dienstag, den 08.01.2013, 22:57 +0800 schrieb Yuanhan Liu: Firstly, this kind of type check doesn't work. It does something similar as following: void * __dummy = NULL; __buf = __dummy; __dummy is defined as void *. Thus it will not trigger warnings as expected. Second,

Re: [PATCH 1/5] kfifo: remove unnecessary type check

2013-01-08 Thread Yuanhan Liu
On Tue, Jan 08, 2013 at 10:51:04PM +0100, Stefani Seibold wrote: Am Dienstag, den 08.01.2013, 22:57 +0800 schrieb Yuanhan Liu: Firstly, this kind of type check doesn't work. It does something similar as following: void * __dummy = NULL; __buf = __dummy; __dummy is defined as