Re: [PATCH 12/14 UPDATED] sysfs: implement sysfs_dirent active reference and immediate disconnect

2007-04-12 Thread Greg KH
On Wed, Apr 11, 2007 at 01:15:15PM +0900, Tejun Heo wrote: > [PATCH] sysfs: implement sysfs_dirent active reference and immediate > disconnect For some reason, this doesn't apply on top of your patches: Applying patch sysfs-implement-sysfs_dirent-active-reference-and-immediate-disconnect.patch

Re: [PATCH 12/14 UPDATED] sysfs: implement sysfs_dirent active reference and immediate disconnect

2007-04-12 Thread Greg KH
On Thu, Apr 12, 2007 at 12:18:15AM -0700, Greg KH wrote: > On Wed, Apr 11, 2007 at 01:15:15PM +0900, Tejun Heo wrote: > > [PATCH] sysfs: implement sysfs_dirent active reference and immediate > > disconnect > > For some reason, this doesn't apply on top of your patches: > > Applying patch >

Re: [PATCH 12/14 UPDATED] sysfs: implement sysfs_dirent active reference and immediate disconnect

2007-04-12 Thread Greg KH
On Wed, Apr 11, 2007 at 01:15:15PM +0900, Tejun Heo wrote: [PATCH] sysfs: implement sysfs_dirent active reference and immediate disconnect For some reason, this doesn't apply on top of your patches: Applying patch sysfs-implement-sysfs_dirent-active-reference-and-immediate-disconnect.patch

Re: [PATCH 12/14 UPDATED] sysfs: implement sysfs_dirent active reference and immediate disconnect

2007-04-12 Thread Greg KH
On Thu, Apr 12, 2007 at 12:18:15AM -0700, Greg KH wrote: On Wed, Apr 11, 2007 at 01:15:15PM +0900, Tejun Heo wrote: [PATCH] sysfs: implement sysfs_dirent active reference and immediate disconnect For some reason, this doesn't apply on top of your patches: Applying patch

Re: [PATCH 12/14 UPDATED] sysfs: implement sysfs_dirent active reference and immediate disconnect

2007-04-11 Thread Cornelia Huck
On Wed, 11 Apr 2007 19:13:59 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > Does this patch fix the problem? > > Index: work/fs/sysfs/dir.c > === > --- work.orig/fs/sysfs/dir.c 2007-04-11 19:12:02.0 +0900 > +++

Re: [PATCH 12/14 UPDATED] sysfs: implement sysfs_dirent active reference and immediate disconnect

2007-04-11 Thread Tejun Heo
On Wed, Apr 11, 2007 at 06:26:42PM +0900, Tejun Heo wrote: > Hello, > > Cornelia Huck wrote: > > === > > [ INFO: possible circular locking dependency detected ] > > 2.6.21-rc6-ge666c753-dirty #54 > >

Re: [PATCH 12/14 UPDATED] sysfs: implement sysfs_dirent active reference and immediate disconnect

2007-04-11 Thread Tejun Heo
Tejun Heo wrote: > Hello, > > Cornelia Huck wrote: >> === >> [ INFO: possible circular locking dependency detected ] >> 2.6.21-rc6-ge666c753-dirty #54 >> --- >> kslowcrw/64 is trying to acquire

Re: [PATCH 12/14 UPDATED] sysfs: implement sysfs_dirent active reference and immediate disconnect

2007-04-11 Thread Tejun Heo
Hello, Cornelia Huck wrote: > === > [ INFO: possible circular locking dependency detected ] > 2.6.21-rc6-ge666c753-dirty #54 > --- > kslowcrw/64 is trying to acquire lock: >

Re: [PATCH 12/14 UPDATED] sysfs: implement sysfs_dirent active reference and immediate disconnect

2007-04-11 Thread Cornelia Huck
On Wed, 11 Apr 2007 13:15:15 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > Cornelia, this should fix the problem you reported. It's caused by > doing up_write() on sysfs_dirent which is used for readdir cursor > which is not deactivated before being released. > release_sysfs_dirent() is udpated

Re: [PATCH 12/14 UPDATED] sysfs: implement sysfs_dirent active reference and immediate disconnect

2007-04-11 Thread Cornelia Huck
On Wed, 11 Apr 2007 13:15:15 +0900, Tejun Heo [EMAIL PROTECTED] wrote: Cornelia, this should fix the problem you reported. It's caused by doing up_write() on sysfs_dirent which is used for readdir cursor which is not deactivated before being released. release_sysfs_dirent() is udpated such

Re: [PATCH 12/14 UPDATED] sysfs: implement sysfs_dirent active reference and immediate disconnect

2007-04-11 Thread Tejun Heo
Hello, Cornelia Huck wrote: === [ INFO: possible circular locking dependency detected ] 2.6.21-rc6-ge666c753-dirty #54 --- kslowcrw/64 is trying to acquire lock: (sch-reg_mutex){--..},

Re: [PATCH 12/14 UPDATED] sysfs: implement sysfs_dirent active reference and immediate disconnect

2007-04-11 Thread Tejun Heo
Tejun Heo wrote: Hello, Cornelia Huck wrote: === [ INFO: possible circular locking dependency detected ] 2.6.21-rc6-ge666c753-dirty #54 --- kslowcrw/64 is trying to acquire lock:

Re: [PATCH 12/14 UPDATED] sysfs: implement sysfs_dirent active reference and immediate disconnect

2007-04-11 Thread Tejun Heo
On Wed, Apr 11, 2007 at 06:26:42PM +0900, Tejun Heo wrote: Hello, Cornelia Huck wrote: === [ INFO: possible circular locking dependency detected ] 2.6.21-rc6-ge666c753-dirty #54 ---

Re: [PATCH 12/14 UPDATED] sysfs: implement sysfs_dirent active reference and immediate disconnect

2007-04-11 Thread Cornelia Huck
On Wed, 11 Apr 2007 19:13:59 +0900, Tejun Heo [EMAIL PROTECTED] wrote: Does this patch fix the problem? Index: work/fs/sysfs/dir.c === --- work.orig/fs/sysfs/dir.c 2007-04-11 19:12:02.0 +0900 +++ work/fs/sysfs/dir.c