Re: [PATCH 13/15] ASoC: SND_S3C_DMA_LEGACY needs S3C24XX_DMA

2014-05-02 Thread Mark Brown
On Fri, May 02, 2014 at 12:25:58PM +0200, Heiko Stübner wrote: > Mark already removed support for the legacy API from the s3c64xx spi driver > (used by s3c2416 and s3c2443), so I guess to way forward would be to "simply" > convert asoc and s3cmci to dmaengine and get rid of it altogether. ASoC

Re: [PATCH 13/15] ASoC: SND_S3C_DMA_LEGACY needs S3C24XX_DMA

2014-05-02 Thread Mark Brown
On Fri, May 02, 2014 at 12:35:21AM +0200, Arnd Bergmann wrote: > On Thursday 01 May 2014 12:11:25 Mark Brown wrote: > > Why is the fix for this not to ensure that s3c24xx always enables the > > DMA controller - how likely is it that it would be sane to build a > > kernel without DMA after all? >

Re: [PATCH 13/15] ASoC: SND_S3C_DMA_LEGACY needs S3C24XX_DMA

2014-05-02 Thread Arnd Bergmann
On Friday 02 May 2014 12:25:58 Heiko Stübner wrote: > > Just to mention, we have a dmaengine driver for s3c24xx . Correct > platform-data is present for all s3c24xx socs (in mach-s3c24xx/common.c) . > > Mark already removed support for the legacy API from the s3c64xx spi driver > (used by

Re: [PATCH 13/15] ASoC: SND_S3C_DMA_LEGACY needs S3C24XX_DMA

2014-05-02 Thread Heiko Stübner
Hi Arnd, Am Freitag, 2. Mai 2014, 00:35:21 schrieb Arnd Bergmann: > On Thursday 01 May 2014 12:11:25 Mark Brown wrote: > > On Tue, Apr 29, 2014 at 07:18:34PM +0800, Xia Kaixu wrote: > > > From: Arnd Bergmann > > > > > > SND_S3C_DMA_LEGACY can only be set on S3C24xx, which does not > > > (yet)

Re: [PATCH 13/15] ASoC: SND_S3C_DMA_LEGACY needs S3C24XX_DMA

2014-05-02 Thread Heiko Stübner
Hi Arnd, Am Freitag, 2. Mai 2014, 00:35:21 schrieb Arnd Bergmann: On Thursday 01 May 2014 12:11:25 Mark Brown wrote: On Tue, Apr 29, 2014 at 07:18:34PM +0800, Xia Kaixu wrote: From: Arnd Bergmann a...@arndb.de SND_S3C_DMA_LEGACY can only be set on S3C24xx, which does not (yet)

Re: [PATCH 13/15] ASoC: SND_S3C_DMA_LEGACY needs S3C24XX_DMA

2014-05-02 Thread Arnd Bergmann
On Friday 02 May 2014 12:25:58 Heiko Stübner wrote: Just to mention, we have a dmaengine driver for s3c24xx . Correct platform-data is present for all s3c24xx socs (in mach-s3c24xx/common.c) . Mark already removed support for the legacy API from the s3c64xx spi driver (used by s3c2416

Re: [PATCH 13/15] ASoC: SND_S3C_DMA_LEGACY needs S3C24XX_DMA

2014-05-02 Thread Mark Brown
On Fri, May 02, 2014 at 12:35:21AM +0200, Arnd Bergmann wrote: On Thursday 01 May 2014 12:11:25 Mark Brown wrote: Why is the fix for this not to ensure that s3c24xx always enables the DMA controller - how likely is it that it would be sane to build a kernel without DMA after all?

Re: [PATCH 13/15] ASoC: SND_S3C_DMA_LEGACY needs S3C24XX_DMA

2014-05-02 Thread Mark Brown
On Fri, May 02, 2014 at 12:25:58PM +0200, Heiko Stübner wrote: Mark already removed support for the legacy API from the s3c64xx spi driver (used by s3c2416 and s3c2443), so I guess to way forward would be to simply convert asoc and s3cmci to dmaengine and get rid of it altogether. ASoC is

Re: [PATCH 13/15] ASoC: SND_S3C_DMA_LEGACY needs S3C24XX_DMA

2014-05-01 Thread Arnd Bergmann
On Thursday 01 May 2014 12:11:25 Mark Brown wrote: > On Tue, Apr 29, 2014 at 07:18:34PM +0800, Xia Kaixu wrote: > > From: Arnd Bergmann > > > > SND_S3C_DMA_LEGACY can only be set on S3C24xx, which does not > > (yet) support the dmaengine framework, so samsung_dma_get_ops() > > fails to link if

Re: [PATCH 13/15] ASoC: SND_S3C_DMA_LEGACY needs S3C24XX_DMA

2014-05-01 Thread Mark Brown
On Tue, Apr 29, 2014 at 07:18:34PM +0800, Xia Kaixu wrote: > From: Arnd Bergmann > > SND_S3C_DMA_LEGACY can only be set on S3C24xx, which does not > (yet) support the dmaengine framework, so samsung_dma_get_ops() > fails to link if S3C24XX_DMA is disabled: Why is the fix for this not to ensure

Re: [PATCH 13/15] ASoC: SND_S3C_DMA_LEGACY needs S3C24XX_DMA

2014-05-01 Thread Mark Brown
On Tue, Apr 29, 2014 at 07:18:34PM +0800, Xia Kaixu wrote: From: Arnd Bergmann a...@arndb.de SND_S3C_DMA_LEGACY can only be set on S3C24xx, which does not (yet) support the dmaengine framework, so samsung_dma_get_ops() fails to link if S3C24XX_DMA is disabled: Why is the fix for this not to

Re: [PATCH 13/15] ASoC: SND_S3C_DMA_LEGACY needs S3C24XX_DMA

2014-05-01 Thread Arnd Bergmann
On Thursday 01 May 2014 12:11:25 Mark Brown wrote: On Tue, Apr 29, 2014 at 07:18:34PM +0800, Xia Kaixu wrote: From: Arnd Bergmann a...@arndb.de SND_S3C_DMA_LEGACY can only be set on S3C24xx, which does not (yet) support the dmaengine framework, so samsung_dma_get_ops() fails to link if