Re: [PATCH 2/2] exec: Compute file based creds only once

2020-05-29 Thread Kees Cook
On Fri, May 29, 2020 at 10:28:41PM -0500, Eric W. Biederman wrote: > The range-diff winds up being: > 1: c9258ef4879b ! 1: a7868323c263 exec: Add a per bprm->file version of > per_clear > @@ Commit message > > History Tree: >

Re: [PATCH 2/2] exec: Compute file based creds only once

2020-05-29 Thread Eric W. Biederman
Kees Cook writes: > On Fri, May 29, 2020 at 11:47:29AM -0500, Eric W. Biederman wrote: >> diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h >> index cd3dd0afceb5..37bb3df751c6 100644 >> --- a/include/linux/lsm_hooks.h >> +++ b/include/linux/lsm_hooks.h >> @@ -44,18 +44,18 @@ >>

Re: [PATCH 2/2] exec: Compute file based creds only once

2020-05-29 Thread Kees Cook
On Fri, May 29, 2020 at 11:47:29AM -0500, Eric W. Biederman wrote: > Move the computation of creds from prepare_binfmt into begin_new_exec > so that the creds need only be computed once. This is just code > reorganization no semantic changes of any kind are made. > > Moving the computation is