Re: [PATCH 2/2] i2c: piix4: Use usleep_range()

> > /* If the SMBus is still busy, we give up */ > > if (timeout == MAX_TIMEOUT) { > > Reviewed-by: Jean Delvare Does this still hold given despite the discussion in this thread? signature.asc Description: PGP signature

Re: [PATCH 2/2] i2c: piix4: Use usleep_range()

> > /* If the SMBus is still busy, we give up */ > > if (timeout == MAX_TIMEOUT) { > > Reviewed-by: Jean Delvare Does this still hold given despite the discussion in this thread? signature.asc Description: PGP signature

Re: [PATCH 2/2] i2c: piix4: Use usleep_range()

On 31/12/17 02:50, Guenter Roeck wrote: > The piix4 i2c driver is extremely slow. Replacing msleep() > with usleep_range() increases its speed substantially. > > Signed-off-by: Guenter Roeck > --- > drivers/i2c/busses/i2c-piix4.c | 6 +++--- > 1 file changed, 3

Re: [PATCH 2/2] i2c: piix4: Use usleep_range()

On 31/12/17 02:50, Guenter Roeck wrote: > The piix4 i2c driver is extremely slow. Replacing msleep() > with usleep_range() increases its speed substantially. > > Signed-off-by: Guenter Roeck > --- > drivers/i2c/busses/i2c-piix4.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >

Re: [PATCH 2/2] i2c: piix4: Use usleep_range()

On Mon, 12 Feb 2018 14:22:41 -0800, Guenter Roeck wrote: > On Mon, Feb 12, 2018 at 11:53:36AM +0100, Jean Delvare wrote: > > Were you able to test this on older hardware? Unfortunately, the > > specification errata of the original Intel PIIX4 is quite vague on the > > amount of time you must wait

Re: [PATCH 2/2] i2c: piix4: Use usleep_range()

On Mon, 12 Feb 2018 14:22:41 -0800, Guenter Roeck wrote: > On Mon, Feb 12, 2018 at 11:53:36AM +0100, Jean Delvare wrote: > > Were you able to test this on older hardware? Unfortunately, the > > specification errata of the original Intel PIIX4 is quite vague on the > > amount of time you must wait

Re: [PATCH 2/2] i2c: piix4: Use usleep_range()

Hi Jean, On Mon, Feb 12, 2018 at 11:53:36AM +0100, Jean Delvare wrote: > Hi Guenter, > > On Sat, 30 Dec 2017 08:50:58 -0800, Guenter Roeck wrote: > > The piix4 i2c driver is extremely slow. Replacing msleep() > > with usleep_range() increases its speed substantially. > > > > Signed-off-by:

Re: [PATCH 2/2] i2c: piix4: Use usleep_range()

Hi Jean, On Mon, Feb 12, 2018 at 11:53:36AM +0100, Jean Delvare wrote: > Hi Guenter, > > On Sat, 30 Dec 2017 08:50:58 -0800, Guenter Roeck wrote: > > The piix4 i2c driver is extremely slow. Replacing msleep() > > with usleep_range() increases its speed substantially. > > > > Signed-off-by:

Re: [PATCH 2/2] i2c: piix4: Use usleep_range()

On Mon, 2018-02-12 at 12:59 -0800, Guenter Roeck wrote: > On Mon, Feb 12, 2018 at 11:53:36AM +0100, Jean Delvare wrote: > > On Sat, 30 Dec 2017 08:50:58 -0800, Guenter Roeck wrote: > > > The piix4 i2c driver is extremely slow. Replacing msleep() > > > with usleep_range() increases its speed

Re: [PATCH 2/2] i2c: piix4: Use usleep_range()

On Mon, 2018-02-12 at 12:59 -0800, Guenter Roeck wrote: > On Mon, Feb 12, 2018 at 11:53:36AM +0100, Jean Delvare wrote: > > On Sat, 30 Dec 2017 08:50:58 -0800, Guenter Roeck wrote: > > > The piix4 i2c driver is extremely slow. Replacing msleep() > > > with usleep_range() increases its speed

Re: [PATCH 2/2] i2c: piix4: Use usleep_range()

Hi Jean, On Mon, Feb 12, 2018 at 11:53:36AM +0100, Jean Delvare wrote: > Hi Guenter, > > On Sat, 30 Dec 2017 08:50:58 -0800, Guenter Roeck wrote: > > The piix4 i2c driver is extremely slow. Replacing msleep() > > with usleep_range() increases its speed substantially. > > > > Signed-off-by:

Re: [PATCH 2/2] i2c: piix4: Use usleep_range()

Hi Jean, On Mon, Feb 12, 2018 at 11:53:36AM +0100, Jean Delvare wrote: > Hi Guenter, > > On Sat, 30 Dec 2017 08:50:58 -0800, Guenter Roeck wrote: > > The piix4 i2c driver is extremely slow. Replacing msleep() > > with usleep_range() increases its speed substantially. > > > > Signed-off-by:

Re: [PATCH 2/2] i2c: piix4: Use usleep_range()

Hi Guenter, On Sat, 30 Dec 2017 08:50:58 -0800, Guenter Roeck wrote: > The piix4 i2c driver is extremely slow. Replacing msleep() > with usleep_range() increases its speed substantially. > > Signed-off-by: Guenter Roeck > --- > drivers/i2c/busses/i2c-piix4.c | 6 +++--- > 1

Re: [PATCH 2/2] i2c: piix4: Use usleep_range()

Hi Guenter, On Sat, 30 Dec 2017 08:50:58 -0800, Guenter Roeck wrote: > The piix4 i2c driver is extremely slow. Replacing msleep() > with usleep_range() increases its speed substantially. > > Signed-off-by: Guenter Roeck > --- > drivers/i2c/busses/i2c-piix4.c | 6 +++--- > 1 file changed, 3