Re: [PATCH 2/2] leds: lp50xx: remove unused regulator

2021-02-04 Thread Pavel Machek
On Wed 2021-02-03 10:02:00, Dan Murphy wrote: > Pavel > > On 2/3/21 8:23 AM, Pavel Machek wrote: > > On Wed 2021-02-03 07:49:35, Dan Murphy wrote: > > > Pavel > > > > > > On 2/3/21 3:02 AM, Pavel Machek wrote: > > > > On Wed 2021-02-03 08:34:08, Sven Schuchmann wrote: > > > > > The regulator for

Re: [PATCH 2/2] leds: lp50xx: remove unused regulator

2021-02-03 Thread Dan Murphy
Pavel On 2/3/21 8:23 AM, Pavel Machek wrote: On Wed 2021-02-03 07:49:35, Dan Murphy wrote: Pavel On 2/3/21 3:02 AM, Pavel Machek wrote: On Wed 2021-02-03 08:34:08, Sven Schuchmann wrote: The regulator for vled-supply is unused in the driver. It is just assigned from DT and disabled in

Re: [PATCH 2/2] leds: lp50xx: remove unused regulator

2021-02-03 Thread Pavel Machek
On Wed 2021-02-03 07:49:35, Dan Murphy wrote: > Pavel > > On 2/3/21 3:02 AM, Pavel Machek wrote: > > On Wed 2021-02-03 08:34:08, Sven Schuchmann wrote: > > > The regulator for vled-supply is unused in the driver. > > > It is just assigned from DT and disabled in lp50xx_remove. > > > So the code

Re: [PATCH 2/2] leds: lp50xx: remove unused regulator

2021-02-03 Thread Dan Murphy
Pavel On 2/3/21 3:02 AM, Pavel Machek wrote: On Wed 2021-02-03 08:34:08, Sven Schuchmann wrote: The regulator for vled-supply is unused in the driver. It is just assigned from DT and disabled in lp50xx_remove. So the code can be removed from the driver. Dan, what is going on here? Do we need

Re: [PATCH 2/2] leds: lp50xx: remove unused regulator

2021-02-03 Thread Pavel Machek
On Wed 2021-02-03 08:34:08, Sven Schuchmann wrote: > The regulator for vled-supply is unused in the driver. > It is just assigned from DT and disabled in lp50xx_remove. > So the code can be removed from the driver. Dan, what is going on here? Do we need to also enable the regulator, or is the