Re: [PATCH 2/2] thunderbolt: Initialize after IOMMUs

2018-09-14 Thread Mika Westerberg
On Mon, Sep 03, 2018 at 04:20:12PM +0300, Mika Westerberg wrote: > If IOMMU is enabled and Thunderbolt driver is built into the kernel > image, it will be probed before IOMMUs are attached to the PCI bus. > Because of this DMA mappings the driver does will not go through IOMMU > and start failing

Re: [PATCH 2/2] thunderbolt: Initialize after IOMMUs

2018-09-14 Thread Mika Westerberg
On Mon, Sep 03, 2018 at 04:20:12PM +0300, Mika Westerberg wrote: > If IOMMU is enabled and Thunderbolt driver is built into the kernel > image, it will be probed before IOMMUs are attached to the PCI bus. > Because of this DMA mappings the driver does will not go through IOMMU > and start failing

Re: [PATCH 2/2] thunderbolt: Initialize after IOMMUs

2018-09-06 Thread Mika Westerberg
On Thu, Sep 06, 2018 at 01:21:01PM +0200, Lukas Wunner wrote: > On Thu, Sep 06, 2018 at 02:07:56PM +0300, Mika Westerberg wrote: > > On Thu, Sep 06, 2018 at 01:00:49PM +0200, Lukas Wunner wrote: > > > On Thu, Sep 06, 2018 at 01:36:02PM +0300, Mika Westerberg wrote: > > > > On Thu, Sep 06, 2018 at

Re: [PATCH 2/2] thunderbolt: Initialize after IOMMUs

2018-09-06 Thread Mika Westerberg
On Thu, Sep 06, 2018 at 01:21:01PM +0200, Lukas Wunner wrote: > On Thu, Sep 06, 2018 at 02:07:56PM +0300, Mika Westerberg wrote: > > On Thu, Sep 06, 2018 at 01:00:49PM +0200, Lukas Wunner wrote: > > > On Thu, Sep 06, 2018 at 01:36:02PM +0300, Mika Westerberg wrote: > > > > On Thu, Sep 06, 2018 at

Re: [PATCH 2/2] thunderbolt: Initialize after IOMMUs

2018-09-06 Thread Lukas Wunner
On Thu, Sep 06, 2018 at 02:07:56PM +0300, Mika Westerberg wrote: > On Thu, Sep 06, 2018 at 01:00:49PM +0200, Lukas Wunner wrote: > > On Thu, Sep 06, 2018 at 01:36:02PM +0300, Mika Westerberg wrote: > > > On Thu, Sep 06, 2018 at 10:13:37AM +0200, Lukas Wunner wrote: > > > > So with this patch, you

Re: [PATCH 2/2] thunderbolt: Initialize after IOMMUs

2018-09-06 Thread Lukas Wunner
On Thu, Sep 06, 2018 at 02:07:56PM +0300, Mika Westerberg wrote: > On Thu, Sep 06, 2018 at 01:00:49PM +0200, Lukas Wunner wrote: > > On Thu, Sep 06, 2018 at 01:36:02PM +0300, Mika Westerberg wrote: > > > On Thu, Sep 06, 2018 at 10:13:37AM +0200, Lukas Wunner wrote: > > > > So with this patch, you

Re: [PATCH 2/2] thunderbolt: Initialize after IOMMUs

2018-09-06 Thread Mika Westerberg
On Thu, Sep 06, 2018 at 01:00:49PM +0200, Lukas Wunner wrote: > On Thu, Sep 06, 2018 at 01:36:02PM +0300, Mika Westerberg wrote: > > On Thu, Sep 06, 2018 at 10:13:37AM +0200, Lukas Wunner wrote: > > > So with this patch, you rely on the linker ordering nhi_init() after > > > ir_dev_scope_init(),

Re: [PATCH 2/2] thunderbolt: Initialize after IOMMUs

2018-09-06 Thread Mika Westerberg
On Thu, Sep 06, 2018 at 01:00:49PM +0200, Lukas Wunner wrote: > On Thu, Sep 06, 2018 at 01:36:02PM +0300, Mika Westerberg wrote: > > On Thu, Sep 06, 2018 at 10:13:37AM +0200, Lukas Wunner wrote: > > > So with this patch, you rely on the linker ordering nhi_init() after > > > ir_dev_scope_init(),

Re: [PATCH 2/2] thunderbolt: Initialize after IOMMUs

2018-09-06 Thread Lukas Wunner
On Thu, Sep 06, 2018 at 01:36:02PM +0300, Mika Westerberg wrote: > On Thu, Sep 06, 2018 at 10:13:37AM +0200, Lukas Wunner wrote: > > So with this patch, you rely on the linker ordering nhi_init() after > > ir_dev_scope_init(), however to the best of my knowledge the link > > order is not

Re: [PATCH 2/2] thunderbolt: Initialize after IOMMUs

2018-09-06 Thread Lukas Wunner
On Thu, Sep 06, 2018 at 01:36:02PM +0300, Mika Westerberg wrote: > On Thu, Sep 06, 2018 at 10:13:37AM +0200, Lukas Wunner wrote: > > So with this patch, you rely on the linker ordering nhi_init() after > > ir_dev_scope_init(), however to the best of my knowledge the link > > order is not

Re: [PATCH 2/2] thunderbolt: Initialize after IOMMUs

2018-09-06 Thread Mika Westerberg
On Thu, Sep 06, 2018 at 10:13:37AM +0200, Lukas Wunner wrote: > On Wed, Sep 05, 2018 at 12:46:02PM +0300, Mika Westerberg wrote: > > On Wed, Sep 05, 2018 at 10:47:46AM +0200, Lukas Wunner wrote: > > > On Mon, Sep 03, 2018 at 04:20:12PM +0300, Mika Westerberg wrote: > > > > If IOMMU is enabled and

Re: [PATCH 2/2] thunderbolt: Initialize after IOMMUs

2018-09-06 Thread Mika Westerberg
On Thu, Sep 06, 2018 at 10:13:37AM +0200, Lukas Wunner wrote: > On Wed, Sep 05, 2018 at 12:46:02PM +0300, Mika Westerberg wrote: > > On Wed, Sep 05, 2018 at 10:47:46AM +0200, Lukas Wunner wrote: > > > On Mon, Sep 03, 2018 at 04:20:12PM +0300, Mika Westerberg wrote: > > > > If IOMMU is enabled and

Re: [PATCH 2/2] thunderbolt: Initialize after IOMMUs

2018-09-06 Thread Lukas Wunner
On Wed, Sep 05, 2018 at 12:46:02PM +0300, Mika Westerberg wrote: > On Wed, Sep 05, 2018 at 10:47:46AM +0200, Lukas Wunner wrote: > > On Mon, Sep 03, 2018 at 04:20:12PM +0300, Mika Westerberg wrote: > > > If IOMMU is enabled and Thunderbolt driver is built into the kernel > > > image, it will be

Re: [PATCH 2/2] thunderbolt: Initialize after IOMMUs

2018-09-06 Thread Lukas Wunner
On Wed, Sep 05, 2018 at 12:46:02PM +0300, Mika Westerberg wrote: > On Wed, Sep 05, 2018 at 10:47:46AM +0200, Lukas Wunner wrote: > > On Mon, Sep 03, 2018 at 04:20:12PM +0300, Mika Westerberg wrote: > > > If IOMMU is enabled and Thunderbolt driver is built into the kernel > > > image, it will be

Re: [PATCH 2/2] thunderbolt: Initialize after IOMMUs

2018-09-05 Thread Mika Westerberg
On Wed, Sep 05, 2018 at 10:47:46AM +0200, Lukas Wunner wrote: > On Mon, Sep 03, 2018 at 04:20:12PM +0300, Mika Westerberg wrote: > > If IOMMU is enabled and Thunderbolt driver is built into the kernel > > image, it will be probed before IOMMUs are attached to the PCI bus. > > Because of this DMA

Re: [PATCH 2/2] thunderbolt: Initialize after IOMMUs

2018-09-05 Thread Mika Westerberg
On Wed, Sep 05, 2018 at 10:47:46AM +0200, Lukas Wunner wrote: > On Mon, Sep 03, 2018 at 04:20:12PM +0300, Mika Westerberg wrote: > > If IOMMU is enabled and Thunderbolt driver is built into the kernel > > image, it will be probed before IOMMUs are attached to the PCI bus. > > Because of this DMA

Re: [PATCH 2/2] thunderbolt: Initialize after IOMMUs

2018-09-05 Thread Lukas Wunner
On Mon, Sep 03, 2018 at 04:20:12PM +0300, Mika Westerberg wrote: > If IOMMU is enabled and Thunderbolt driver is built into the kernel > image, it will be probed before IOMMUs are attached to the PCI bus. > Because of this DMA mappings the driver does will not go through IOMMU > and start failing

Re: [PATCH 2/2] thunderbolt: Initialize after IOMMUs

2018-09-05 Thread Lukas Wunner
On Mon, Sep 03, 2018 at 04:20:12PM +0300, Mika Westerberg wrote: > If IOMMU is enabled and Thunderbolt driver is built into the kernel > image, it will be probed before IOMMUs are attached to the PCI bus. > Because of this DMA mappings the driver does will not go through IOMMU > and start failing