Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-22 Thread Rafael J. Wysocki
On Wednesday, May 22, 2013 12:45:34 PM Tang Chen wrote: > Hi Rafael, > > On 05/21/2013 07:15 PM, Rafael J. Wysocki wrote: > .. > >>> + mem->state = to_state; > >>> + if (to_state == MEM_ONLINE) > >>> + mem->last_online = online_type; > >> > >> Why do we need to

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-22 Thread Rafael J. Wysocki
On Wednesday, May 22, 2013 12:45:34 PM Tang Chen wrote: Hi Rafael, On 05/21/2013 07:15 PM, Rafael J. Wysocki wrote: .. + mem-state = to_state; + if (to_state == MEM_ONLINE) + mem-last_online = online_type; Why do we need to remember last online

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-21 Thread Tang Chen
Hi Rafael, On 05/21/2013 07:15 PM, Rafael J. Wysocki wrote: .. + mem->state = to_state; + if (to_state == MEM_ONLINE) + mem->last_online = online_type; Why do we need to remember last online type ? And as far as I know, we can obtain

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-21 Thread Rafael J. Wysocki
On Tuesday, May 21, 2013 02:37:53 PM Tang Chen wrote: > Hi Rafael, > > Please see below. > > On 05/04/2013 07:21 PM, Rafael J. Wysocki wrote: > .. > > static BLOCKING_NOTIFIER_HEAD(memory_chain); > > @@ -278,33 +283,64 @@ static int __memory_block_change_state(s > > { > > int ret =

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-21 Thread Tang Chen
Hi Rafael, Please see below. On 05/04/2013 07:21 PM, Rafael J. Wysocki wrote: .. static BLOCKING_NOTIFIER_HEAD(memory_chain); @@ -278,33 +283,64 @@ static int __memory_block_change_state(s { int ret = 0; - if (mem->state != from_state_req) { - ret =

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-21 Thread Tang Chen
Hi Rafael, Please see below. On 05/04/2013 07:21 PM, Rafael J. Wysocki wrote: .. static BLOCKING_NOTIFIER_HEAD(memory_chain); @@ -278,33 +283,64 @@ static int __memory_block_change_state(s { int ret = 0; - if (mem-state != from_state_req) { - ret = -EINVAL;

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-21 Thread Rafael J. Wysocki
On Tuesday, May 21, 2013 02:37:53 PM Tang Chen wrote: Hi Rafael, Please see below. On 05/04/2013 07:21 PM, Rafael J. Wysocki wrote: .. static BLOCKING_NOTIFIER_HEAD(memory_chain); @@ -278,33 +283,64 @@ static int __memory_block_change_state(s { int ret = 0; - if

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-21 Thread Tang Chen
Hi Rafael, On 05/21/2013 07:15 PM, Rafael J. Wysocki wrote: .. + mem-state = to_state; + if (to_state == MEM_ONLINE) + mem-last_online = online_type; Why do we need to remember last online type ? And as far as I know, we can obtain which

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-08 Thread Toshi Kani
On Wed, 2013-05-08 at 13:53 +0200, Rafael J. Wysocki wrote: > On Tuesday, May 07, 2013 06:37:34 PM Toshi Kani wrote: > > On Wed, 2013-05-08 at 02:24 +0200, Rafael J. Wysocki wrote: > > > On Tuesday, May 07, 2013 05:59:16 PM Toshi Kani wrote: : > > > Moreover, it'd be better to do it in

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-08 Thread Rafael J. Wysocki
On Tuesday, May 07, 2013 06:37:34 PM Toshi Kani wrote: > On Wed, 2013-05-08 at 02:24 +0200, Rafael J. Wysocki wrote: > > On Tuesday, May 07, 2013 05:59:16 PM Toshi Kani wrote: > > > On Wed, 2013-05-08 at 01:17 +0200, Rafael J. Wysocki wrote: > > > > On Tuesday, May 07, 2013 04:45:40 PM Toshi Kani

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-08 Thread Rafael J. Wysocki
On Tuesday, May 07, 2013 06:37:34 PM Toshi Kani wrote: On Wed, 2013-05-08 at 02:24 +0200, Rafael J. Wysocki wrote: On Tuesday, May 07, 2013 05:59:16 PM Toshi Kani wrote: On Wed, 2013-05-08 at 01:17 +0200, Rafael J. Wysocki wrote: On Tuesday, May 07, 2013 04:45:40 PM Toshi Kani wrote:

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-08 Thread Toshi Kani
On Wed, 2013-05-08 at 13:53 +0200, Rafael J. Wysocki wrote: On Tuesday, May 07, 2013 06:37:34 PM Toshi Kani wrote: On Wed, 2013-05-08 at 02:24 +0200, Rafael J. Wysocki wrote: On Tuesday, May 07, 2013 05:59:16 PM Toshi Kani wrote: : Moreover, it'd be better to do it in

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-07 Thread Toshi Kani
On Wed, 2013-05-08 at 02:24 +0200, Rafael J. Wysocki wrote: > On Tuesday, May 07, 2013 05:59:16 PM Toshi Kani wrote: > > On Wed, 2013-05-08 at 01:17 +0200, Rafael J. Wysocki wrote: > > > On Tuesday, May 07, 2013 04:45:40 PM Toshi Kani wrote: > > > > On Wed, 2013-05-08 at 00:10 +0200, Rafael J.

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-07 Thread Rafael J. Wysocki
On Tuesday, May 07, 2013 05:59:16 PM Toshi Kani wrote: > On Wed, 2013-05-08 at 01:17 +0200, Rafael J. Wysocki wrote: > > On Tuesday, May 07, 2013 04:45:40 PM Toshi Kani wrote: > > > On Wed, 2013-05-08 at 00:10 +0200, Rafael J. Wysocki wrote: > > > > On Tuesday, May 07, 2013 03:03:49 PM Toshi Kani

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-07 Thread Toshi Kani
On Wed, 2013-05-08 at 01:17 +0200, Rafael J. Wysocki wrote: > On Tuesday, May 07, 2013 04:45:40 PM Toshi Kani wrote: > > On Wed, 2013-05-08 at 00:10 +0200, Rafael J. Wysocki wrote: > > > On Tuesday, May 07, 2013 03:03:49 PM Toshi Kani wrote: > > > > On Tue, 2013-05-07 at 14:11 +0200, Rafael J.

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-07 Thread Rafael J. Wysocki
On Tuesday, May 07, 2013 04:45:40 PM Toshi Kani wrote: > On Wed, 2013-05-08 at 00:10 +0200, Rafael J. Wysocki wrote: > > On Tuesday, May 07, 2013 03:03:49 PM Toshi Kani wrote: > > > On Tue, 2013-05-07 at 14:11 +0200, Rafael J. Wysocki wrote: > > > > On Tuesday, May 07, 2013 12:59:45 PM Vasilis

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-07 Thread Toshi Kani
On Wed, 2013-05-08 at 00:10 +0200, Rafael J. Wysocki wrote: > On Tuesday, May 07, 2013 03:03:49 PM Toshi Kani wrote: > > On Tue, 2013-05-07 at 14:11 +0200, Rafael J. Wysocki wrote: > > > On Tuesday, May 07, 2013 12:59:45 PM Vasilis Liaskovitis wrote: > > > > : > > > > > Updated patch is

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-07 Thread Rafael J. Wysocki
On Tuesday, May 07, 2013 03:03:49 PM Toshi Kani wrote: > On Tue, 2013-05-07 at 14:11 +0200, Rafael J. Wysocki wrote: > > On Tuesday, May 07, 2013 12:59:45 PM Vasilis Liaskovitis wrote: > > : > > > Updated patch is appended for completness. > > Yes, this updated patch solved the locking issue.

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-07 Thread Toshi Kani
On Tue, 2013-05-07 at 14:11 +0200, Rafael J. Wysocki wrote: > On Tuesday, May 07, 2013 12:59:45 PM Vasilis Liaskovitis wrote: : > Updated patch is appended for completness. Yes, this updated patch solved the locking issue. > > > > A more general issue is that there are now two memory

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-07 Thread Rafael J. Wysocki
On Tuesday, May 07, 2013 12:59:45 PM Vasilis Liaskovitis wrote: > Hi, > > On Tue, May 07, 2013 at 02:59:05AM +0200, Rafael J. Wysocki wrote: > > On Monday, May 06, 2013 06:28:12 PM Vasilis Liaskovitis wrote: > > > On Sat, May 04, 2013 at 01:21:16PM +0200, Rafael J. Wysocki wrote: > > > > From:

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-07 Thread Vasilis Liaskovitis
Hi, On Tue, May 07, 2013 at 02:59:05AM +0200, Rafael J. Wysocki wrote: > On Monday, May 06, 2013 06:28:12 PM Vasilis Liaskovitis wrote: > > On Sat, May 04, 2013 at 01:21:16PM +0200, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > Introduce .offline() and .online() callbacks

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-07 Thread Vasilis Liaskovitis
Hi, On Tue, May 07, 2013 at 02:59:05AM +0200, Rafael J. Wysocki wrote: On Monday, May 06, 2013 06:28:12 PM Vasilis Liaskovitis wrote: On Sat, May 04, 2013 at 01:21:16PM +0200, Rafael J. Wysocki wrote: From: Rafael J. Wysocki rafael.j.wyso...@intel.com Introduce .offline() and

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-07 Thread Rafael J. Wysocki
On Tuesday, May 07, 2013 12:59:45 PM Vasilis Liaskovitis wrote: Hi, On Tue, May 07, 2013 at 02:59:05AM +0200, Rafael J. Wysocki wrote: On Monday, May 06, 2013 06:28:12 PM Vasilis Liaskovitis wrote: On Sat, May 04, 2013 at 01:21:16PM +0200, Rafael J. Wysocki wrote: From: Rafael J.

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-07 Thread Toshi Kani
On Tue, 2013-05-07 at 14:11 +0200, Rafael J. Wysocki wrote: On Tuesday, May 07, 2013 12:59:45 PM Vasilis Liaskovitis wrote: : Updated patch is appended for completness. Yes, this updated patch solved the locking issue. A more general issue is that there are now two memory offlining

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-07 Thread Rafael J. Wysocki
On Tuesday, May 07, 2013 03:03:49 PM Toshi Kani wrote: On Tue, 2013-05-07 at 14:11 +0200, Rafael J. Wysocki wrote: On Tuesday, May 07, 2013 12:59:45 PM Vasilis Liaskovitis wrote: : Updated patch is appended for completness. Yes, this updated patch solved the locking issue. A

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-07 Thread Toshi Kani
On Wed, 2013-05-08 at 00:10 +0200, Rafael J. Wysocki wrote: On Tuesday, May 07, 2013 03:03:49 PM Toshi Kani wrote: On Tue, 2013-05-07 at 14:11 +0200, Rafael J. Wysocki wrote: On Tuesday, May 07, 2013 12:59:45 PM Vasilis Liaskovitis wrote: : Updated patch is appended for

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-07 Thread Rafael J. Wysocki
On Tuesday, May 07, 2013 04:45:40 PM Toshi Kani wrote: On Wed, 2013-05-08 at 00:10 +0200, Rafael J. Wysocki wrote: On Tuesday, May 07, 2013 03:03:49 PM Toshi Kani wrote: On Tue, 2013-05-07 at 14:11 +0200, Rafael J. Wysocki wrote: On Tuesday, May 07, 2013 12:59:45 PM Vasilis Liaskovitis

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-07 Thread Toshi Kani
On Wed, 2013-05-08 at 01:17 +0200, Rafael J. Wysocki wrote: On Tuesday, May 07, 2013 04:45:40 PM Toshi Kani wrote: On Wed, 2013-05-08 at 00:10 +0200, Rafael J. Wysocki wrote: On Tuesday, May 07, 2013 03:03:49 PM Toshi Kani wrote: On Tue, 2013-05-07 at 14:11 +0200, Rafael J. Wysocki

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-07 Thread Rafael J. Wysocki
On Tuesday, May 07, 2013 05:59:16 PM Toshi Kani wrote: On Wed, 2013-05-08 at 01:17 +0200, Rafael J. Wysocki wrote: On Tuesday, May 07, 2013 04:45:40 PM Toshi Kani wrote: On Wed, 2013-05-08 at 00:10 +0200, Rafael J. Wysocki wrote: On Tuesday, May 07, 2013 03:03:49 PM Toshi Kani wrote:

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-06 Thread Rafael J. Wysocki
On Monday, May 06, 2013 06:28:12 PM Vasilis Liaskovitis wrote: > Hi, > > On Sat, May 04, 2013 at 01:21:16PM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Introduce .offline() and .online() callbacks for memory_subsys > > that will allow the generic device_offline() and

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-06 Thread Rafael J. Wysocki
On Monday, May 06, 2013 10:20:44 AM Greg Kroah-Hartman wrote: > On Sat, May 04, 2013 at 01:21:16PM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Introduce .offline() and .online() callbacks for memory_subsys > > that will allow the generic device_offline() and

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-06 Thread Greg Kroah-Hartman
On Sat, May 04, 2013 at 01:21:16PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Introduce .offline() and .online() callbacks for memory_subsys > that will allow the generic device_offline() and device_online() > to be used with device objects representing memory blocks. That, >

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-06 Thread Vasilis Liaskovitis
Hi, On Sat, May 04, 2013 at 01:21:16PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Introduce .offline() and .online() callbacks for memory_subsys > that will allow the generic device_offline() and device_online() > to be used with device objects representing memory blocks.

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-06 Thread Vasilis Liaskovitis
Hi, On Sat, May 04, 2013 at 01:21:16PM +0200, Rafael J. Wysocki wrote: From: Rafael J. Wysocki rafael.j.wyso...@intel.com Introduce .offline() and .online() callbacks for memory_subsys that will allow the generic device_offline() and device_online() to be used with device objects

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-06 Thread Greg Kroah-Hartman
On Sat, May 04, 2013 at 01:21:16PM +0200, Rafael J. Wysocki wrote: From: Rafael J. Wysocki rafael.j.wyso...@intel.com Introduce .offline() and .online() callbacks for memory_subsys that will allow the generic device_offline() and device_online() to be used with device objects representing

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-06 Thread Rafael J. Wysocki
On Monday, May 06, 2013 10:20:44 AM Greg Kroah-Hartman wrote: On Sat, May 04, 2013 at 01:21:16PM +0200, Rafael J. Wysocki wrote: From: Rafael J. Wysocki rafael.j.wyso...@intel.com Introduce .offline() and .online() callbacks for memory_subsys that will allow the generic device_offline()

Re: [PATCH 2/2 v2, RFC] Driver core: Introduce offline/online callbacks for memory blocks

2013-05-06 Thread Rafael J. Wysocki
On Monday, May 06, 2013 06:28:12 PM Vasilis Liaskovitis wrote: Hi, On Sat, May 04, 2013 at 01:21:16PM +0200, Rafael J. Wysocki wrote: From: Rafael J. Wysocki rafael.j.wyso...@intel.com Introduce .offline() and .online() callbacks for memory_subsys that will allow the generic