Re: [PATCH 2/3] mm,thp,shm: limit gfp mask to no more than specified

2020-11-30 Thread Rik van Riel
On Mon, 2020-11-30 at 11:00 +0100, Michal Hocko wrote: > On Fri 27-11-20 14:03:39, Rik van Riel wrote: > > On Fri, 2020-11-27 at 08:52 +0100, Michal Hocko wrote: > > > On Thu 26-11-20 13:04:14, Rik van Riel wrote: > > > > I would be more than happy to implement things differently, > > > > but I am

Re: [PATCH 2/3] mm,thp,shm: limit gfp mask to no more than specified

2020-11-30 Thread Michal Hocko
On Fri 27-11-20 14:03:39, Rik van Riel wrote: > On Fri, 2020-11-27 at 08:52 +0100, Michal Hocko wrote: > > On Thu 26-11-20 13:04:14, Rik van Riel wrote: > > > > > > I would be more than happy to implement things differently, > > > but I am not sure what alternative you are suggesting. > > > >

Re: [PATCH 2/3] mm,thp,shm: limit gfp mask to no more than specified

2020-11-27 Thread Rik van Riel
On Fri, 2020-11-27 at 08:52 +0100, Michal Hocko wrote: > On Thu 26-11-20 13:04:14, Rik van Riel wrote: > > > > I would be more than happy to implement things differently, > > but I am not sure what alternative you are suggesting. > > Simply do not alter gfp flags? Or warn in some cases of a

Re: [PATCH 2/3] mm,thp,shm: limit gfp mask to no more than specified

2020-11-26 Thread Michal Hocko
On Thu 26-11-20 13:04:14, Rik van Riel wrote: > On Thu, 2020-11-26 at 14:40 +0100, Michal Hocko wrote: > > On Tue 24-11-20 14:49:24, Rik van Riel wrote: > > > Matthew Wilcox pointed out that the i915 driver opportunistically > > > allocates tmpfs memory, but will happily reclaim some of its > > >

Re: [PATCH 2/3] mm,thp,shm: limit gfp mask to no more than specified

2020-11-26 Thread Rik van Riel
On Thu, 2020-11-26 at 14:40 +0100, Michal Hocko wrote: > On Tue 24-11-20 14:49:24, Rik van Riel wrote: > > Matthew Wilcox pointed out that the i915 driver opportunistically > > allocates tmpfs memory, but will happily reclaim some of its > > pool if no memory is available. > > > > Make sure the

Re: [PATCH 2/3] mm,thp,shm: limit gfp mask to no more than specified

2020-11-26 Thread Michal Hocko
On Tue 24-11-20 14:49:24, Rik van Riel wrote: > Matthew Wilcox pointed out that the i915 driver opportunistically > allocates tmpfs memory, but will happily reclaim some of its > pool if no memory is available. > > Make sure the gfp mask used to opportunistically allocate a THP > is always at