Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-12 Thread Ingo Molnar
* Felipe Contreras wrote: > On Mon, Nov 11, 2013 at 9:32 AM, Theodore Ts'o wrote: > > On Mon, Nov 11, 2013 at 02:52:16PM +0100, Ingo Molnar wrote: > >> > That's exactly what I did. Addressing feedback constructively doesn't > >> > mean do exactly what you say without arguing. > >> > >> Your

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-12 Thread Ingo Molnar
* Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Nov 11, 2013 at 9:32 AM, Theodore Ts'o ty...@mit.edu wrote: On Mon, Nov 11, 2013 at 02:52:16PM +0100, Ingo Molnar wrote: That's exactly what I did. Addressing feedback constructively doesn't mean do exactly what you say

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Felipe Contreras
On Mon, Nov 11, 2013 at 9:32 AM, Theodore Ts'o wrote: > On Mon, Nov 11, 2013 at 02:52:16PM +0100, Ingo Molnar wrote: >> > That's exactly what I did. Addressing feedback constructively doesn't >> > mean do exactly what you say without arguing. >> >> Your reply to my routine feedback was obtuse,

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Theodore Ts'o
On Mon, Nov 11, 2013 at 02:52:16PM +0100, Ingo Molnar wrote: > > That's exactly what I did. Addressing feedback constructively doesn't > > mean do exactly what you say without arguing. > > Your reply to my routine feedback was obtuse, argumentative and needlessly > confrontative - that's not

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Ingo Molnar
* Felipe Contreras wrote: > On Mon, Nov 11, 2013 at 7:28 AM, Ingo Molnar wrote: > > > > * Felipe Contreras wrote: > > > >> On Mon, Nov 11, 2013 at 6:49 AM, Ingo Molnar wrote: > >> > > >> > * Felipe Contreras wrote: > >> > > >> >> On Mon, Nov 11, 2013 at 5:32 AM, Ingo Molnar wrote: > >> >>

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Felipe Contreras
On Mon, Nov 11, 2013 at 7:28 AM, Ingo Molnar wrote: > > * Felipe Contreras wrote: > >> On Mon, Nov 11, 2013 at 6:49 AM, Ingo Molnar wrote: >> > >> > * Felipe Contreras wrote: >> > >> >> On Mon, Nov 11, 2013 at 5:32 AM, Ingo Molnar wrote: >> >> > >> >> > * Felipe Contreras wrote: >> >> > >>

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Ingo Molnar
* Felipe Contreras wrote: > On Mon, Nov 11, 2013 at 6:49 AM, Ingo Molnar wrote: > > > > * Felipe Contreras wrote: > > > >> On Mon, Nov 11, 2013 at 5:32 AM, Ingo Molnar wrote: > >> > > >> > * Felipe Contreras wrote: > >> > > >> >> We want to calculate the blinks per second, and instead of

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Felipe Contreras
On Mon, Nov 11, 2013 at 6:49 AM, Ingo Molnar wrote: > > * Felipe Contreras wrote: > >> On Mon, Nov 11, 2013 at 5:32 AM, Ingo Molnar wrote: >> > >> > * Felipe Contreras wrote: >> > >> >> We want to calculate the blinks per second, and instead of making it 5 >> >> (1000 / (3600 / 18)), let's

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Ingo Molnar
* Felipe Contreras wrote: > On Mon, Nov 11, 2013 at 5:32 AM, Ingo Molnar wrote: > > > > * Felipe Contreras wrote: > > > >> We want to calculate the blinks per second, and instead of making it 5 > >> (1000 / (3600 / 18)), let's make it 4, so the user can see two blinks > >> per second. > > > >

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Felipe Contreras
On Mon, Nov 11, 2013 at 5:32 AM, Ingo Molnar wrote: > > * Felipe Contreras wrote: > >> We want to calculate the blinks per second, and instead of making it 5 >> (1000 / (3600 / 18)), let's make it 4, so the user can see two blinks >> per second. > > Please use the customary changelog style we

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Ingo Molnar
* Felipe Contreras wrote: > We want to calculate the blinks per second, and instead of making it 5 > (1000 / (3600 / 18)), let's make it 4, so the user can see two blinks > per second. Please use the customary changelog style we use in the kernel: " Current code does (A), this has a

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Ingo Molnar
* Felipe Contreras felipe.contre...@gmail.com wrote: We want to calculate the blinks per second, and instead of making it 5 (1000 / (3600 / 18)), let's make it 4, so the user can see two blinks per second. Please use the customary changelog style we use in the kernel: Current code does

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Felipe Contreras
On Mon, Nov 11, 2013 at 5:32 AM, Ingo Molnar mi...@kernel.org wrote: * Felipe Contreras felipe.contre...@gmail.com wrote: We want to calculate the blinks per second, and instead of making it 5 (1000 / (3600 / 18)), let's make it 4, so the user can see two blinks per second. Please use the

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Ingo Molnar
* Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Nov 11, 2013 at 5:32 AM, Ingo Molnar mi...@kernel.org wrote: * Felipe Contreras felipe.contre...@gmail.com wrote: We want to calculate the blinks per second, and instead of making it 5 (1000 / (3600 / 18)), let's make it 4,

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Felipe Contreras
On Mon, Nov 11, 2013 at 6:49 AM, Ingo Molnar mi...@kernel.org wrote: * Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Nov 11, 2013 at 5:32 AM, Ingo Molnar mi...@kernel.org wrote: * Felipe Contreras felipe.contre...@gmail.com wrote: We want to calculate the blinks per

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Ingo Molnar
* Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Nov 11, 2013 at 6:49 AM, Ingo Molnar mi...@kernel.org wrote: * Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Nov 11, 2013 at 5:32 AM, Ingo Molnar mi...@kernel.org wrote: * Felipe Contreras

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Felipe Contreras
On Mon, Nov 11, 2013 at 7:28 AM, Ingo Molnar mi...@kernel.org wrote: * Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Nov 11, 2013 at 6:49 AM, Ingo Molnar mi...@kernel.org wrote: * Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Nov 11, 2013 at 5:32 AM, Ingo

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Ingo Molnar
* Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Nov 11, 2013 at 7:28 AM, Ingo Molnar mi...@kernel.org wrote: * Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Nov 11, 2013 at 6:49 AM, Ingo Molnar mi...@kernel.org wrote: * Felipe Contreras

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Theodore Ts'o
On Mon, Nov 11, 2013 at 02:52:16PM +0100, Ingo Molnar wrote: That's exactly what I did. Addressing feedback constructively doesn't mean do exactly what you say without arguing. Your reply to my routine feedback was obtuse, argumentative and needlessly confrontative - that's not

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Felipe Contreras
On Mon, Nov 11, 2013 at 9:32 AM, Theodore Ts'o ty...@mit.edu wrote: On Mon, Nov 11, 2013 at 02:52:16PM +0100, Ingo Molnar wrote: That's exactly what I did. Addressing feedback constructively doesn't mean do exactly what you say without arguing. Your reply to my routine feedback was obtuse,