Re: [PATCH 2/3] sched/fair: Introduce scaled capacity awareness in select_idle_sibling code path

Hi Atish, Thanks for the comments On 10/10/2017 08:54 AM, Atish Patra wrote: Signed-off-by: Rohit Jain ---   kernel/sched/fair.c | 37 -   1 file changed, 28 insertions(+), 9 deletions(-) diff --git a/kernel/sched/fair.c

Re: [PATCH 2/3] sched/fair: Introduce scaled capacity awareness in select_idle_sibling code path

Hi Atish, Thanks for the comments On 10/10/2017 08:54 AM, Atish Patra wrote: Signed-off-by: Rohit Jain ---   kernel/sched/fair.c | 37 -   1 file changed, 28 insertions(+), 9 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index

Re: [PATCH 2/3] sched/fair: Introduce scaled capacity awareness in select_idle_sibling code path

Minor nit: version number missing On 10/07/2017 06:48 PM, Rohit Jain wrote: While looking for CPUs to place running tasks on, the scheduler completely ignores the capacity stolen away by RT/IRQ tasks. This patch changes that behavior to also take the scaled capacity into account.

Re: [PATCH 2/3] sched/fair: Introduce scaled capacity awareness in select_idle_sibling code path

Minor nit: version number missing On 10/07/2017 06:48 PM, Rohit Jain wrote: While looking for CPUs to place running tasks on, the scheduler completely ignores the capacity stolen away by RT/IRQ tasks. This patch changes that behavior to also take the scaled capacity into account.

Re: [PATCH 2/3] sched/fair: Introduce scaled capacity awareness in select_idle_sibling code path

Hi Joel, On 10/02/2017 09:52 PM, Joel Fernandes wrote: Hi Rohit, On Thu, Sep 28, 2017 at 8:09 AM, Rohit Jain wrote: [..] With this case, because we know from the past avg, one of the strands is running low on capacity, I am trying to return a better strand for the

Re: [PATCH 2/3] sched/fair: Introduce scaled capacity awareness in select_idle_sibling code path

Hi Joel, On 10/02/2017 09:52 PM, Joel Fernandes wrote: Hi Rohit, On Thu, Sep 28, 2017 at 8:09 AM, Rohit Jain wrote: [..] With this case, because we know from the past avg, one of the strands is running low on capacity, I am trying to return a better strand for the thread to start on. I

Re: [PATCH 2/3] sched/fair: Introduce scaled capacity awareness in select_idle_sibling code path

Hi Rohit, On Thu, Sep 28, 2017 at 8:09 AM, Rohit Jain wrote: [..] >>> >>> With this case, because we know from the past avg, one of the strands is >>> running low on capacity, I am trying to return a better strand for the >>> thread to start on. >>> >> I know what you're

Re: [PATCH 2/3] sched/fair: Introduce scaled capacity awareness in select_idle_sibling code path

Hi Rohit, On Thu, Sep 28, 2017 at 8:09 AM, Rohit Jain wrote: [..] >>> >>> With this case, because we know from the past avg, one of the strands is >>> running low on capacity, I am trying to return a better strand for the >>> thread to start on. >>> >> I know what you're trying to do but they

Re: [PATCH 2/3] sched/fair: Introduce scaled capacity awareness in select_idle_sibling code path

Hi Joel, On 09/28/2017 05:53 AM, joelaf wrote: Hi Rohit, On Tue, Sep 26, 2017 at 12:48 PM, Rohit Jain wrote: [...] } - if (idle) - return core; + if (idle) { + if (rcpu ==

Re: [PATCH 2/3] sched/fair: Introduce scaled capacity awareness in select_idle_sibling code path

Hi Joel, On 09/28/2017 05:53 AM, joelaf wrote: Hi Rohit, On Tue, Sep 26, 2017 at 12:48 PM, Rohit Jain wrote: [...] } - if (idle) - return core; + if (idle) { + if (rcpu == -1) +

Re: [PATCH 2/3] sched/fair: Introduce scaled capacity awareness in select_idle_sibling code path

Hi Rohit, On Tue, Sep 26, 2017 at 12:48 PM, Rohit Jain wrote: [...] >>> + unsigned int backup_cap = 0; >>> + >>> + rcpu = rcpu_backup = -1; >>> >>> if (!static_branch_likely(_smt_present)) >>> return -1; >>> @@ -6057,10 +6060,20 @@

Re: [PATCH 2/3] sched/fair: Introduce scaled capacity awareness in select_idle_sibling code path

Hi Rohit, On Tue, Sep 26, 2017 at 12:48 PM, Rohit Jain wrote: [...] >>> + unsigned int backup_cap = 0; >>> + >>> + rcpu = rcpu_backup = -1; >>> >>> if (!static_branch_likely(_smt_present)) >>> return -1; >>> @@ -6057,10 +6060,20 @@ static int

Re: [PATCH 2/3] sched/fair: Introduce scaled capacity awareness in select_idle_sibling code path

On 09/25/2017 11:53 PM, Joel Fernandes wrote: Hi Rohit, Just some comments: Hi Joel, Thanks for the comments. On Mon, Sep 25, 2017 at 5:02 PM, Rohit Jain wrote: While looking for CPUs to place running tasks on, the scheduler completely ignores the capacity stolen

Re: [PATCH 2/3] sched/fair: Introduce scaled capacity awareness in select_idle_sibling code path

On 09/25/2017 11:53 PM, Joel Fernandes wrote: Hi Rohit, Just some comments: Hi Joel, Thanks for the comments. On Mon, Sep 25, 2017 at 5:02 PM, Rohit Jain wrote: While looking for CPUs to place running tasks on, the scheduler completely ignores the capacity stolen away by RT/IRQ tasks.

Re: [PATCH 2/3] sched/fair: Introduce scaled capacity awareness in select_idle_sibling code path

Hi Rohit, Just some comments: On Mon, Sep 25, 2017 at 5:02 PM, Rohit Jain wrote: > While looking for CPUs to place running tasks on, the scheduler > completely ignores the capacity stolen away by RT/IRQ tasks. > > This patch fixes that. > > Signed-off-by: Rohit Jain

Re: [PATCH 2/3] sched/fair: Introduce scaled capacity awareness in select_idle_sibling code path

Hi Rohit, Just some comments: On Mon, Sep 25, 2017 at 5:02 PM, Rohit Jain wrote: > While looking for CPUs to place running tasks on, the scheduler > completely ignores the capacity stolen away by RT/IRQ tasks. > > This patch fixes that. > > Signed-off-by: Rohit Jain > --- >