Re: [PATCH 2/3] usb: dwc2: host: Giveback URB in tasklet context

2015-11-07 Thread Alan Stern
On Fri, 6 Nov 2015, Doug Anderson wrote: > You're talking to someone who has only been looking at the details of > USB for about 2 days now. :-P ...I'm trying to grok all of that, but > I'm not sure I got it all... > > I will say that "URB_ISO_ASAP" is not referenced anywhere in dwc2. >

Re: [PATCH 2/3] usb: dwc2: host: Giveback URB in tasklet context

2015-11-07 Thread Alan Stern
On Fri, 6 Nov 2015, Doug Anderson wrote: > You're talking to someone who has only been looking at the details of > USB for about 2 days now. :-P ...I'm trying to grok all of that, but > I'm not sure I got it all... > > I will say that "URB_ISO_ASAP" is not referenced anywhere in dwc2. >

Re: [PATCH 2/3] usb: dwc2: host: Giveback URB in tasklet context

2015-11-06 Thread Doug Anderson
Alan, On Fri, Nov 6, 2015 at 7:40 AM, Alan Stern wrote: > On Thu, 5 Nov 2015, Doug Anderson wrote: > >> Alan, >> >> On Thu, Nov 5, 2015 at 7:19 AM, Alan Stern wrote: >> > On Wed, 4 Nov 2015, Doug Anderson wrote: >> > >> >> In the ChromeOS gerrit >> >>

Re: [PATCH 2/3] usb: dwc2: host: Giveback URB in tasklet context

2015-11-06 Thread Alan Stern
On Thu, 5 Nov 2015, Doug Anderson wrote: > Alan, > > On Thu, Nov 5, 2015 at 7:19 AM, Alan Stern wrote: > > On Wed, 4 Nov 2015, Doug Anderson wrote: > > > >> In the ChromeOS gerrit > >> Julius Werner > >> points out that for EHCI it was good

Re: [PATCH 2/3] usb: dwc2: host: Giveback URB in tasklet context

2015-11-06 Thread Doug Anderson
Alan, On Fri, Nov 6, 2015 at 7:40 AM, Alan Stern wrote: > On Thu, 5 Nov 2015, Doug Anderson wrote: > >> Alan, >> >> On Thu, Nov 5, 2015 at 7:19 AM, Alan Stern wrote: >> > On Wed, 4 Nov 2015, Doug Anderson wrote: >> > >> >> In the ChromeOS

Re: [PATCH 2/3] usb: dwc2: host: Giveback URB in tasklet context

2015-11-06 Thread Alan Stern
On Thu, 5 Nov 2015, Doug Anderson wrote: > Alan, > > On Thu, Nov 5, 2015 at 7:19 AM, Alan Stern wrote: > > On Wed, 4 Nov 2015, Doug Anderson wrote: > > > >> In the ChromeOS gerrit > >> Julius Werner > >> points

Re: [PATCH 2/3] usb: dwc2: host: Giveback URB in tasklet context

2015-11-05 Thread Doug Anderson
Alan, On Thu, Nov 5, 2015 at 7:19 AM, Alan Stern wrote: > On Wed, 4 Nov 2015, Doug Anderson wrote: > >> In the ChromeOS gerrit >> Julius Werner >> points out that for EHCI it was good to take the optimization from >> commit 9118f9eb4f1e

Re: [PATCH 2/3] usb: dwc2: host: Giveback URB in tasklet context

2015-11-05 Thread Alan Stern
On Wed, 4 Nov 2015, Doug Anderson wrote: > In the ChromeOS gerrit > Julius Werner > points out that for EHCI it was good to take the optimization from > commit 9118f9eb4f1e ("USB: EHCI: improve interrupt qh unlink") before > this one. I'm

Re: [PATCH 2/3] usb: dwc2: host: Giveback URB in tasklet context

2015-11-05 Thread Doug Anderson
Alan, On Thu, Nov 5, 2015 at 7:19 AM, Alan Stern wrote: > On Wed, 4 Nov 2015, Doug Anderson wrote: > >> In the ChromeOS gerrit >> Julius Werner >> points out that for EHCI it was good to take the optimization from

Re: [PATCH 2/3] usb: dwc2: host: Giveback URB in tasklet context

2015-11-05 Thread Alan Stern
On Wed, 4 Nov 2015, Doug Anderson wrote: > In the ChromeOS gerrit > Julius Werner > points out that for EHCI it was good to take the optimization from > commit 9118f9eb4f1e ("USB: EHCI: improve interrupt qh unlink") before > this one. I'm

Re: [PATCH 2/3] usb: dwc2: host: Giveback URB in tasklet context

2015-11-04 Thread Doug Anderson
Hi, On Wed, Nov 4, 2015 at 2:53 PM, Douglas Anderson wrote: > In commit 94dfd7edfd5c ("USB: HCD: support giveback of URB in tasklet > context") support was added to give back the URB in tasklet context. > Let's take advantage of this in dwc2. > > This speeds up the dwc2 interrupt handler

Re: [PATCH 2/3] usb: dwc2: host: Giveback URB in tasklet context

2015-11-04 Thread Doug Anderson
Hi, On Wed, Nov 4, 2015 at 2:53 PM, Douglas Anderson wrote: > In commit 94dfd7edfd5c ("USB: HCD: support giveback of URB in tasklet > context") support was added to give back the URB in tasklet context. > Let's take advantage of this in dwc2. > > This speeds up the dwc2