Re: [PATCH 2/4] mm: introduce new VM_NOZEROPAGE flag

2014-10-21 Thread Dominik Dingel
On Tue, 21 Oct 2014 10:11:43 +0200 Paolo Bonzini wrote: > > > On 10/21/2014 08:11 AM, Martin Schwidefsky wrote: > >> I agree with Dave (I thought I disagreed, but I changed my mind while > >> writing down my thoughts). Just define mm_forbids_zeropage in > >> arch/s390/include/asm, and make it

Re: [PATCH 2/4] mm: introduce new VM_NOZEROPAGE flag

2014-10-21 Thread Paolo Bonzini
On 10/21/2014 08:11 AM, Martin Schwidefsky wrote: I agree with Dave (I thought I disagreed, but I changed my mind while writing down my thoughts). Just define mm_forbids_zeropage in arch/s390/include/asm, and make it return mm->context.use_skey---with a comment explaining how this is only for

Re: [PATCH 2/4] mm: introduce new VM_NOZEROPAGE flag

2014-10-21 Thread Martin Schwidefsky
On Mon, 20 Oct 2014 20:14:53 +0200 Paolo Bonzini wrote: > On 10/18/2014 06:28 PM, Dave Hansen wrote: > > > Currently it is an all or nothing thing, but for a future change we might > > > want to just > > > tag the guest memory instead of the complete user address space. > > > > I think it's a

Re: [PATCH 2/4] mm: introduce new VM_NOZEROPAGE flag

2014-10-21 Thread Martin Schwidefsky
On Mon, 20 Oct 2014 20:14:53 +0200 Paolo Bonzini pbonz...@redhat.com wrote: On 10/18/2014 06:28 PM, Dave Hansen wrote: Currently it is an all or nothing thing, but for a future change we might want to just tag the guest memory instead of the complete user address space. I think

Re: [PATCH 2/4] mm: introduce new VM_NOZEROPAGE flag

2014-10-21 Thread Paolo Bonzini
On 10/21/2014 08:11 AM, Martin Schwidefsky wrote: I agree with Dave (I thought I disagreed, but I changed my mind while writing down my thoughts). Just define mm_forbids_zeropage in arch/s390/include/asm, and make it return mm-context.use_skey---with a comment explaining how this is only for

Re: [PATCH 2/4] mm: introduce new VM_NOZEROPAGE flag

2014-10-21 Thread Dominik Dingel
On Tue, 21 Oct 2014 10:11:43 +0200 Paolo Bonzini pbonz...@redhat.com wrote: On 10/21/2014 08:11 AM, Martin Schwidefsky wrote: I agree with Dave (I thought I disagreed, but I changed my mind while writing down my thoughts). Just define mm_forbids_zeropage in arch/s390/include/asm, and

Re: [PATCH 2/4] mm: introduce new VM_NOZEROPAGE flag

2014-10-20 Thread Paolo Bonzini
On 10/18/2014 06:28 PM, Dave Hansen wrote: > Currently it is an all or nothing thing, but for a future change we might want to just > tag the guest memory instead of the complete user address space. I think it's a bad idea to reserve a flag for potential future use. If you_need_ it in the

Re: [PATCH 2/4] mm: introduce new VM_NOZEROPAGE flag

2014-10-20 Thread Paolo Bonzini
On 10/18/2014 06:28 PM, Dave Hansen wrote: Currently it is an all or nothing thing, but for a future change we might want to just tag the guest memory instead of the complete user address space. I think it's a bad idea to reserve a flag for potential future use. If you_need_ it in the

Re: [PATCH 2/4] mm: introduce new VM_NOZEROPAGE flag

2014-10-18 Thread Dave Hansen
On 10/18/2014 07:49 AM, Dominik Dingel wrote: > On Fri, 17 Oct 2014 15:04:21 -0700 > Dave Hansen wrote: >> Is there ever a time where the VMAs under an mm have mixed VM_NOZEROPAGE >> status? Reading the patches, it _looks_ like it might be an all or >> nothing thing. > > Currently it is an all

Re: [PATCH 2/4] mm: introduce new VM_NOZEROPAGE flag

2014-10-18 Thread Dominik Dingel
On Fri, 17 Oct 2014 15:04:21 -0700 Dave Hansen wrote: > Is there ever a time where the VMAs under an mm have mixed VM_NOZEROPAGE > status? Reading the patches, it _looks_ like it might be an all or > nothing thing. Currently it is an all or nothing thing, but for a future change we might want

Re: [PATCH 2/4] mm: introduce new VM_NOZEROPAGE flag

2014-10-18 Thread Dominik Dingel
On Fri, 17 Oct 2014 15:04:21 -0700 Dave Hansen dave.han...@intel.com wrote: Is there ever a time where the VMAs under an mm have mixed VM_NOZEROPAGE status? Reading the patches, it _looks_ like it might be an all or nothing thing. Currently it is an all or nothing thing, but for a future

Re: [PATCH 2/4] mm: introduce new VM_NOZEROPAGE flag

2014-10-18 Thread Dave Hansen
On 10/18/2014 07:49 AM, Dominik Dingel wrote: On Fri, 17 Oct 2014 15:04:21 -0700 Dave Hansen dave.han...@intel.com wrote: Is there ever a time where the VMAs under an mm have mixed VM_NOZEROPAGE status? Reading the patches, it _looks_ like it might be an all or nothing thing. Currently it

Re: [PATCH 2/4] mm: introduce new VM_NOZEROPAGE flag

2014-10-17 Thread Dave Hansen
On 10/17/2014 07:09 AM, Dominik Dingel wrote: > diff --git a/include/linux/mm.h b/include/linux/mm.h > index cd33ae2..8f09c91 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -113,7 +113,7 @@ extern unsigned int kobjsize(const void *objp); > #define VM_GROWSDOWN 0x0100

Re: [PATCH 2/4] mm: introduce new VM_NOZEROPAGE flag

2014-10-17 Thread Dave Hansen
On 10/17/2014 07:09 AM, Dominik Dingel wrote: diff --git a/include/linux/mm.h b/include/linux/mm.h index cd33ae2..8f09c91 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -113,7 +113,7 @@ extern unsigned int kobjsize(const void *objp); #define VM_GROWSDOWN 0x0100 /*