Re: [PATCH 2/4] modules: Ensure 64-bit alignment on __ksymtab_* sections

2024-01-22 Thread Luis Chamberlain
On Mon, Jan 22, 2024 at 05:47:49PM +0100, Helge Deller wrote: > On 1/22/24 17:10, Luis Chamberlain wrote: > > > > It's within the noise for x86_64, but given what you suggest > > for parisc where it is much more expensive, we should see a non-noise > > delta. Even just time on loading the module

Re: [PATCH 2/4] modules: Ensure 64-bit alignment on __ksymtab_* sections

2024-01-22 Thread Helge Deller
On 1/22/24 17:10, Luis Chamberlain wrote: On Sat, Dec 30, 2023 at 08:33:24AM +0100, Helge Deller wrote: Your selftest code is based on perf. AFAICS we don't have perf on parisc/hppa, I see! so I can't test your selftest code on that architecture. I assume you tested on x86, where the CPU

Re: [PATCH 2/4] modules: Ensure 64-bit alignment on __ksymtab_* sections

2024-01-22 Thread Luis Chamberlain
On Sat, Dec 30, 2023 at 08:33:24AM +0100, Helge Deller wrote: > Your selftest code is based on perf. > AFAICS we don't have perf on parisc/hppa, I see! > so I can't test your selftest code > on that architecture. > I assume you tested on x86, where the CPU will transparently take care of >

Re: [PATCH 2/4] modules: Ensure 64-bit alignment on __ksymtab_* sections

2023-12-29 Thread Helge Deller
Hi Luis, On 12/22/23 21:10, Luis Chamberlain wrote: On Fri, Dec 22, 2023 at 01:13:26PM +0100, Helge Deller wrote: On 12/22/23 06:59, Luis Chamberlain wrote: On Wed, Nov 22, 2023 at 11:18:12PM +0100, del...@kernel.org wrote: On 64-bit architectures without CONFIG_HAVE_ARCH_PREL32_RELOCATIONS

Re: [PATCH 2/4] modules: Ensure 64-bit alignment on __ksymtab_* sections

2023-12-22 Thread Luis Chamberlain
On Fri, Dec 22, 2023 at 01:13:26PM +0100, Helge Deller wrote: > Hi Luis, > > On 12/22/23 06:59, Luis Chamberlain wrote: > > On Wed, Nov 22, 2023 at 11:18:12PM +0100, del...@kernel.org wrote: > > > From: Helge Deller > > > > > > On 64-bit architectures without CONFIG_HAVE_ARCH_PREL32_RELOCATIONS

Re: [PATCH 2/4] modules: Ensure 64-bit alignment on __ksymtab_* sections

2023-12-22 Thread Helge Deller
Hi Luis, On 12/22/23 06:59, Luis Chamberlain wrote: On Wed, Nov 22, 2023 at 11:18:12PM +0100, del...@kernel.org wrote: From: Helge Deller On 64-bit architectures without CONFIG_HAVE_ARCH_PREL32_RELOCATIONS (e.g. ppc64, ppc64le, parisc, s390x,...) the __KSYM_REF() macro stores 64-bit pointers

Re: [PATCH 2/4] modules: Ensure 64-bit alignment on __ksymtab_* sections

2023-12-21 Thread Luis Chamberlain
On Wed, Nov 22, 2023 at 11:18:12PM +0100, del...@kernel.org wrote: > From: Helge Deller > > On 64-bit architectures without CONFIG_HAVE_ARCH_PREL32_RELOCATIONS > (e.g. ppc64, ppc64le, parisc, s390x,...) the __KSYM_REF() macro stores > 64-bit pointers into the __ksymtab* sections. > Make sure