Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2017-01-04 Thread Minchan Kim
On Wed, Jan 04, 2017 at 02:52:47PM +0100, Michal Hocko wrote: > With fixed triggered by Vlastimil it should be like this. > --- > From b3a1480b54bf10924a9cd09c6d8b274fc81ca4ad Mon Sep 17 00:00:00 2001 > From: Michal Hocko > Date: Tue, 27 Dec 2016 13:18:20 +0100 > Subject: [PATCH]

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2017-01-04 Thread Minchan Kim
On Wed, Jan 04, 2017 at 02:52:47PM +0100, Michal Hocko wrote: > With fixed triggered by Vlastimil it should be like this. > --- > From b3a1480b54bf10924a9cd09c6d8b274fc81ca4ad Mon Sep 17 00:00:00 2001 > From: Michal Hocko > Date: Tue, 27 Dec 2016 13:18:20 +0100 > Subject: [PATCH] mm, vmscan: add

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2017-01-04 Thread Michal Hocko
With fixed triggered by Vlastimil it should be like this. --- >From b3a1480b54bf10924a9cd09c6d8b274fc81ca4ad Mon Sep 17 00:00:00 2001 From: Michal Hocko Date: Tue, 27 Dec 2016 13:18:20 +0100 Subject: [PATCH] mm, vmscan: add active list aging tracepoint Our reclaim process has

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2017-01-04 Thread Michal Hocko
With fixed triggered by Vlastimil it should be like this. --- >From b3a1480b54bf10924a9cd09c6d8b274fc81ca4ad Mon Sep 17 00:00:00 2001 From: Michal Hocko Date: Tue, 27 Dec 2016 13:18:20 +0100 Subject: [PATCH] mm, vmscan: add active list aging tracepoint Our reclaim process has several tracepoints

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2017-01-04 Thread Vlastimil Babka
On 01/04/2017 02:16 PM, Michal Hocko wrote: > On Wed 04-01-17 13:52:24, Vlastimil Babka wrote: >> On 01/04/2017 11:19 AM, Michal Hocko wrote: >>> From: Michal Hocko >>> >>> Our reclaim process has several tracepoints to tell us more about how >>> things are progressing. We are,

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2017-01-04 Thread Vlastimil Babka
On 01/04/2017 02:16 PM, Michal Hocko wrote: > On Wed 04-01-17 13:52:24, Vlastimil Babka wrote: >> On 01/04/2017 11:19 AM, Michal Hocko wrote: >>> From: Michal Hocko >>> >>> Our reclaim process has several tracepoints to tell us more about how >>> things are progressing. We are, however, missing a

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2017-01-04 Thread Michal Hocko
On Wed 04-01-17 13:52:24, Vlastimil Babka wrote: > On 01/04/2017 11:19 AM, Michal Hocko wrote: > > From: Michal Hocko > > > > Our reclaim process has several tracepoints to tell us more about how > > things are progressing. We are, however, missing a tracepoint to track > >

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2017-01-04 Thread Michal Hocko
On Wed 04-01-17 13:52:24, Vlastimil Babka wrote: > On 01/04/2017 11:19 AM, Michal Hocko wrote: > > From: Michal Hocko > > > > Our reclaim process has several tracepoints to tell us more about how > > things are progressing. We are, however, missing a tracepoint to track > > active list aging.

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2017-01-04 Thread Vlastimil Babka
On 01/04/2017 11:19 AM, Michal Hocko wrote: > From: Michal Hocko > > Our reclaim process has several tracepoints to tell us more about how > things are progressing. We are, however, missing a tracepoint to track > active list aging. Introduce mm_vmscan_lru_shrink_active which

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2017-01-04 Thread Vlastimil Babka
On 01/04/2017 11:19 AM, Michal Hocko wrote: > From: Michal Hocko > > Our reclaim process has several tracepoints to tell us more about how > things are progressing. We are, however, missing a tracepoint to track > active list aging. Introduce mm_vmscan_lru_shrink_active which reports > the

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2017-01-03 Thread Michal Hocko
On Wed 04-01-17 14:07:22, Minchan Kim wrote: > On Tue, Jan 03, 2017 at 09:21:22AM +0100, Michal Hocko wrote: [...] > > with other tracepoints but that can be helpful because you do not have > > all the tracepoints enabled all the time. So unless you see this > > particular thing as a road block I

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2017-01-03 Thread Michal Hocko
On Wed 04-01-17 14:07:22, Minchan Kim wrote: > On Tue, Jan 03, 2017 at 09:21:22AM +0100, Michal Hocko wrote: [...] > > with other tracepoints but that can be helpful because you do not have > > all the tracepoints enabled all the time. So unless you see this > > particular thing as a road block I

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2017-01-03 Thread Vlastimil Babka
On 01/04/2017 06:07 AM, Minchan Kim wrote: > With this, > ./scripts/bloat-o-meter vmlinux.old vmlinux.new.new > add/remove: 1/1 grow/shrink: 0/9 up/down: 1394/-1636 (-242) > function old new delta > isolate_lru_pages -1394

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2017-01-03 Thread Vlastimil Babka
On 01/04/2017 06:07 AM, Minchan Kim wrote: > With this, > ./scripts/bloat-o-meter vmlinux.old vmlinux.new.new > add/remove: 1/1 grow/shrink: 0/9 up/down: 1394/-1636 (-242) > function old new delta > isolate_lru_pages -1394

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2017-01-03 Thread Minchan Kim
On Tue, Jan 03, 2017 at 09:21:22AM +0100, Michal Hocko wrote: > On Tue 03-01-17 14:03:28, Minchan Kim wrote: > > Hi Michal, > > > > On Fri, Dec 30, 2016 at 05:37:42PM +0100, Michal Hocko wrote: > > > On Sat 31-12-16 01:04:56, Minchan Kim wrote: > > > [...] > > > > > From

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2017-01-03 Thread Minchan Kim
On Tue, Jan 03, 2017 at 09:21:22AM +0100, Michal Hocko wrote: > On Tue 03-01-17 14:03:28, Minchan Kim wrote: > > Hi Michal, > > > > On Fri, Dec 30, 2016 at 05:37:42PM +0100, Michal Hocko wrote: > > > On Sat 31-12-16 01:04:56, Minchan Kim wrote: > > > [...] > > > > > From

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2017-01-03 Thread Michal Hocko
On Tue 03-01-17 14:03:28, Minchan Kim wrote: > Hi Michal, > > On Fri, Dec 30, 2016 at 05:37:42PM +0100, Michal Hocko wrote: > > On Sat 31-12-16 01:04:56, Minchan Kim wrote: > > [...] > > > > From 5f1bc22ad1e54050b4da3228d68945e70342ebb6 Mon Sep 17 00:00:00 2001 > > > > From: Michal Hocko

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2017-01-03 Thread Michal Hocko
On Tue 03-01-17 14:03:28, Minchan Kim wrote: > Hi Michal, > > On Fri, Dec 30, 2016 at 05:37:42PM +0100, Michal Hocko wrote: > > On Sat 31-12-16 01:04:56, Minchan Kim wrote: > > [...] > > > > From 5f1bc22ad1e54050b4da3228d68945e70342ebb6 Mon Sep 17 00:00:00 2001 > > > > From: Michal Hocko > > > >

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2017-01-02 Thread Minchan Kim
Hi Michal, On Fri, Dec 30, 2016 at 05:37:42PM +0100, Michal Hocko wrote: > On Sat 31-12-16 01:04:56, Minchan Kim wrote: > [...] > > > From 5f1bc22ad1e54050b4da3228d68945e70342ebb6 Mon Sep 17 00:00:00 2001 > > > From: Michal Hocko > > > Date: Tue, 27 Dec 2016 13:18:20 +0100 > > >

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2017-01-02 Thread Minchan Kim
Hi Michal, On Fri, Dec 30, 2016 at 05:37:42PM +0100, Michal Hocko wrote: > On Sat 31-12-16 01:04:56, Minchan Kim wrote: > [...] > > > From 5f1bc22ad1e54050b4da3228d68945e70342ebb6 Mon Sep 17 00:00:00 2001 > > > From: Michal Hocko > > > Date: Tue, 27 Dec 2016 13:18:20 +0100 > > > Subject: [PATCH]

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2016-12-30 Thread Michal Hocko
On Fri 30-12-16 17:37:42, Michal Hocko wrote: > On Sat 31-12-16 01:04:56, Minchan Kim wrote: [...] > > > - nr_rotated pages which tells us that we are hitting referenced > > > pages which are deactivated. If this is a large part of the > > > reported nr_deactivated pages then the active

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2016-12-30 Thread Michal Hocko
On Fri 30-12-16 17:37:42, Michal Hocko wrote: > On Sat 31-12-16 01:04:56, Minchan Kim wrote: [...] > > > - nr_rotated pages which tells us that we are hitting referenced > > > pages which are deactivated. If this is a large part of the > > > reported nr_deactivated pages then the active

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2016-12-30 Thread Michal Hocko
On Sat 31-12-16 01:04:56, Minchan Kim wrote: [...] > > From 5f1bc22ad1e54050b4da3228d68945e70342ebb6 Mon Sep 17 00:00:00 2001 > > From: Michal Hocko > > Date: Tue, 27 Dec 2016 13:18:20 +0100 > > Subject: [PATCH] mm, vmscan: add active list aging tracepoint > > > > Our reclaim

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2016-12-30 Thread Michal Hocko
On Sat 31-12-16 01:04:56, Minchan Kim wrote: [...] > > From 5f1bc22ad1e54050b4da3228d68945e70342ebb6 Mon Sep 17 00:00:00 2001 > > From: Michal Hocko > > Date: Tue, 27 Dec 2016 13:18:20 +0100 > > Subject: [PATCH] mm, vmscan: add active list aging tracepoint > > > > Our reclaim process has several

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2016-12-30 Thread Minchan Kim
On Fri, Dec 30, 2016 at 10:26:37AM +0100, Michal Hocko wrote: > On Fri 30-12-16 10:48:53, Minchan Kim wrote: > > On Thu, Dec 29, 2016 at 08:52:46AM +0100, Michal Hocko wrote: > > > On Thu 29-12-16 14:33:59, Minchan Kim wrote: > > > > On Wed, Dec 28, 2016 at 04:30:27PM +0100, Michal Hocko wrote: >

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2016-12-30 Thread Minchan Kim
On Fri, Dec 30, 2016 at 10:26:37AM +0100, Michal Hocko wrote: > On Fri 30-12-16 10:48:53, Minchan Kim wrote: > > On Thu, Dec 29, 2016 at 08:52:46AM +0100, Michal Hocko wrote: > > > On Thu 29-12-16 14:33:59, Minchan Kim wrote: > > > > On Wed, Dec 28, 2016 at 04:30:27PM +0100, Michal Hocko wrote: >

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2016-12-30 Thread Hillf Danton
On Friday, December 30, 2016 5:27 PM Michal Hocko wrote: > Anyway, what do you think about this updated patch? I have kept Hillf's > A-b so please let me know if it is no longer valid. > My mind is not changed:) Happy new year folks! Hillf

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2016-12-30 Thread Hillf Danton
On Friday, December 30, 2016 5:27 PM Michal Hocko wrote: > Anyway, what do you think about this updated patch? I have kept Hillf's > A-b so please let me know if it is no longer valid. > My mind is not changed:) Happy new year folks! Hillf

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2016-12-30 Thread Michal Hocko
On Fri 30-12-16 10:48:53, Minchan Kim wrote: > On Thu, Dec 29, 2016 at 08:52:46AM +0100, Michal Hocko wrote: > > On Thu 29-12-16 14:33:59, Minchan Kim wrote: > > > On Wed, Dec 28, 2016 at 04:30:27PM +0100, Michal Hocko wrote: [...] > > > > +TRACE_EVENT(mm_vmscan_lru_shrink_active, > > > > + > > >

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2016-12-30 Thread Michal Hocko
On Fri 30-12-16 10:48:53, Minchan Kim wrote: > On Thu, Dec 29, 2016 at 08:52:46AM +0100, Michal Hocko wrote: > > On Thu 29-12-16 14:33:59, Minchan Kim wrote: > > > On Wed, Dec 28, 2016 at 04:30:27PM +0100, Michal Hocko wrote: [...] > > > > +TRACE_EVENT(mm_vmscan_lru_shrink_active, > > > > + > > >

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2016-12-29 Thread Minchan Kim
On Thu, Dec 29, 2016 at 08:52:46AM +0100, Michal Hocko wrote: > On Thu 29-12-16 14:33:59, Minchan Kim wrote: > > On Wed, Dec 28, 2016 at 04:30:27PM +0100, Michal Hocko wrote: > > > From: Michal Hocko > > > > > > Our reclaim process has several tracepoints to tell us more about

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2016-12-29 Thread Minchan Kim
On Thu, Dec 29, 2016 at 08:52:46AM +0100, Michal Hocko wrote: > On Thu 29-12-16 14:33:59, Minchan Kim wrote: > > On Wed, Dec 28, 2016 at 04:30:27PM +0100, Michal Hocko wrote: > > > From: Michal Hocko > > > > > > Our reclaim process has several tracepoints to tell us more about how > > > things

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2016-12-28 Thread Michal Hocko
On Thu 29-12-16 14:33:59, Minchan Kim wrote: > On Wed, Dec 28, 2016 at 04:30:27PM +0100, Michal Hocko wrote: > > From: Michal Hocko > > > > Our reclaim process has several tracepoints to tell us more about how > > things are progressing. We are, however, missing a tracepoint to

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2016-12-28 Thread Michal Hocko
On Thu 29-12-16 14:33:59, Minchan Kim wrote: > On Wed, Dec 28, 2016 at 04:30:27PM +0100, Michal Hocko wrote: > > From: Michal Hocko > > > > Our reclaim process has several tracepoints to tell us more about how > > things are progressing. We are, however, missing a tracepoint to track > > active

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2016-12-28 Thread Hillf Danton
On Wednesday, December 28, 2016 11:30 PM Michal Hocko wrote: > From: Michal Hocko > > Our reclaim process has several tracepoints to tell us more about how > things are progressing. We are, however, missing a tracepoint to track > active list aging. Introduce

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2016-12-28 Thread Hillf Danton
On Wednesday, December 28, 2016 11:30 PM Michal Hocko wrote: > From: Michal Hocko > > Our reclaim process has several tracepoints to tell us more about how > things are progressing. We are, however, missing a tracepoint to track > active list aging. Introduce mm_vmscan_lru_shrink_active which

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2016-12-28 Thread Minchan Kim
On Wed, Dec 28, 2016 at 04:30:27PM +0100, Michal Hocko wrote: > From: Michal Hocko > > Our reclaim process has several tracepoints to tell us more about how > things are progressing. We are, however, missing a tracepoint to track > active list aging. Introduce

Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

2016-12-28 Thread Minchan Kim
On Wed, Dec 28, 2016 at 04:30:27PM +0100, Michal Hocko wrote: > From: Michal Hocko > > Our reclaim process has several tracepoints to tell us more about how > things are progressing. We are, however, missing a tracepoint to track > active list aging. Introduce mm_vmscan_lru_shrink_active which