Re: [PATCH 3/3] mm/mmap.c: extract __vma_unlink_list as counter part for __vma_link_list

2019-08-21 Thread Wei Yang
On Tue, Aug 20, 2019 at 06:59:39PM -0700, Matthew Wilcox wrote: >On Wed, Aug 21, 2019 at 09:22:44AM +0800, Wei Yang wrote: >> On Tue, Aug 20, 2019 at 05:54:17PM -0700, Matthew Wilcox wrote: >> >On Wed, Aug 21, 2019 at 08:52:34AM +0800, Wei Yang wrote: >> >> On Tue, Aug 20, 2019 at 10:26:29AM

Re: [PATCH 3/3] mm/mmap.c: extract __vma_unlink_list as counter part for __vma_link_list

2019-08-20 Thread Matthew Wilcox
On Wed, Aug 21, 2019 at 09:22:44AM +0800, Wei Yang wrote: > On Tue, Aug 20, 2019 at 05:54:17PM -0700, Matthew Wilcox wrote: > >On Wed, Aug 21, 2019 at 08:52:34AM +0800, Wei Yang wrote: > >> On Tue, Aug 20, 2019 at 10:26:29AM -0700, Matthew Wilcox wrote: > >> >On Wed, Aug 14, 2019 at 11:19:37AM

Re: [PATCH 3/3] mm/mmap.c: extract __vma_unlink_list as counter part for __vma_link_list

2019-08-20 Thread Wei Yang
On Tue, Aug 20, 2019 at 05:54:17PM -0700, Matthew Wilcox wrote: >On Wed, Aug 21, 2019 at 08:52:34AM +0800, Wei Yang wrote: >> On Tue, Aug 20, 2019 at 10:26:29AM -0700, Matthew Wilcox wrote: >> >On Wed, Aug 14, 2019 at 11:19:37AM +0200, Vlastimil Babka wrote: >> >> On 8/14/19 8:57 AM, Wei Yang

Re: [PATCH 3/3] mm/mmap.c: extract __vma_unlink_list as counter part for __vma_link_list

2019-08-20 Thread Matthew Wilcox
On Wed, Aug 21, 2019 at 08:52:34AM +0800, Wei Yang wrote: > On Tue, Aug 20, 2019 at 10:26:29AM -0700, Matthew Wilcox wrote: > >On Wed, Aug 14, 2019 at 11:19:37AM +0200, Vlastimil Babka wrote: > >> On 8/14/19 8:57 AM, Wei Yang wrote: > >> > On Tue, Aug 13, 2019 at 10:16:11PM -0700, Christoph

Re: [PATCH 3/3] mm/mmap.c: extract __vma_unlink_list as counter part for __vma_link_list

2019-08-20 Thread Wei Yang
On Tue, Aug 20, 2019 at 10:26:29AM -0700, Matthew Wilcox wrote: >On Wed, Aug 14, 2019 at 11:19:37AM +0200, Vlastimil Babka wrote: >> On 8/14/19 8:57 AM, Wei Yang wrote: >> > On Tue, Aug 13, 2019 at 10:16:11PM -0700, Christoph Hellwig wrote: >> >>Btw, is there any good reason we don't use a

Re: [PATCH 3/3] mm/mmap.c: extract __vma_unlink_list as counter part for __vma_link_list

2019-08-20 Thread Matthew Wilcox
On Wed, Aug 14, 2019 at 11:19:37AM +0200, Vlastimil Babka wrote: > On 8/14/19 8:57 AM, Wei Yang wrote: > > On Tue, Aug 13, 2019 at 10:16:11PM -0700, Christoph Hellwig wrote: > >>Btw, is there any good reason we don't use a list_head for vma linkage? > > > > Not sure, maybe there is some

Re: [PATCH 3/3] mm/mmap.c: extract __vma_unlink_list as counter part for __vma_link_list

2019-08-14 Thread Wei Yang
On Wed, Aug 14, 2019 at 11:19:37AM +0200, Vlastimil Babka wrote: >On 8/14/19 8:57 AM, Wei Yang wrote: >> On Tue, Aug 13, 2019 at 10:16:11PM -0700, Christoph Hellwig wrote: >>>Btw, is there any good reason we don't use a list_head for vma linkage? >> >> Not sure, maybe there is some historical

Re: [PATCH 3/3] mm/mmap.c: extract __vma_unlink_list as counter part for __vma_link_list

2019-08-14 Thread Vlastimil Babka
On 8/14/19 8:57 AM, Wei Yang wrote: > On Tue, Aug 13, 2019 at 10:16:11PM -0700, Christoph Hellwig wrote: >>Btw, is there any good reason we don't use a list_head for vma linkage? > > Not sure, maybe there is some historical reason? Seems it was single-linked until 2010 commit 297c5eee3724 ("mm:

Re: [PATCH 3/3] mm/mmap.c: extract __vma_unlink_list as counter part for __vma_link_list

2019-08-14 Thread Wei Yang
On Tue, Aug 13, 2019 at 10:16:11PM -0700, Christoph Hellwig wrote: >Btw, is there any good reason we don't use a list_head for vma linkage? Not sure, maybe there is some historical reason? -- Wei Yang Help you, Help me

Re: [PATCH 3/3] mm/mmap.c: extract __vma_unlink_list as counter part for __vma_link_list

2019-08-13 Thread Christoph Hellwig
Btw, is there any good reason we don't use a list_head for vma linkage?