Re: [PATCH 3/3] tile pci: enable IOMMU to support DMA for legacy devices

2012-07-18 Thread Bjorn Helgaas
On Wed, Jul 18, 2012 at 2:10 PM, Chris Metcalf wrote: > On 7/18/2012 12:50 PM, Bjorn Helgaas wrote: >> On Wed, Jul 18, 2012 at 10:15 AM, Chris Metcalf wrote: >>> On 7/13/2012 1:25 PM, Bjorn Helgaas wrote: On Fri, Jul 13, 2012 at 11:52:11AM -0400, Chris Metcalf wrote: > We use the same

Re: [PATCH 3/3] tile pci: enable IOMMU to support DMA for legacy devices

2012-07-18 Thread Chris Metcalf
On 7/18/2012 12:50 PM, Bjorn Helgaas wrote: > On Wed, Jul 18, 2012 at 10:15 AM, Chris Metcalf wrote: >> On 7/13/2012 1:25 PM, Bjorn Helgaas wrote: >>> On Fri, Jul 13, 2012 at 11:52:11AM -0400, Chris Metcalf wrote: We use the same pci_iomem_resource for different domains or host bridges,

Re: [PATCH 3/3] tile pci: enable IOMMU to support DMA for legacy devices

2012-07-18 Thread Bjorn Helgaas
On Wed, Jul 18, 2012 at 10:15 AM, Chris Metcalf wrote: > On 7/13/2012 1:25 PM, Bjorn Helgaas wrote: >> On Fri, Jul 13, 2012 at 11:52:11AM -0400, Chris Metcalf wrote: >>> On 6/22/2012 7:24 AM, Bjorn Helgaas wrote: This says that your entire physical address space (currently

Re: [PATCH 3/3] tile pci: enable IOMMU to support DMA for legacy devices

2012-07-18 Thread Chris Metcalf
On 7/13/2012 1:25 PM, Bjorn Helgaas wrote: > On Fri, Jul 13, 2012 at 11:52:11AM -0400, Chris Metcalf wrote: >> On 6/22/2012 7:24 AM, Bjorn Helgaas wrote: >>> This says that your entire physical address space (currently >>> 0x0-0x_) is routed to the PCI bus, which is not true. I >>>

Re: [PATCH 3/3] tile pci: enable IOMMU to support DMA for legacy devices

2012-07-18 Thread Chris Metcalf
On 7/13/2012 1:25 PM, Bjorn Helgaas wrote: On Fri, Jul 13, 2012 at 11:52:11AM -0400, Chris Metcalf wrote: On 6/22/2012 7:24 AM, Bjorn Helgaas wrote: This says that your entire physical address space (currently 0x0-0x_) is routed to the PCI bus, which is not true. I think what

Re: [PATCH 3/3] tile pci: enable IOMMU to support DMA for legacy devices

2012-07-18 Thread Bjorn Helgaas
On Wed, Jul 18, 2012 at 10:15 AM, Chris Metcalf cmetc...@tilera.com wrote: On 7/13/2012 1:25 PM, Bjorn Helgaas wrote: On Fri, Jul 13, 2012 at 11:52:11AM -0400, Chris Metcalf wrote: On 6/22/2012 7:24 AM, Bjorn Helgaas wrote: This says that your entire physical address space (currently

Re: [PATCH 3/3] tile pci: enable IOMMU to support DMA for legacy devices

2012-07-18 Thread Chris Metcalf
On 7/18/2012 12:50 PM, Bjorn Helgaas wrote: On Wed, Jul 18, 2012 at 10:15 AM, Chris Metcalf cmetc...@tilera.com wrote: On 7/13/2012 1:25 PM, Bjorn Helgaas wrote: On Fri, Jul 13, 2012 at 11:52:11AM -0400, Chris Metcalf wrote: We use the same pci_iomem_resource for different domains or host

Re: [PATCH 3/3] tile pci: enable IOMMU to support DMA for legacy devices

2012-07-18 Thread Bjorn Helgaas
On Wed, Jul 18, 2012 at 2:10 PM, Chris Metcalf cmetc...@tilera.com wrote: On 7/18/2012 12:50 PM, Bjorn Helgaas wrote: On Wed, Jul 18, 2012 at 10:15 AM, Chris Metcalf cmetc...@tilera.com wrote: On 7/13/2012 1:25 PM, Bjorn Helgaas wrote: On Fri, Jul 13, 2012 at 11:52:11AM -0400, Chris Metcalf

Re: [PATCH 3/3] tile pci: enable IOMMU to support DMA for legacy devices

2012-07-13 Thread Bjorn Helgaas
On Fri, Jul 13, 2012 at 11:52:11AM -0400, Chris Metcalf wrote: > Sorry for the slow reply to your feedback; I had to coordinate with our > primary PCI developer (in another timezone) and we both had various > unrelated fires to fight along the way. > > I've appended the patch that corrects all

Re: [PATCH 3/3] tile pci: enable IOMMU to support DMA for legacy devices

2012-07-13 Thread Chris Metcalf
Sorry for the slow reply to your feedback; I had to coordinate with our primary PCI developer (in another timezone) and we both had various unrelated fires to fight along the way. I've appended the patch that corrects all the issues you reported. Bjorn, I'm assuming that it's appropriate for me

Re: [PATCH 3/3] tile pci: enable IOMMU to support DMA for legacy devices

2012-07-13 Thread Chris Metcalf
Sorry for the slow reply to your feedback; I had to coordinate with our primary PCI developer (in another timezone) and we both had various unrelated fires to fight along the way. I've appended the patch that corrects all the issues you reported. Bjorn, I'm assuming that it's appropriate for me

Re: [PATCH 3/3] tile pci: enable IOMMU to support DMA for legacy devices

2012-07-13 Thread Bjorn Helgaas
On Fri, Jul 13, 2012 at 11:52:11AM -0400, Chris Metcalf wrote: Sorry for the slow reply to your feedback; I had to coordinate with our primary PCI developer (in another timezone) and we both had various unrelated fires to fight along the way. I've appended the patch that corrects all the