Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

On Mon, Feb 1, 2016 at 11:41 AM, David Miller wrote: > From: David Laight > Date: Mon, 1 Feb 2016 16:37:41 + > >> From: Lucas Tanure >>> Sent: 30 January 2016 13:18 >>> As suggested by checkpatch.pl: >>> CHECK: Prefer kernel type 'uX' over 'uintX_t' >> >> One might ask why? > > We have

Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

From: David Laight Date: Mon, 1 Feb 2016 16:37:41 + > From: Lucas Tanure >> Sent: 30 January 2016 13:18 >> As suggested by checkpatch.pl: >> CHECK: Prefer kernel type 'uX' over 'uintX_t' > > One might ask why? We have consistently done this, and consistency is enough of an argument.

RE: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

From: Lucas Tanure > Sent: 30 January 2016 13:18 > As suggested by checkpatch.pl: > CHECK: Prefer kernel type 'uX' over 'uintX_t' One might ask why? The kernel types are older, but the uintX_t ones are now part of the C standard. Writing header files (eg for ioctl buffers) that have to be parsed

Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

From: David Laight Date: Mon, 1 Feb 2016 16:37:41 + > From: Lucas Tanure >> Sent: 30 January 2016 13:18 >> As suggested by checkpatch.pl: >> CHECK: Prefer kernel type 'uX' over 'uintX_t' > > One might ask why? We have consistently done this, and consistency is

Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

On Mon, Feb 1, 2016 at 11:41 AM, David Miller wrote: > From: David Laight > Date: Mon, 1 Feb 2016 16:37:41 + > >> From: Lucas Tanure >>> Sent: 30 January 2016 13:18 >>> As suggested by checkpatch.pl: >>> CHECK: Prefer kernel type 'uX' over

RE: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

From: Lucas Tanure > Sent: 30 January 2016 13:18 > As suggested by checkpatch.pl: > CHECK: Prefer kernel type 'uX' over 'uintX_t' One might ask why? The kernel types are older, but the uintX_t ones are now part of the C standard. Writing header files (eg for ioctl buffers) that have to be parsed

Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

On Sat, Jan 30, 2016 at 4:26 PM, Joe Perches wrote: > On Sat, 2016-01-30 at 09:51 -0800, Eric Dumazet wrote: >> On Sat, 2016-01-30 at 12:05 -0200, Lucas Tanure wrote: >> > On Sat, Jan 30, 2016 at 11:45 AM, Patrick McHardy wrote: >> > > On 30.01, Lucas Tanure wrote: >> > > > As suggested by

Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

On Sat, 2016-01-30 at 09:51 -0800, Eric Dumazet wrote: > On Sat, 2016-01-30 at 12:05 -0200, Lucas Tanure wrote: > > On Sat, Jan 30, 2016 at 11:45 AM, Patrick McHardy wrote: > > > On 30.01, Lucas Tanure wrote: > > > > As suggested by checkpatch.pl: > > > > CHECK: Prefer kernel type 'uX' over

Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

On Sat, 2016-01-30 at 12:05 -0200, Lucas Tanure wrote: > On Sat, Jan 30, 2016 at 11:45 AM, Patrick McHardy wrote: > > On 30.01, Lucas Tanure wrote: > >> As suggested by checkpatch.pl: > >> CHECK: Prefer kernel type 'uX' over 'uintX_t' > > > > You might have noticed we have literally hundreds of

Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

On Sat, 2016-01-30 at 12:05 -0200, Lucas Tanure wrote: > On Sat, Jan 30, 2016 at 11:45 AM, Patrick McHardy wrote: > > On 30.01, Lucas Tanure wrote: > > > As suggested by checkpatch.pl: > > > CHECK: Prefer kernel type 'uX' over 'uintX_t' > > > > You might have noticed we have literally hundreds

Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

On Sat, Jan 30, 2016 at 11:45 AM, Patrick McHardy wrote: > On 30.01, Lucas Tanure wrote: >> As suggested by checkpatch.pl: >> CHECK: Prefer kernel type 'uX' over 'uintX_t' > > You might have noticed we have literally hundreds of them spread over 100 > files in the netfilter code. We'll gradually

Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

On 30.01, Lucas Tanure wrote: > As suggested by checkpatch.pl: > CHECK: Prefer kernel type 'uX' over 'uintX_t' You might have noticed we have literally hundreds of them spread over 100 files in the netfilter code. We'll gradually change them when the code is touched anyways. >

Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

On Sat, 2016-01-30 at 12:05 -0200, Lucas Tanure wrote: > On Sat, Jan 30, 2016 at 11:45 AM, Patrick McHardy wrote: > > On 30.01, Lucas Tanure wrote: > >> As suggested by checkpatch.pl: > >> CHECK: Prefer kernel type 'uX' over 'uintX_t' > > > > You might have noticed we have

Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

On Sat, 2016-01-30 at 09:51 -0800, Eric Dumazet wrote: > On Sat, 2016-01-30 at 12:05 -0200, Lucas Tanure wrote: > > On Sat, Jan 30, 2016 at 11:45 AM, Patrick McHardy wrote: > > > On 30.01, Lucas Tanure wrote: > > > > As suggested by checkpatch.pl: > > > > CHECK: Prefer kernel

Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

On Sat, Jan 30, 2016 at 4:26 PM, Joe Perches wrote: > On Sat, 2016-01-30 at 09:51 -0800, Eric Dumazet wrote: >> On Sat, 2016-01-30 at 12:05 -0200, Lucas Tanure wrote: >> > On Sat, Jan 30, 2016 at 11:45 AM, Patrick McHardy wrote: >> > > On 30.01, Lucas Tanure

Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

On Sat, 2016-01-30 at 12:05 -0200, Lucas Tanure wrote: > On Sat, Jan 30, 2016 at 11:45 AM, Patrick McHardy wrote: > > On 30.01, Lucas Tanure wrote: > > > As suggested by checkpatch.pl: > > > CHECK: Prefer kernel type 'uX' over 'uintX_t' > > > > You might have noticed we have

Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

On 30.01, Lucas Tanure wrote: > As suggested by checkpatch.pl: > CHECK: Prefer kernel type 'uX' over 'uintX_t' You might have noticed we have literally hundreds of them spread over 100 files in the netfilter code. We'll gradually change them when the code is touched anyways. >

Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

On Sat, Jan 30, 2016 at 11:45 AM, Patrick McHardy wrote: > On 30.01, Lucas Tanure wrote: >> As suggested by checkpatch.pl: >> CHECK: Prefer kernel type 'uX' over 'uintX_t' > > You might have noticed we have literally hundreds of them spread over 100 > files in the netfilter code.