Re: [PATCH 3/5] brd: Add getgeo to block ops

2014-08-28 Thread Boaz Harrosh
On 08/28/2014 06:11 PM, Matthew Wilcox wrote: > On Thu, Aug 28, 2014 at 10:26:31AM +0300, Boaz Harrosh wrote: <> >> No with patch 5/5 the 4k stuff is good. >> >> What I'm saying is that with (64, 32, x) fdisk offers a very high first >> sector and with all 1(s) it will allow a low value like 4k >>

Re: [PATCH 3/5] brd: Add getgeo to block ops

2014-08-28 Thread Matthew Wilcox
On Thu, Aug 28, 2014 at 10:26:31AM +0300, Boaz Harrosh wrote: > On 08/27/2014 08:53 PM, Matthew Wilcox wrote: > > On Wed, Aug 27, 2014 at 06:28:25PM +0300, Boaz Harrosh wrote: > >> We set all hd_geometry members to 1, because this way fdisk > >> math will not try its crazy geometry math and get

Re: [PATCH 3/5] brd: Add getgeo to block ops

2014-08-28 Thread Boaz Harrosh
On 08/27/2014 08:53 PM, Matthew Wilcox wrote: > On Wed, Aug 27, 2014 at 06:28:25PM +0300, Boaz Harrosh wrote: >> We set all hd_geometry members to 1, because this way fdisk >> math will not try its crazy geometry math and get stuff totally wrong. >> >> I was trying to get some values that will

Re: [PATCH 3/5] brd: Add getgeo to block ops

2014-08-28 Thread Boaz Harrosh
On 08/27/2014 08:53 PM, Matthew Wilcox wrote: On Wed, Aug 27, 2014 at 06:28:25PM +0300, Boaz Harrosh wrote: We set all hd_geometry members to 1, because this way fdisk math will not try its crazy geometry math and get stuff totally wrong. I was trying to get some values that will make fdisk

Re: [PATCH 3/5] brd: Add getgeo to block ops

2014-08-28 Thread Matthew Wilcox
On Thu, Aug 28, 2014 at 10:26:31AM +0300, Boaz Harrosh wrote: On 08/27/2014 08:53 PM, Matthew Wilcox wrote: On Wed, Aug 27, 2014 at 06:28:25PM +0300, Boaz Harrosh wrote: We set all hd_geometry members to 1, because this way fdisk math will not try its crazy geometry math and get stuff

Re: [PATCH 3/5] brd: Add getgeo to block ops

2014-08-28 Thread Boaz Harrosh
On 08/28/2014 06:11 PM, Matthew Wilcox wrote: On Thu, Aug 28, 2014 at 10:26:31AM +0300, Boaz Harrosh wrote: No with patch 5/5 the 4k stuff is good. What I'm saying is that with (64, 32, x) fdisk offers a very high first sector and with all 1(s) it will allow a low value like 4k For example

Re: [PATCH 3/5] brd: Add getgeo to block ops

2014-08-27 Thread Matthew Wilcox
On Wed, Aug 27, 2014 at 06:28:25PM +0300, Boaz Harrosh wrote: > We set all hd_geometry members to 1, because this way fdisk > math will not try its crazy geometry math and get stuff totally wrong. > > I was trying to get some values that will make fdisk Want to align > first sector on 4K (like 8,

Re: [PATCH 3/5] brd: Add getgeo to block ops

2014-08-27 Thread Matthew Wilcox
On Wed, Aug 27, 2014 at 06:28:25PM +0300, Boaz Harrosh wrote: We set all hd_geometry members to 1, because this way fdisk math will not try its crazy geometry math and get stuff totally wrong. I was trying to get some values that will make fdisk Want to align first sector on 4K (like 8, 16,