Re: [PATCH 3/8] spi: dw: Add support for Pensando Elba SoC SPI

2021-03-09 Thread Brad Larson
On Thu, Mar 4, 2021 at 12:48 AM Linus Walleij wrote: > On Thu, Mar 4, 2021 at 4:42 AM Brad Larson wrote: > > > The Pensando Elba SoC uses a GPIO based chip select > > for two DW SPI busses with each bus having two > > chip selects. > > > > Signed-off-by: Brad Larson > > I agree with Serge's

Re: [PATCH 3/8] spi: dw: Add support for Pensando Elba SoC SPI

2021-03-04 Thread Linus Walleij
On Thu, Mar 4, 2021 at 4:42 AM Brad Larson wrote: > The Pensando Elba SoC uses a GPIO based chip select > for two DW SPI busses with each bus having two > chip selects. > > Signed-off-by: Brad Larson I agree with Serge's comments here: the existing cs callback should work for your SoC, you

Re: [PATCH 3/8] spi: dw: Add support for Pensando Elba SoC SPI

2021-03-03 Thread Serge Semin
Hello Brad. Thanks for the patch. See my comments below. On Wed, Mar 03, 2021 at 07:41:36PM -0800, Brad Larson wrote: > The Pensando Elba SoC uses a GPIO based chip select > for two DW SPI busses with each bus having two > chip selects. I see a contradiction here. Normally GPIO-based chip-select