Re: [PATCH 4/4] lockdep: Fix workqueue crossrelease annotation

2017-08-24 Thread Peter Zijlstra
On Thu, Aug 24, 2017 at 11:18:40AM +0900, Byungchul Park wrote: > On Wed, Aug 23, 2017 at 01:58:47PM +0200, Peter Zijlstra wrote: > > Also, unconditinoally switching to recursive-read here would fail to > > detect the actual deadlock on single-threaded workqueues, which do > > Do you mean it's

Re: [PATCH 4/4] lockdep: Fix workqueue crossrelease annotation

2017-08-24 Thread Peter Zijlstra
On Thu, Aug 24, 2017 at 11:18:40AM +0900, Byungchul Park wrote: > On Wed, Aug 23, 2017 at 01:58:47PM +0200, Peter Zijlstra wrote: > > Also, unconditinoally switching to recursive-read here would fail to > > detect the actual deadlock on single-threaded workqueues, which do > > Do you mean it's

Re: [PATCH 4/4] lockdep: Fix workqueue crossrelease annotation

2017-08-23 Thread Byungchul Park
On Wed, Aug 23, 2017 at 01:58:47PM +0200, Peter Zijlstra wrote: > The new completion/crossrelease annotations interact unfavourable with > the extant flush_work()/flush_workqueue() annotations. > > The problem is that when a single work class does: > > wait_for_completion() > > and > >

Re: [PATCH 4/4] lockdep: Fix workqueue crossrelease annotation

2017-08-23 Thread Byungchul Park
On Wed, Aug 23, 2017 at 01:58:47PM +0200, Peter Zijlstra wrote: > The new completion/crossrelease annotations interact unfavourable with > the extant flush_work()/flush_workqueue() annotations. > > The problem is that when a single work class does: > > wait_for_completion() > > and > >

<    1   2