Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump command

2017-03-22 Thread Taeung Song
On 03/22/2017 03:32 AM, Arnaldo Carvalho de Melo wrote: Em Tue, Mar 21, 2017 at 03:29:50PM -0300, Arnaldo Carvalho de Melo escreveu: Em Wed, Mar 22, 2017 at 01:19:49AM +0900, Taeung Song escreveu: On 03/21/2017 11:37 PM, Arnaldo Carvalho de Melo wrote: +++ b/tools/perf/util/annotate.c @@

Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump command

2017-03-22 Thread Taeung Song
On 03/22/2017 03:32 AM, Arnaldo Carvalho de Melo wrote: Em Tue, Mar 21, 2017 at 03:29:50PM -0300, Arnaldo Carvalho de Melo escreveu: Em Wed, Mar 22, 2017 at 01:19:49AM +0900, Taeung Song escreveu: On 03/21/2017 11:37 PM, Arnaldo Carvalho de Melo wrote: +++ b/tools/perf/util/annotate.c @@

Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump command

2017-03-21 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 21, 2017 at 03:29:50PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Mar 22, 2017 at 01:19:49AM +0900, Taeung Song escreveu: > > On 03/21/2017 11:37 PM, Arnaldo Carvalho de Melo wrote: > > > > +++ b/tools/perf/util/annotate.c > > > > @@ -1443,7 +1443,7 @@ int

Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump command

2017-03-21 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 21, 2017 at 03:29:50PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Mar 22, 2017 at 01:19:49AM +0900, Taeung Song escreveu: > > On 03/21/2017 11:37 PM, Arnaldo Carvalho de Melo wrote: > > > > +++ b/tools/perf/util/annotate.c > > > > @@ -1443,7 +1443,7 @@ int

Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump command

2017-03-21 Thread Arnaldo Carvalho de Melo
Em Wed, Mar 22, 2017 at 01:19:49AM +0900, Taeung Song escreveu: > On 03/21/2017 11:37 PM, Arnaldo Carvalho de Melo wrote: > > > +++ b/tools/perf/util/annotate.c > > > @@ -1443,7 +1443,7 @@ int symbol__disassemble(struct symbol *sym, struct > > > map *map, const char *arch_na > > >

Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump command

2017-03-21 Thread Arnaldo Carvalho de Melo
Em Wed, Mar 22, 2017 at 01:19:49AM +0900, Taeung Song escreveu: > On 03/21/2017 11:37 PM, Arnaldo Carvalho de Melo wrote: > > > +++ b/tools/perf/util/annotate.c > > > @@ -1443,7 +1443,7 @@ int symbol__disassemble(struct symbol *sym, struct > > > map *map, const char *arch_na > > >

Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump command

2017-03-21 Thread Taeung Song
Thank you for your review :) On 03/21/2017 11:37 PM, Arnaldo Carvalho de Melo wrote: Em Mon, Mar 20, 2017 at 11:56:57AM +0900, Taeung Song escreveu: grep -v "file name" in the objdump command cause a side effect eliminating filename:linenr of output of 'objdump -l' if the object file name and

Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump command

2017-03-21 Thread Taeung Song
Thank you for your review :) On 03/21/2017 11:37 PM, Arnaldo Carvalho de Melo wrote: Em Mon, Mar 20, 2017 at 11:56:57AM +0900, Taeung Song escreveu: grep -v "file name" in the objdump command cause a side effect eliminating filename:linenr of output of 'objdump -l' if the object file name and

Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump command

2017-03-21 Thread Taeung Song
Thank you for your review :) On 03/21/2017 11:37 PM, Arnaldo Carvalho de Melo wrote: Em Mon, Mar 20, 2017 at 11:56:57AM +0900, Taeung Song escreveu: grep -v "file name" in the objdump command cause a side effect eliminating filename:linenr of output of 'objdump -l' if the object file name and

Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump command

2017-03-21 Thread Taeung Song
Thank you for your review :) On 03/21/2017 11:37 PM, Arnaldo Carvalho de Melo wrote: Em Mon, Mar 20, 2017 at 11:56:57AM +0900, Taeung Song escreveu: grep -v "file name" in the objdump command cause a side effect eliminating filename:linenr of output of 'objdump -l' if the object file name and

Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump command

2017-03-21 Thread Arnaldo Carvalho de Melo
Em Mon, Mar 20, 2017 at 11:56:57AM +0900, Taeung Song escreveu: > grep -v "file name" in the objdump command > cause a side effect eliminating filename:linenr of > output of 'objdump -l' if the object file name and > source file name are about the same so fix it. > > The objdump command in

Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump command

2017-03-21 Thread Arnaldo Carvalho de Melo
Em Mon, Mar 20, 2017 at 11:56:57AM +0900, Taeung Song escreveu: > grep -v "file name" in the objdump command > cause a side effect eliminating filename:linenr of > output of 'objdump -l' if the object file name and > source file name are about the same so fix it. > > The objdump command in