Re: [PATCH 4/5] perf diff: Fix output ordering to honor next column

2015-01-06 Thread Namhyung Kim
Hi Jiri, On Sun, Jan 04, 2015 at 07:16:40PM +0100, Jiri Olsa wrote: > On Sat, Dec 27, 2014 at 02:06:32PM +0900, Namhyung Kim wrote: > > SNIP > > > if (!pairs_left || !pairs_right) > > return pairs_left ? -1 : 1; > > > > - p_left = get_pair_data(left,

Re: [PATCH 4/5] perf diff: Fix output ordering to honor next column

2015-01-06 Thread Namhyung Kim
Hi Jiri, On Sun, Jan 04, 2015 at 07:16:40PM +0100, Jiri Olsa wrote: On Sat, Dec 27, 2014 at 02:06:32PM +0900, Namhyung Kim wrote: SNIP if (!pairs_left || !pairs_right) return pairs_left ? -1 : 1; - p_left = get_pair_data(left, data__files[sort_compute]); -

Re: [PATCH 4/5] perf diff: Fix output ordering to honor next column

2015-01-04 Thread Jiri Olsa
On Sat, Dec 27, 2014 at 02:06:32PM +0900, Namhyung Kim wrote: SNIP > if (!pairs_left || !pairs_right) > return pairs_left ? -1 : 1; > > - p_left = get_pair_data(left, __files[sort_compute]); > - p_right = get_pair_data(right, __files[sort_compute]); > + p_left

Re: [PATCH 4/5] perf diff: Fix output ordering to honor next column

2015-01-04 Thread Jiri Olsa
On Sat, Dec 27, 2014 at 02:06:32PM +0900, Namhyung Kim wrote: SNIP if (!pairs_left || !pairs_right) return pairs_left ? -1 : 1; - p_left = get_pair_data(left, data__files[sort_compute]); - p_right = get_pair_data(right, data__files[sort_compute]); +