Re: [PATCH 4/5] pwm: rockchip: Add atomic updated feature for rk3328

2017-07-06 Thread Rob Herring
On Thu, Jun 29, 2017 at 08:27:50PM +0800, David Wu wrote: > The rk3328 soc supports atomic update, we could lock the configuration > of period and duty at first, after unlock is configured, the period and > duty are effective at the same time. > > If the polarity, period and duty need to be

Re: [PATCH 4/5] pwm: rockchip: Add atomic updated feature for rk3328

2017-07-06 Thread Rob Herring
On Thu, Jun 29, 2017 at 08:27:50PM +0800, David Wu wrote: > The rk3328 soc supports atomic update, we could lock the configuration > of period and duty at first, after unlock is configured, the period and > duty are effective at the same time. > > If the polarity, period and duty need to be

Re: [PATCH 4/5] pwm: rockchip: Add atomic updated feature for rk3328

2017-07-04 Thread David.Wu
Hi Boris, 在 2017/7/4 2:39, Boris Brezillon 写道: Yet another customization. Don't you think we can extract common parts, expose them as helpers and then have 3 different pwm_ops (with 3 different ->apply() implementation), one for each IP revision. Sounds reasonable.I will try to implement 3

Re: [PATCH 4/5] pwm: rockchip: Add atomic updated feature for rk3328

2017-07-04 Thread David.Wu
Hi Boris, 在 2017/7/4 2:39, Boris Brezillon 写道: Yet another customization. Don't you think we can extract common parts, expose them as helpers and then have 3 different pwm_ops (with 3 different ->apply() implementation), one for each IP revision. Sounds reasonable.I will try to implement 3

Re: [PATCH 4/5] pwm: rockchip: Add atomic updated feature for rk3328

2017-07-03 Thread Boris Brezillon
On Thu, 29 Jun 2017 20:27:50 +0800 David Wu wrote: > The rk3328 soc supports atomic update, we could lock the configuration > of period and duty at first, after unlock is configured, the period and > duty are effective at the same time. > > If the polarity, period and

Re: [PATCH 4/5] pwm: rockchip: Add atomic updated feature for rk3328

2017-07-03 Thread Boris Brezillon
On Thu, 29 Jun 2017 20:27:50 +0800 David Wu wrote: > The rk3328 soc supports atomic update, we could lock the configuration > of period and duty at first, after unlock is configured, the period and > duty are effective at the same time. > > If the polarity, period and duty need to be configured