Re: [PATCH 5/6] sched, fair: Make group power more consitent

2013-08-19 Thread Preeti U Murthy
Hi Peter, Thank you for the clarification. On 08/19/2013 04:00 PM, Peter Zijlstra wrote: > On Mon, Aug 19, 2013 at 09:47:47AM +0530, Preeti U Murthy wrote: >> Hi Peter, >> >> On 08/16/2013 03:42 PM, Peter Zijlstra wrote: >> >> I have a few comments and clarification to seek. >> >> 1. How are you

Re: [PATCH 5/6] sched, fair: Make group power more consitent

2013-08-19 Thread Peter Zijlstra
On Mon, Aug 19, 2013 at 09:47:47AM +0530, Preeti U Murthy wrote: > Hi Peter, > > On 08/16/2013 03:42 PM, Peter Zijlstra wrote: > > I have a few comments and clarification to seek. > > 1. How are you ensuring from this patch that sgs->group_power does not > change over the course of load

Re: [PATCH 5/6] sched, fair: Make group power more consitent

2013-08-19 Thread Peter Zijlstra
On Mon, Aug 19, 2013 at 09:47:47AM +0530, Preeti U Murthy wrote: Hi Peter, On 08/16/2013 03:42 PM, Peter Zijlstra wrote: I have a few comments and clarification to seek. 1. How are you ensuring from this patch that sgs-group_power does not change over the course of load balancing?

Re: [PATCH 5/6] sched, fair: Make group power more consitent

2013-08-19 Thread Preeti U Murthy
Hi Peter, Thank you for the clarification. On 08/19/2013 04:00 PM, Peter Zijlstra wrote: On Mon, Aug 19, 2013 at 09:47:47AM +0530, Preeti U Murthy wrote: Hi Peter, On 08/16/2013 03:42 PM, Peter Zijlstra wrote: I have a few comments and clarification to seek. 1. How are you ensuring from

Re: [PATCH 5/6] sched, fair: Make group power more consitent

2013-08-18 Thread Preeti U Murthy
Hi Peter, On 08/16/2013 03:42 PM, Peter Zijlstra wrote: I have a few comments and clarification to seek. 1. How are you ensuring from this patch that sgs->group_power does not change over the course of load balancing? The only path to update_group_power() where sg->sgp->power gets updated,

Re: [PATCH 5/6] sched, fair: Make group power more consitent

2013-08-18 Thread Preeti U Murthy
Hi Peter, On 08/16/2013 03:42 PM, Peter Zijlstra wrote: I have a few comments and clarification to seek. 1. How are you ensuring from this patch that sgs-group_power does not change over the course of load balancing? The only path to update_group_power() where sg-sgp-power gets updated, is