Re: [PATCH 5/7] scsi: mac_scsi: Fix pseudo DMA implementation, take 2

2019-06-03 Thread Finn Thain
On Tue, 4 Jun 2019, Michael Schmitz wrote: > Hi Finn, > > On 3/06/19 7:40 PM, Finn Thain wrote: > > > > > There are several other drivers that contain pieces of assembler code. > > > > > Does any driver contain assembler code for multiple architectures? I was > > trying to avoid that -- though

Re: [PATCH 5/7] scsi: mac_scsi: Fix pseudo DMA implementation, take 2

2019-06-03 Thread Michael Schmitz
Hi Finn, On 3/06/19 7:40 PM, Finn Thain wrote: There are several other drivers that contain pieces of assembler code. Does any driver contain assembler code for multiple architectures? I was trying to avoid that -- though admittedly I don't yet have actual code for the PDMA implementation

Re: [PATCH 5/7] scsi: mac_scsi: Fix pseudo DMA implementation, take 2

2019-06-03 Thread Geert Uytterhoeven
Hi Finn, On Mon, Jun 3, 2019 at 9:40 AM Finn Thain wrote: > On Mon, 3 Jun 2019, Geert Uytterhoeven wrote: > > On Mon, Jun 3, 2019 at 1:32 AM Finn Thain > > wrote: > > > On Sun, 2 Jun 2019, Geert Uytterhoeven wrote: > > > > On Sun, Jun 2, 2019 at 3:29 AM Finn Thain > > > > wrote: > > > > > A

Re: [PATCH 5/7] scsi: mac_scsi: Fix pseudo DMA implementation, take 2

2019-06-03 Thread Finn Thain
On Mon, 3 Jun 2019, Geert Uytterhoeven wrote: > Hi Finn, > > On Mon, Jun 3, 2019 at 1:32 AM Finn Thain wrote: > > On Sun, 2 Jun 2019, Geert Uytterhoeven wrote: > > > On Sun, Jun 2, 2019 at 3:29 AM Finn Thain > > > wrote: > > > > A system bus error during a PDMA transfer can mess up the

Re: [PATCH 5/7] scsi: mac_scsi: Fix pseudo DMA implementation, take 2

2019-06-03 Thread Geert Uytterhoeven
Hi Finn, On Mon, Jun 3, 2019 at 1:32 AM Finn Thain wrote: > On Sun, 2 Jun 2019, Geert Uytterhoeven wrote: > > On Sun, Jun 2, 2019 at 3:29 AM Finn Thain > > wrote: > > > A system bus error during a PDMA transfer can mess up the calculation > > > of the transfer residual (the PDMA handshaking

Re: [PATCH 5/7] scsi: mac_scsi: Fix pseudo DMA implementation, take 2

2019-06-02 Thread Finn Thain
On Sun, 2 Jun 2019, Geert Uytterhoeven wrote: > Hi Finn, > > On Sun, Jun 2, 2019 at 3:29 AM Finn Thain > wrote: > > A system bus error during a PDMA transfer can mess up the calculation > > of the transfer residual (the PDMA handshaking hardware lacks a byte > > counter). This results in

Re: [PATCH 5/7] scsi: mac_scsi: Fix pseudo DMA implementation, take 2

2019-06-02 Thread Geert Uytterhoeven
Hi Finn, On Sun, Jun 2, 2019 at 3:29 AM Finn Thain wrote: > A system bus error during a PDMA transfer can mess up the calculation of > the transfer residual (the PDMA handshaking hardware lacks a byte > counter). This results in data corruption. > > The algorithm in this patch anticipates a bus