Re: [PATCH 6/6] x86: Exit RCU extended QS on notify resume

2012-07-10 Thread Frederic Weisbecker
On Sun, Jul 08, 2012 at 02:17:07PM -0700, Paul E. McKenney wrote: > On Fri, Jul 06, 2012 at 01:43:29PM -0700, Josh Triplett wrote: > > On Fri, Jul 06, 2012 at 09:33:38AM -0700, Paul E. McKenney wrote: > > > On Fri, Jul 06, 2012 at 02:00:18PM +0200, Frederic Weisbecker wrote: > > > > ---

Re: [PATCH 6/6] x86: Exit RCU extended QS on notify resume

2012-07-10 Thread Paul E. McKenney
On Fri, Jul 06, 2012 at 01:43:29PM -0700, Josh Triplett wrote: > On Fri, Jul 06, 2012 at 09:33:38AM -0700, Paul E. McKenney wrote: > > On Fri, Jul 06, 2012 at 02:00:18PM +0200, Frederic Weisbecker wrote: > > > --- a/arch/x86/Kconfig > > > +++ b/arch/x86/Kconfig > > > @@ -95,6 +95,7 @@ config X86 >

Re: [PATCH 6/6] x86: Exit RCU extended QS on notify resume

2012-07-10 Thread Paul E. McKenney
On Fri, Jul 06, 2012 at 01:43:29PM -0700, Josh Triplett wrote: On Fri, Jul 06, 2012 at 09:33:38AM -0700, Paul E. McKenney wrote: On Fri, Jul 06, 2012 at 02:00:18PM +0200, Frederic Weisbecker wrote: --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -95,6 +95,7 @@ config X86 select

Re: [PATCH 6/6] x86: Exit RCU extended QS on notify resume

2012-07-10 Thread Frederic Weisbecker
On Sun, Jul 08, 2012 at 02:17:07PM -0700, Paul E. McKenney wrote: On Fri, Jul 06, 2012 at 01:43:29PM -0700, Josh Triplett wrote: On Fri, Jul 06, 2012 at 09:33:38AM -0700, Paul E. McKenney wrote: On Fri, Jul 06, 2012 at 02:00:18PM +0200, Frederic Weisbecker wrote: --- a/arch/x86/Kconfig

Re: [PATCH 6/6] x86: Exit RCU extended QS on notify resume

2012-07-09 Thread Frederic Weisbecker
On Fri, Jul 06, 2012 at 09:33:38AM -0700, Paul E. McKenney wrote: > On Fri, Jul 06, 2012 at 02:00:18PM +0200, Frederic Weisbecker wrote: > > do_notify_resume() may be called on irq exit but it won't > > be protected between rcu_irq_enter() and rcu_irq_exit() > > and we don't call rcu_user_exit()

Re: [PATCH 6/6] x86: Exit RCU extended QS on notify resume

2012-07-09 Thread Frederic Weisbecker
On Fri, Jul 06, 2012 at 09:33:38AM -0700, Paul E. McKenney wrote: On Fri, Jul 06, 2012 at 02:00:18PM +0200, Frederic Weisbecker wrote: do_notify_resume() may be called on irq exit but it won't be protected between rcu_irq_enter() and rcu_irq_exit() and we don't call rcu_user_exit() on irq

Re: [PATCH 6/6] x86: Exit RCU extended QS on notify resume

2012-07-06 Thread Josh Triplett
On Fri, Jul 06, 2012 at 09:33:38AM -0700, Paul E. McKenney wrote: > On Fri, Jul 06, 2012 at 02:00:18PM +0200, Frederic Weisbecker wrote: > > --- a/arch/x86/Kconfig > > +++ b/arch/x86/Kconfig > > @@ -95,6 +95,7 @@ config X86 > > select KTIME_SCALAR if X86_32 > > select

Re: [PATCH 6/6] x86: Exit RCU extended QS on notify resume

2012-07-06 Thread Paul E. McKenney
On Fri, Jul 06, 2012 at 02:00:18PM +0200, Frederic Weisbecker wrote: > do_notify_resume() may be called on irq exit but it won't > be protected between rcu_irq_enter() and rcu_irq_exit() > and we don't call rcu_user_exit() on irq entry (unlike > syscalls/exceptions entry). > > Since it can use

Re: [PATCH 6/6] x86: Exit RCU extended QS on notify resume

2012-07-06 Thread Paul E. McKenney
On Fri, Jul 06, 2012 at 02:00:18PM +0200, Frederic Weisbecker wrote: do_notify_resume() may be called on irq exit but it won't be protected between rcu_irq_enter() and rcu_irq_exit() and we don't call rcu_user_exit() on irq entry (unlike syscalls/exceptions entry). Since it can use RCU read

Re: [PATCH 6/6] x86: Exit RCU extended QS on notify resume

2012-07-06 Thread Josh Triplett
On Fri, Jul 06, 2012 at 09:33:38AM -0700, Paul E. McKenney wrote: On Fri, Jul 06, 2012 at 02:00:18PM +0200, Frederic Weisbecker wrote: --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -95,6 +95,7 @@ config X86 select KTIME_SCALAR if X86_32 select GENERIC_STRNCPY_FROM_USER