Re: [PATCH 6/9] perf tools: Don't search for active kernel start in __machine__create_kernel_maps

Hi Arnaldo, On Mon, Feb 19, 2018 at 9:21 PM, Arnaldo Carvalho de Melo wrote: > Em Mon, Feb 19, 2018 at 11:20:36AM +0900, Namhyung Kim escreveu: >> On Thu, Feb 15, 2018 at 01:26:32PM +0100, Jiri Olsa wrote: >> > if (!machine__get_running_kernel_start(machine, , )) { >> >

Re: [PATCH 6/9] perf tools: Don't search for active kernel start in __machine__create_kernel_maps

Hi Arnaldo, On Mon, Feb 19, 2018 at 9:21 PM, Arnaldo Carvalho de Melo wrote: > Em Mon, Feb 19, 2018 at 11:20:36AM +0900, Namhyung Kim escreveu: >> On Thu, Feb 15, 2018 at 01:26:32PM +0100, Jiri Olsa wrote: >> > if (!machine__get_running_kernel_start(machine, , )) { >> > if (name

Re: [PATCH 6/9] perf tools: Don't search for active kernel start in __machine__create_kernel_maps

Em Mon, Feb 19, 2018 at 11:20:36AM +0900, Namhyung Kim escreveu: > On Thu, Feb 15, 2018 at 01:26:32PM +0100, Jiri Olsa wrote: > > if (!machine__get_running_kernel_start(machine, , )) { > > if (name && > > maps__set_kallsyms_ref_reloc_sym(machine->vmlinux_maps, > >

Re: [PATCH 6/9] perf tools: Don't search for active kernel start in __machine__create_kernel_maps

Em Mon, Feb 19, 2018 at 11:20:36AM +0900, Namhyung Kim escreveu: > On Thu, Feb 15, 2018 at 01:26:32PM +0100, Jiri Olsa wrote: > > if (!machine__get_running_kernel_start(machine, , )) { > > if (name && > > maps__set_kallsyms_ref_reloc_sym(machine->vmlinux_maps, > >

Re: [PATCH 6/9] perf tools: Don't search for active kernel start in __machine__create_kernel_maps

Em Mon, Feb 19, 2018 at 11:49:44AM +0100, Jiri Olsa escreveu: > On Mon, Feb 19, 2018 at 07:19:36PM +0900, Namhyung Kim wrote: > > SNIP > > > From b736729e83b62f97d716a011ccf4e430b614fecd Mon Sep 17 00:00:00 2001 > > From: Namhyung Kim > > Date: Mon, 19 Feb 2018 19:00:46

Re: [PATCH 6/9] perf tools: Don't search for active kernel start in __machine__create_kernel_maps

Em Mon, Feb 19, 2018 at 11:49:44AM +0100, Jiri Olsa escreveu: > On Mon, Feb 19, 2018 at 07:19:36PM +0900, Namhyung Kim wrote: > > SNIP > > > From b736729e83b62f97d716a011ccf4e430b614fecd Mon Sep 17 00:00:00 2001 > > From: Namhyung Kim > > Date: Mon, 19 Feb 2018 19:00:46 +0900 > > Subject:

Re: [PATCH 6/9] perf tools: Don't search for active kernel start in __machine__create_kernel_maps

On Mon, Feb 19, 2018 at 07:19:36PM +0900, Namhyung Kim wrote: SNIP > From b736729e83b62f97d716a011ccf4e430b614fecd Mon Sep 17 00:00:00 2001 > From: Namhyung Kim > Date: Mon, 19 Feb 2018 19:00:46 +0900 > Subject: [PATCH] perf tools: Fix paranoid check in

Re: [PATCH 6/9] perf tools: Don't search for active kernel start in __machine__create_kernel_maps

On Mon, Feb 19, 2018 at 07:19:36PM +0900, Namhyung Kim wrote: SNIP > From b736729e83b62f97d716a011ccf4e430b614fecd Mon Sep 17 00:00:00 2001 > From: Namhyung Kim > Date: Mon, 19 Feb 2018 19:00:46 +0900 > Subject: [PATCH] perf tools: Fix paranoid check in machine__set_kernel_mmap() > > The

Re: [PATCH 6/9] perf tools: Don't search for active kernel start in __machine__create_kernel_maps

On Mon, Feb 19, 2018 at 11:01:40AM +0100, Jiri Olsa wrote: > On Mon, Feb 19, 2018 at 11:20:36AM +0900, Namhyung Kim wrote: > > SNIP > > > > +static void machine__set_kernel_mmap(struct machine *machine, > > > + u64 start, u64 end) > > > +{ > > > + int i; > > > + > >

Re: [PATCH 6/9] perf tools: Don't search for active kernel start in __machine__create_kernel_maps

On Mon, Feb 19, 2018 at 11:01:40AM +0100, Jiri Olsa wrote: > On Mon, Feb 19, 2018 at 11:20:36AM +0900, Namhyung Kim wrote: > > SNIP > > > > +static void machine__set_kernel_mmap(struct machine *machine, > > > + u64 start, u64 end) > > > +{ > > > + int i; > > > + > >

Re: [PATCH 6/9] perf tools: Don't search for active kernel start in __machine__create_kernel_maps

On Mon, Feb 19, 2018 at 11:20:36AM +0900, Namhyung Kim wrote: SNIP > > +static void machine__set_kernel_mmap(struct machine *machine, > > +u64 start, u64 end) > > +{ > > + int i; > > + > > + for (i = 0; i < MAP__NR_TYPES; i++) { > > +

Re: [PATCH 6/9] perf tools: Don't search for active kernel start in __machine__create_kernel_maps

On Mon, Feb 19, 2018 at 11:20:36AM +0900, Namhyung Kim wrote: SNIP > > +static void machine__set_kernel_mmap(struct machine *machine, > > +u64 start, u64 end) > > +{ > > + int i; > > + > > + for (i = 0; i < MAP__NR_TYPES; i++) { > > +

Re: [PATCH 6/9] perf tools: Don't search for active kernel start in __machine__create_kernel_maps

Hi Jiri and Arnaldo, On Thu, Feb 15, 2018 at 01:26:32PM +0100, Jiri Olsa wrote: > We should not search for kernel start address in > __machine__create_kernel_maps function, because it's being > used in 'report' code path, where we are interested in kernel > MMAP data address instead of in current

Re: [PATCH 6/9] perf tools: Don't search for active kernel start in __machine__create_kernel_maps

Hi Jiri and Arnaldo, On Thu, Feb 15, 2018 at 01:26:32PM +0100, Jiri Olsa wrote: > We should not search for kernel start address in > __machine__create_kernel_maps function, because it's being > used in 'report' code path, where we are interested in kernel > MMAP data address instead of in current