Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 14 mag 2018, alle ore 19:31, Jens Axboe ha > scritto: > > On 5/14/18 11:16 AM, Paolo Valente wrote: >> >> >>> Il giorno 10 mag 2018, alle ore 18:14, Bart Van Assche >>> ha scritto: >>> >>> On Fri, 2018-05-04 at 19:17 +0200, Paolo

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 14 mag 2018, alle ore 19:31, Jens Axboe ha > scritto: > > On 5/14/18 11:16 AM, Paolo Valente wrote: >> >> >>> Il giorno 10 mag 2018, alle ore 18:14, Bart Van Assche >>> ha scritto: >>> >>> On Fri, 2018-05-04 at 19:17 +0200, Paolo Valente wrote: When invoked for an I/O

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

On 5/14/18 11:16 AM, Paolo Valente wrote: > > >> Il giorno 10 mag 2018, alle ore 18:14, Bart Van Assche >> ha scritto: >> >> On Fri, 2018-05-04 at 19:17 +0200, Paolo Valente wrote: >>> When invoked for an I/O request rq, [ ... ] >> >> Tested-by: Bart Van Assche

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

On 5/14/18 11:16 AM, Paolo Valente wrote: > > >> Il giorno 10 mag 2018, alle ore 18:14, Bart Van Assche >> ha scritto: >> >> On Fri, 2018-05-04 at 19:17 +0200, Paolo Valente wrote: >>> When invoked for an I/O request rq, [ ... ] >> >> Tested-by: Bart Van Assche >> >> >> > > Any decision for

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 10 mag 2018, alle ore 18:14, Bart Van Assche > ha scritto: > > On Fri, 2018-05-04 at 19:17 +0200, Paolo Valente wrote: >> When invoked for an I/O request rq, [ ... ] > > Tested-by: Bart Van Assche > > > Any decision for this

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 10 mag 2018, alle ore 18:14, Bart Van Assche > ha scritto: > > On Fri, 2018-05-04 at 19:17 +0200, Paolo Valente wrote: >> When invoked for an I/O request rq, [ ... ] > > Tested-by: Bart Van Assche > > > Any decision for this fix, Jens? Thanks, Paolo

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

On Fri, 2018-05-04 at 19:17 +0200, Paolo Valente wrote: > When invoked for an I/O request rq, [ ... ] Tested-by: Bart Van Assche

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

On Fri, 2018-05-04 at 19:17 +0200, Paolo Valente wrote: > When invoked for an I/O request rq, [ ... ] Tested-by: Bart Van Assche

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 07 mag 2018, alle ore 12:01, Mike Galbraith ha > scritto: > > On Mon, 2018-05-07 at 11:27 +0200, Paolo Valente wrote: >> >> >> Where is the bug? > > Hm, seems potent pain-killers and C don't mix all that well. > I'll try to keep it in mind, and I do wis you to

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 07 mag 2018, alle ore 12:01, Mike Galbraith ha > scritto: > > On Mon, 2018-05-07 at 11:27 +0200, Paolo Valente wrote: >> >> >> Where is the bug? > > Hm, seems potent pain-killers and C don't mix all that well. > I'll try to keep it in mind, and I do wis you to get well soon.

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

On Mon, 2018-05-07 at 11:27 +0200, Paolo Valente wrote: > > > Where is the bug? Hm, seems potent pain-killers and C don't mix all that well.

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

On Mon, 2018-05-07 at 11:27 +0200, Paolo Valente wrote: > > > Where is the bug? Hm, seems potent pain-killers and C don't mix all that well.

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 07 mag 2018, alle ore 05:23, Mike Galbraith ha > scritto: > > On Mon, 2018-05-07 at 04:43 +0200, Mike Galbraith wrote: >> On Sun, 2018-05-06 at 09:42 +0200, Paolo Valente wrote: >>> >>> I've attached a compressed patch (to avoid possible corruption from my >>>

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 07 mag 2018, alle ore 05:23, Mike Galbraith ha > scritto: > > On Mon, 2018-05-07 at 04:43 +0200, Mike Galbraith wrote: >> On Sun, 2018-05-06 at 09:42 +0200, Paolo Valente wrote: >>> >>> I've attached a compressed patch (to avoid possible corruption from my >>> mailer). I'm

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 07 mag 2018, alle ore 07:56, Mike Galbraith ha > scritto: > > On Sun, 2018-05-06 at 09:42 +0200, Paolo Valente wrote: >> >> diff --git a/block/bfq-mq-iosched.c b/block/bfq-mq-iosched.c >> index 118f319af7c0..6662efe29b69 100644 >> --- a/block/bfq-mq-iosched.c >>

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 07 mag 2018, alle ore 07:56, Mike Galbraith ha > scritto: > > On Sun, 2018-05-06 at 09:42 +0200, Paolo Valente wrote: >> >> diff --git a/block/bfq-mq-iosched.c b/block/bfq-mq-iosched.c >> index 118f319af7c0..6662efe29b69 100644 >> --- a/block/bfq-mq-iosched.c >> +++

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

On Sun, 2018-05-06 at 09:42 +0200, Paolo Valente wrote: > > diff --git a/block/bfq-mq-iosched.c b/block/bfq-mq-iosched.c > index 118f319af7c0..6662efe29b69 100644 > --- a/block/bfq-mq-iosched.c > +++ b/block/bfq-mq-iosched.c > @@ -525,8 +525,13 @@ static void bfq_limit_depth(unsigned int op,

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

On Sun, 2018-05-06 at 09:42 +0200, Paolo Valente wrote: > > diff --git a/block/bfq-mq-iosched.c b/block/bfq-mq-iosched.c > index 118f319af7c0..6662efe29b69 100644 > --- a/block/bfq-mq-iosched.c > +++ b/block/bfq-mq-iosched.c > @@ -525,8 +525,13 @@ static void bfq_limit_depth(unsigned int op,

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

On Mon, 2018-05-07 at 04:43 +0200, Mike Galbraith wrote: > On Sun, 2018-05-06 at 09:42 +0200, Paolo Valente wrote: > > > > I've attached a compressed patch (to avoid possible corruption from my > > mailer). I'm little confident, but no pain, no gain, right? > > > > If possible, apply this patch

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

On Mon, 2018-05-07 at 04:43 +0200, Mike Galbraith wrote: > On Sun, 2018-05-06 at 09:42 +0200, Paolo Valente wrote: > > > > I've attached a compressed patch (to avoid possible corruption from my > > mailer). I'm little confident, but no pain, no gain, right? > > > > If possible, apply this patch

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

On Sun, 2018-05-06 at 09:42 +0200, Paolo Valente wrote: > > I've attached a compressed patch (to avoid possible corruption from my > mailer). I'm little confident, but no pain, no gain, right? > > If possible, apply this patch on top of the fix I proposed in this > thread, just to eliminate

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

On Sun, 2018-05-06 at 09:42 +0200, Paolo Valente wrote: > > I've attached a compressed patch (to avoid possible corruption from my > mailer). I'm little confident, but no pain, no gain, right? > > If possible, apply this patch on top of the fix I proposed in this > thread, just to eliminate

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 05 mag 2018, alle ore 16:56, Mike Galbraith ha > scritto: > > On Sat, 2018-05-05 at 12:39 +0200, Paolo Valente wrote: >> >> BTW, if you didn't run out of patience with this permanent issue yet, >> I was thinking of two o three changes to retry to trigger your

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 05 mag 2018, alle ore 16:56, Mike Galbraith ha > scritto: > > On Sat, 2018-05-05 at 12:39 +0200, Paolo Valente wrote: >> >> BTW, if you didn't run out of patience with this permanent issue yet, >> I was thinking of two o three changes to retry to trigger your failure >> reliably.

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

Hi. On 04.05.2018 19:17, Paolo Valente wrote: When invoked for an I/O request rq, the prepare_request hook of bfq increments reference counters in the destination bfq_queue for rq. In this respect, after this hook has been invoked, rq may still be transformed into a request with no icq

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

Hi. On 04.05.2018 19:17, Paolo Valente wrote: When invoked for an I/O request rq, the prepare_request hook of bfq increments reference counters in the destination bfq_queue for rq. In this respect, after this hook has been invoked, rq may still be transformed into a request with no icq

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

On Sat, 2018-05-05 at 12:39 +0200, Paolo Valente wrote: > > BTW, if you didn't run out of patience with this permanent issue yet, > I was thinking of two o three changes to retry to trigger your failure > reliably. Sure, fire away, I'll happily give the annoying little bugger opportunities to

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

On Sat, 2018-05-05 at 12:39 +0200, Paolo Valente wrote: > > BTW, if you didn't run out of patience with this permanent issue yet, > I was thinking of two o three changes to retry to trigger your failure > reliably. Sure, fire away, I'll happily give the annoying little bugger opportunities to

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 05 mag 2018, alle ore 10:19, Mike Galbraith ha > scritto: > > On Fri, 2018-05-04 at 21:46 +0200, Mike Galbraith wrote: >> Tentatively, I suspect you've just fixed the nasty stalls I reported a >> while back. > > Oh well, so much for optimism. It took a lot, but

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 05 mag 2018, alle ore 10:19, Mike Galbraith ha > scritto: > > On Fri, 2018-05-04 at 21:46 +0200, Mike Galbraith wrote: >> Tentatively, I suspect you've just fixed the nasty stalls I reported a >> while back. > > Oh well, so much for optimism. It took a lot, but just hung. Yep,

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

On Fri, 2018-05-04 at 21:46 +0200, Mike Galbraith wrote: > Tentatively, I suspect you've just fixed the nasty stalls I reported a > while back. Oh well, so much for optimism. It took a lot, but just hung.

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

On Fri, 2018-05-04 at 21:46 +0200, Mike Galbraith wrote: > Tentatively, I suspect you've just fixed the nasty stalls I reported a > while back. Oh well, so much for optimism. It took a lot, but just hung.

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

Tentatively, I suspect you've just fixed the nasty stalls I reported a while back. Not a hint of stall as yet (should have shown itself by now), spinning rust buckets are being all they can be, box feels good. Later mq-deadline (I hope to eventually forget the module dependency eternities we've

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

Tentatively, I suspect you've just fixed the nasty stalls I reported a while back. Not a hint of stall as yet (should have shown itself by now), spinning rust buckets are being all they can be, box feels good. Later mq-deadline (I hope to eventually forget the module dependency eternities we've