Re: [PATCH RFC] checkpatch: fix multi-statement macro checks

2020-10-01 Thread Dwaipayan Ray
> > All I'm trying to point out to you is that $Constant\s*$Constant > > isn't a proper test as the first $Constant will pull the test > > entire sequence of digits and the second $Constant will not be > > met. > > > > It may take some conversion of the collapsing of the dstat > > block to work

Re: [PATCH RFC] checkpatch: fix multi-statement macro checks

2020-10-01 Thread Joe Perches
On Thu, 2020-10-01 at 07:38 -0700, Joe Perches wrote: > On Thu, 2020-10-01 at 19:44 +0530, Dwaipayan Ray wrote: > > On Thu, Oct 1, 2020 at 7:12 PM Joe Perches wrote: > > > On Thu, 2020-10-01 at 18:57 +0530, Dwaipayan Ray wrote: > > > > On Thu, Oct 1, 2020 at 6:47 PM Joe Perches wrote: > > > > >

Re: [PATCH RFC] checkpatch: fix multi-statement macro checks

2020-10-01 Thread Joe Perches
On Thu, 2020-10-01 at 19:44 +0530, Dwaipayan Ray wrote: > On Thu, Oct 1, 2020 at 7:12 PM Joe Perches wrote: > > On Thu, 2020-10-01 at 18:57 +0530, Dwaipayan Ray wrote: > > > On Thu, Oct 1, 2020 at 6:47 PM Joe Perches wrote: > > > > On Thu, 2020-10-01 at 16:03 +0530, Dwaipayan Ray wrote: > > > >

Re: [PATCH RFC] checkpatch: fix multi-statement macro checks

2020-10-01 Thread Dwaipayan Ray
On Thu, Oct 1, 2020 at 7:12 PM Joe Perches wrote: > > On Thu, 2020-10-01 at 18:57 +0530, Dwaipayan Ray wrote: > > On Thu, Oct 1, 2020 at 6:47 PM Joe Perches wrote: > > > On Thu, 2020-10-01 at 16:03 +0530, Dwaipayan Ray wrote: > > > > Checkpatch.pl doesn't have a check for excluding while (...)

Re: [PATCH RFC] checkpatch: fix multi-statement macro checks

2020-10-01 Thread Joe Perches
On Thu, 2020-10-01 at 18:57 +0530, Dwaipayan Ray wrote: > On Thu, Oct 1, 2020 at 6:47 PM Joe Perches wrote: > > On Thu, 2020-10-01 at 16:03 +0530, Dwaipayan Ray wrote: > > > Checkpatch.pl doesn't have a check for excluding while (...) {...} > > > blocks from MULTISTATEMENT_MACRO_USE_DO_WHILE

Re: [PATCH RFC] checkpatch: fix multi-statement macro checks

2020-10-01 Thread Dwaipayan Ray
On Thu, Oct 1, 2020 at 6:47 PM Joe Perches wrote: > > On Thu, 2020-10-01 at 16:03 +0530, Dwaipayan Ray wrote: > > Checkpatch.pl doesn't have a check for excluding while (...) {...} > > blocks from MULTISTATEMENT_MACRO_USE_DO_WHILE error. > > > > For example, running checkpatch.pl on the file

Re: [PATCH RFC] checkpatch: fix multi-statement macro checks

2020-10-01 Thread Joe Perches
On Thu, 2020-10-01 at 16:03 +0530, Dwaipayan Ray wrote: > Checkpatch.pl doesn't have a check for excluding while (...) {...} > blocks from MULTISTATEMENT_MACRO_USE_DO_WHILE error. > > For example, running checkpatch.pl on the file mm/access.c in the > kernel generates the following error: > >

Re: [PATCH RFC] checkpatch: fix multi-statement macro checks

2020-10-01 Thread Lukas Bulwahn
On Thu, 1 Oct 2020, Dwaipayan Ray wrote: > Checkpatch.pl doesn't have a check for excluding while (...) {...} > blocks from MULTISTATEMENT_MACRO_USE_DO_WHILE error. > > For example, running checkpatch.pl on the file mm/access.c in the > kernel generates the following error: > > ERROR: Macros