Re: [PATCH RFC 1/8] rcu: Add comment documenting how rcu_seq_snap works

On Wed, May 16, 2018 at 08:45:43AM -0700, Paul E. McKenney wrote: [...] > > > > The code would be correct then, but one issue is it would shout out the > > > > 'Prestarted' tracepoint for 'c' when that's not really true.. > > > > > > > >rcu_seq_done(_root->gp_seq, c) > > > > > >

Re: [PATCH RFC 1/8] rcu: Add comment documenting how rcu_seq_snap works

On Wed, May 16, 2018 at 08:45:43AM -0700, Paul E. McKenney wrote: [...] > > > > The code would be correct then, but one issue is it would shout out the > > > > 'Prestarted' tracepoint for 'c' when that's not really true.. > > > > > > > >rcu_seq_done(_root->gp_seq, c) > > > > > >

Re: [PATCH RFC 1/8] rcu: Add comment documenting how rcu_seq_snap works

On Tue, May 15, 2018 at 03:55:09PM -0700, Joel Fernandes wrote: > On Tue, May 15, 2018 at 12:08:01PM -0700, Paul E. McKenney wrote: > > On Tue, May 15, 2018 at 11:41:15AM -0700, Joel Fernandes wrote: > > > On Tue, May 15, 2018 at 05:55:07AM -0700, Paul E. McKenney wrote: > > > > On Tue, May 15,

Re: [PATCH RFC 1/8] rcu: Add comment documenting how rcu_seq_snap works

On Tue, May 15, 2018 at 03:55:09PM -0700, Joel Fernandes wrote: > On Tue, May 15, 2018 at 12:08:01PM -0700, Paul E. McKenney wrote: > > On Tue, May 15, 2018 at 11:41:15AM -0700, Joel Fernandes wrote: > > > On Tue, May 15, 2018 at 05:55:07AM -0700, Paul E. McKenney wrote: > > > > On Tue, May 15,

Re: [PATCH RFC 1/8] rcu: Add comment documenting how rcu_seq_snap works

On Tue, May 15, 2018 at 12:08:01PM -0700, Paul E. McKenney wrote: > On Tue, May 15, 2018 at 11:41:15AM -0700, Joel Fernandes wrote: > > On Tue, May 15, 2018 at 05:55:07AM -0700, Paul E. McKenney wrote: > > > On Tue, May 15, 2018 at 12:02:43AM -0700, Joel Fernandes wrote: > > > > Hi Paul, > > > >

Re: [PATCH RFC 1/8] rcu: Add comment documenting how rcu_seq_snap works

On Tue, May 15, 2018 at 12:08:01PM -0700, Paul E. McKenney wrote: > On Tue, May 15, 2018 at 11:41:15AM -0700, Joel Fernandes wrote: > > On Tue, May 15, 2018 at 05:55:07AM -0700, Paul E. McKenney wrote: > > > On Tue, May 15, 2018 at 12:02:43AM -0700, Joel Fernandes wrote: > > > > Hi Paul, > > > >

Re: [PATCH RFC 1/8] rcu: Add comment documenting how rcu_seq_snap works

On Tue, May 15, 2018 at 11:41:15AM -0700, Joel Fernandes wrote: > On Tue, May 15, 2018 at 05:55:07AM -0700, Paul E. McKenney wrote: > > On Tue, May 15, 2018 at 12:02:43AM -0700, Joel Fernandes wrote: > > > Hi Paul, > > > Good morning, hope you're having a great Tuesday. I managed to find some > >

Re: [PATCH RFC 1/8] rcu: Add comment documenting how rcu_seq_snap works

On Tue, May 15, 2018 at 11:41:15AM -0700, Joel Fernandes wrote: > On Tue, May 15, 2018 at 05:55:07AM -0700, Paul E. McKenney wrote: > > On Tue, May 15, 2018 at 12:02:43AM -0700, Joel Fernandes wrote: > > > Hi Paul, > > > Good morning, hope you're having a great Tuesday. I managed to find some > >

Re: [PATCH RFC 1/8] rcu: Add comment documenting how rcu_seq_snap works

On Tue, May 15, 2018 at 05:55:07AM -0700, Paul E. McKenney wrote: > On Tue, May 15, 2018 at 12:02:43AM -0700, Joel Fernandes wrote: > > Hi Paul, > > Good morning, hope you're having a great Tuesday. I managed to find some > > evening hours today to dig into this a bit more. > > > > On Mon, May

Re: [PATCH RFC 1/8] rcu: Add comment documenting how rcu_seq_snap works

On Tue, May 15, 2018 at 05:55:07AM -0700, Paul E. McKenney wrote: > On Tue, May 15, 2018 at 12:02:43AM -0700, Joel Fernandes wrote: > > Hi Paul, > > Good morning, hope you're having a great Tuesday. I managed to find some > > evening hours today to dig into this a bit more. > > > > On Mon, May

Re: [PATCH RFC 1/8] rcu: Add comment documenting how rcu_seq_snap works

On Tue, May 15, 2018 at 12:02:43AM -0700, Joel Fernandes wrote: > Hi Paul, > Good morning, hope you're having a great Tuesday. I managed to find some > evening hours today to dig into this a bit more. > > On Mon, May 14, 2018 at 08:59:52PM -0700, Paul E. McKenney wrote: > > On Mon, May 14, 2018

Re: [PATCH RFC 1/8] rcu: Add comment documenting how rcu_seq_snap works

On Tue, May 15, 2018 at 12:02:43AM -0700, Joel Fernandes wrote: > Hi Paul, > Good morning, hope you're having a great Tuesday. I managed to find some > evening hours today to dig into this a bit more. > > On Mon, May 14, 2018 at 08:59:52PM -0700, Paul E. McKenney wrote: > > On Mon, May 14, 2018

Re: [PATCH RFC 1/8] rcu: Add comment documenting how rcu_seq_snap works

Hi Paul, Good morning, hope you're having a great Tuesday. I managed to find some evening hours today to dig into this a bit more. On Mon, May 14, 2018 at 08:59:52PM -0700, Paul E. McKenney wrote: > On Mon, May 14, 2018 at 06:51:33PM -0700, Joel Fernandes wrote: > > On Mon, May 14, 2018 at

Re: [PATCH RFC 1/8] rcu: Add comment documenting how rcu_seq_snap works

Hi Paul, Good morning, hope you're having a great Tuesday. I managed to find some evening hours today to dig into this a bit more. On Mon, May 14, 2018 at 08:59:52PM -0700, Paul E. McKenney wrote: > On Mon, May 14, 2018 at 06:51:33PM -0700, Joel Fernandes wrote: > > On Mon, May 14, 2018 at

Re: [PATCH RFC 1/8] rcu: Add comment documenting how rcu_seq_snap works

On Mon, May 14, 2018 at 06:51:33PM -0700, Joel Fernandes wrote: > On Mon, May 14, 2018 at 10:38:16AM -0700, Paul E. McKenney wrote: > > On Sun, May 13, 2018 at 08:15:34PM -0700, Joel Fernandes (Google) wrote: > > > rcu_seq_snap may be tricky for someone looking at it for the first time. > > > Lets

Re: [PATCH RFC 1/8] rcu: Add comment documenting how rcu_seq_snap works

On Mon, May 14, 2018 at 06:51:33PM -0700, Joel Fernandes wrote: > On Mon, May 14, 2018 at 10:38:16AM -0700, Paul E. McKenney wrote: > > On Sun, May 13, 2018 at 08:15:34PM -0700, Joel Fernandes (Google) wrote: > > > rcu_seq_snap may be tricky for someone looking at it for the first time. > > > Lets

Re: [PATCH RFC 1/8] rcu: Add comment documenting how rcu_seq_snap works

On Mon, May 14, 2018 at 10:38:16AM -0700, Paul E. McKenney wrote: > On Sun, May 13, 2018 at 08:15:34PM -0700, Joel Fernandes (Google) wrote: > > rcu_seq_snap may be tricky for someone looking at it for the first time. > > Lets document how it works with an example to make it easier. > > > >

Re: [PATCH RFC 1/8] rcu: Add comment documenting how rcu_seq_snap works

On Mon, May 14, 2018 at 10:38:16AM -0700, Paul E. McKenney wrote: > On Sun, May 13, 2018 at 08:15:34PM -0700, Joel Fernandes (Google) wrote: > > rcu_seq_snap may be tricky for someone looking at it for the first time. > > Lets document how it works with an example to make it easier. > > > >

Re: [PATCH RFC 1/8] rcu: Add comment documenting how rcu_seq_snap works

On Sun, May 13, 2018 at 08:15:34PM -0700, Joel Fernandes (Google) wrote: > rcu_seq_snap may be tricky for someone looking at it for the first time. > Lets document how it works with an example to make it easier. > > Signed-off-by: Joel Fernandes (Google) > --- >

Re: [PATCH RFC 1/8] rcu: Add comment documenting how rcu_seq_snap works

On Sun, May 13, 2018 at 08:15:34PM -0700, Joel Fernandes (Google) wrote: > rcu_seq_snap may be tricky for someone looking at it for the first time. > Lets document how it works with an example to make it easier. > > Signed-off-by: Joel Fernandes (Google) > --- > kernel/rcu/rcu.h | 24

Re: [PATCH RFC 1/8] rcu: Add comment documenting how rcu_seq_snap works

On Sun, May 13, 2018 at 08:47:24PM -0700, Randy Dunlap wrote: > On 05/13/2018 08:15 PM, Joel Fernandes (Google) wrote: > > rcu_seq_snap may be tricky for someone looking at it for the first time. > > Lets document how it works with an example to make it easier. > > > > Signed-off-by: Joel

Re: [PATCH RFC 1/8] rcu: Add comment documenting how rcu_seq_snap works

On Sun, May 13, 2018 at 08:47:24PM -0700, Randy Dunlap wrote: > On 05/13/2018 08:15 PM, Joel Fernandes (Google) wrote: > > rcu_seq_snap may be tricky for someone looking at it for the first time. > > Lets document how it works with an example to make it easier. > > > > Signed-off-by: Joel

Re: [PATCH RFC 1/8] rcu: Add comment documenting how rcu_seq_snap works

On 05/13/2018 08:15 PM, Joel Fernandes (Google) wrote: > rcu_seq_snap may be tricky for someone looking at it for the first time. > Lets document how it works with an example to make it easier. > > Signed-off-by: Joel Fernandes (Google) > --- > kernel/rcu/rcu.h | 24

Re: [PATCH RFC 1/8] rcu: Add comment documenting how rcu_seq_snap works

On 05/13/2018 08:15 PM, Joel Fernandes (Google) wrote: > rcu_seq_snap may be tricky for someone looking at it for the first time. > Lets document how it works with an example to make it easier. > > Signed-off-by: Joel Fernandes (Google) > --- > kernel/rcu/rcu.h | 24 +++- >