Re: [PATCH V2] x86/kexec: fix a kexec_file_load failure

2019-01-14 Thread Dave Young
On 12/28/18 at 09:12am, Dave Young wrote: > The code cleanup mentioned in Fixes tag changed the behavior of > kexec_locate_mem_hole. The kexec_locate_mem_hole will try to > allocate free memory only when kbuf.mem is initialized as zero. > > But in x86 kexec_file_load implementation there are a

Re: [PATCH V2] x86/kexec: fix a kexec_file_load failure

2019-01-08 Thread Dave Young
On 01/08/19 at 04:51pm, Baoquan He wrote: > On 01/08/19 at 04:46pm, Dave Young wrote: > > > Wondering why this place doesn't need the initialization assignment. > > > Isn't it to assign in all places before kexec_add_buffer() calling? > > > > C designated initializers will make sure to initialize

Re: [PATCH V2] x86/kexec: fix a kexec_file_load failure

2019-01-08 Thread Baoquan He
On 01/08/19 at 04:46pm, Dave Young wrote: > > Wondering why this place doesn't need the initialization assignment. > > Isn't it to assign in all places before kexec_add_buffer() calling? > > C designated initializers will make sure to initialize it as zero. > We set KEXEC_BUF_MEM_UNKNOWN as 0 so

Re: [PATCH V2] x86/kexec: fix a kexec_file_load failure

2019-01-08 Thread Dave Young
On 01/08/19 at 01:24pm, Baoquan He wrote: > On 12/28/18 at 09:12am, Dave Young wrote: > > The code cleanup mentioned in Fixes tag changed the behavior of > > kexec_locate_mem_hole. The kexec_locate_mem_hole will try to > > allocate free memory only when kbuf.mem is initialized as zero. > > > >

Re: [PATCH V2] x86/kexec: fix a kexec_file_load failure

2019-01-07 Thread Baoquan He
On 12/28/18 at 09:12am, Dave Young wrote: > The code cleanup mentioned in Fixes tag changed the behavior of > kexec_locate_mem_hole. The kexec_locate_mem_hole will try to > allocate free memory only when kbuf.mem is initialized as zero. > > But in x86 kexec_file_load implementation there are a

Re: [PATCH V2] x86/kexec: fix a kexec_file_load failure

2019-01-07 Thread Dave Young
On 12/28/18 at 09:12am, Dave Young wrote: > The code cleanup mentioned in Fixes tag changed the behavior of > kexec_locate_mem_hole. The kexec_locate_mem_hole will try to > allocate free memory only when kbuf.mem is initialized as zero. > > But in x86 kexec_file_load implementation there are a