Re: [PATCH V3 04/10] sched/core: Prevent race condition between cpuset and __sched_setscheduler()

2018-02-15 Thread Juri Lelli
On 15/02/18 11:33, Juri Lelli wrote: > On 14/02/18 17:31, Juri Lelli wrote: > > [...] > > > Still grabbing it is a no-go, as do_sched_setscheduler calls > > sched_setscheduler from inside an RCU read-side critical section. > > I was then actually thinking that trylocking might do.. not sure

Re: [PATCH V3 04/10] sched/core: Prevent race condition between cpuset and __sched_setscheduler()

2018-02-15 Thread Juri Lelli
On 15/02/18 11:33, Juri Lelli wrote: > On 14/02/18 17:31, Juri Lelli wrote: > > [...] > > > Still grabbing it is a no-go, as do_sched_setscheduler calls > > sched_setscheduler from inside an RCU read-side critical section. > > I was then actually thinking that trylocking might do.. not sure

Re: [PATCH V3 04/10] sched/core: Prevent race condition between cpuset and __sched_setscheduler()

2018-02-15 Thread Juri Lelli
On 14/02/18 17:31, Juri Lelli wrote: [...] > Still grabbing it is a no-go, as do_sched_setscheduler calls > sched_setscheduler from inside an RCU read-side critical section. I was then actually thinking that trylocking might do.. not sure however if failing with -EBUSY in the contended case is

Re: [PATCH V3 04/10] sched/core: Prevent race condition between cpuset and __sched_setscheduler()

2018-02-15 Thread Juri Lelli
On 14/02/18 17:31, Juri Lelli wrote: [...] > Still grabbing it is a no-go, as do_sched_setscheduler calls > sched_setscheduler from inside an RCU read-side critical section. I was then actually thinking that trylocking might do.. not sure however if failing with -EBUSY in the contended case is

Re: [PATCH V3 04/10] sched/core: Prevent race condition between cpuset and __sched_setscheduler()

2018-02-14 Thread Juri Lelli
On 14/02/18 08:33, Mathieu Poirier wrote: > On 14 February 2018 at 04:27, Juri Lelli wrote: > > On 14/02/18 11:49, Juri Lelli wrote: > >> On 14/02/18 11:36, Juri Lelli wrote: > >> > Hi Mathieu, > >> > > >> > On 13/02/18 13:32, Mathieu Poirier wrote: > >> > > No

Re: [PATCH V3 04/10] sched/core: Prevent race condition between cpuset and __sched_setscheduler()

2018-02-14 Thread Juri Lelli
On 14/02/18 08:33, Mathieu Poirier wrote: > On 14 February 2018 at 04:27, Juri Lelli wrote: > > On 14/02/18 11:49, Juri Lelli wrote: > >> On 14/02/18 11:36, Juri Lelli wrote: > >> > Hi Mathieu, > >> > > >> > On 13/02/18 13:32, Mathieu Poirier wrote: > >> > > No synchronisation mechanism exist

Re: [PATCH V3 04/10] sched/core: Prevent race condition between cpuset and __sched_setscheduler()

2018-02-14 Thread Mathieu Poirier
On 14 February 2018 at 04:27, Juri Lelli wrote: > On 14/02/18 11:49, Juri Lelli wrote: >> On 14/02/18 11:36, Juri Lelli wrote: >> > Hi Mathieu, >> > >> > On 13/02/18 13:32, Mathieu Poirier wrote: >> > > No synchronisation mechanism exist between the cpuset subsystem and

Re: [PATCH V3 04/10] sched/core: Prevent race condition between cpuset and __sched_setscheduler()

2018-02-14 Thread Mathieu Poirier
On 14 February 2018 at 04:27, Juri Lelli wrote: > On 14/02/18 11:49, Juri Lelli wrote: >> On 14/02/18 11:36, Juri Lelli wrote: >> > Hi Mathieu, >> > >> > On 13/02/18 13:32, Mathieu Poirier wrote: >> > > No synchronisation mechanism exist between the cpuset subsystem and calls >> > > to function

Re: [PATCH V3 04/10] sched/core: Prevent race condition between cpuset and __sched_setscheduler()

2018-02-14 Thread Juri Lelli
On 14/02/18 11:49, Juri Lelli wrote: > On 14/02/18 11:36, Juri Lelli wrote: > > Hi Mathieu, > > > > On 13/02/18 13:32, Mathieu Poirier wrote: > > > No synchronisation mechanism exist between the cpuset subsystem and calls > > > to function __sched_setscheduler(). As such it is possible that new

Re: [PATCH V3 04/10] sched/core: Prevent race condition between cpuset and __sched_setscheduler()

2018-02-14 Thread Juri Lelli
On 14/02/18 11:49, Juri Lelli wrote: > On 14/02/18 11:36, Juri Lelli wrote: > > Hi Mathieu, > > > > On 13/02/18 13:32, Mathieu Poirier wrote: > > > No synchronisation mechanism exist between the cpuset subsystem and calls > > > to function __sched_setscheduler(). As such it is possible that new

Re: [PATCH V3 04/10] sched/core: Prevent race condition between cpuset and __sched_setscheduler()

2018-02-14 Thread Juri Lelli
On 14/02/18 11:36, Juri Lelli wrote: > Hi Mathieu, > > On 13/02/18 13:32, Mathieu Poirier wrote: > > No synchronisation mechanism exist between the cpuset subsystem and calls > > to function __sched_setscheduler(). As such it is possible that new root > > domains are created on the cpuset side

Re: [PATCH V3 04/10] sched/core: Prevent race condition between cpuset and __sched_setscheduler()

2018-02-14 Thread Juri Lelli
On 14/02/18 11:36, Juri Lelli wrote: > Hi Mathieu, > > On 13/02/18 13:32, Mathieu Poirier wrote: > > No synchronisation mechanism exist between the cpuset subsystem and calls > > to function __sched_setscheduler(). As such it is possible that new root > > domains are created on the cpuset side

Re: [PATCH V3 04/10] sched/core: Prevent race condition between cpuset and __sched_setscheduler()

2018-02-14 Thread Juri Lelli
Hi Mathieu, On 13/02/18 13:32, Mathieu Poirier wrote: > No synchronisation mechanism exist between the cpuset subsystem and calls > to function __sched_setscheduler(). As such it is possible that new root > domains are created on the cpuset side while a deadline acceptance test > is carried out

Re: [PATCH V3 04/10] sched/core: Prevent race condition between cpuset and __sched_setscheduler()

2018-02-14 Thread Juri Lelli
Hi Mathieu, On 13/02/18 13:32, Mathieu Poirier wrote: > No synchronisation mechanism exist between the cpuset subsystem and calls > to function __sched_setscheduler(). As such it is possible that new root > domains are created on the cpuset side while a deadline acceptance test > is carried out