Re: [PATCH V4] livepatch: non static warnings fix

2019-01-27 Thread Nicholas Mc Guire
On Fri, Jan 25, 2019 at 04:44:18PM +0100, Jiri Kosina wrote: > On Thu, 24 Jan 2019, Nicholas Mc Guire wrote: > > > Sparse reported warnings about non-static symbols. For the variables > > a simple static attribute is fine - for the functions referenced by > > livepatch via klp_func the

Re: [PATCH V4] livepatch: non static warnings fix

2019-01-25 Thread Jiri Kosina
On Thu, 24 Jan 2019, Nicholas Mc Guire wrote: > Sparse reported warnings about non-static symbols. For the variables > a simple static attribute is fine - for the functions referenced by > livepatch via klp_func the symbol-names must be unmodified in the > symbol table and the patchable code has

Re: [PATCH V4] livepatch: non static warnings fix

2019-01-24 Thread Joe Lawrence
On 1/23/19 8:48 PM, Nicholas Mc Guire wrote: Sparse reported warnings about non-static symbols. For the variables a simple static attribute is fine - for the functions referenced by livepatch via klp_func the symbol-names must be unmodified in the symbol table and the patchable code has to be