Re: Re: [PATCH ftrace/core 0/2] ftrace, kprobes: Introduce IPMODIFY flag for ftrace_ops to detect conflicts

2014-06-13 Thread Masami Hiramatsu
(2014/06/12 21:43), Josh Poimboeuf wrote: >>> I tried removing the FTRACE_OPS_FL_ENABLED clearing line in >>> ftrace_startup, but I saw more warnings. This one happened when >>> attempting to kprobe a kpatched function: >> >> Oops! yes, this should happen... > > Instead of a warning here I'd

Re: Re: [PATCH ftrace/core 0/2] ftrace, kprobes: Introduce IPMODIFY flag for ftrace_ops to detect conflicts

2014-06-13 Thread Masami Hiramatsu
(2014/06/12 21:43), Josh Poimboeuf wrote: I tried removing the FTRACE_OPS_FL_ENABLED clearing line in ftrace_startup, but I saw more warnings. This one happened when attempting to kprobe a kpatched function: Oops! yes, this should happen... Instead of a warning here I'd expect to see

Re: [PATCH ftrace/core 0/2] ftrace, kprobes: Introduce IPMODIFY flag for ftrace_ops to detect conflicts

2014-06-12 Thread Josh Poimboeuf
On Thu, Jun 12, 2014 at 12:28:53PM +0900, Namhyung Kim wrote: > Hi Josh, > > On Wed, 11 Jun 2014 11:58:26 -0500, Josh Poimboeuf wrote: > > On Tue, Jun 10, 2014 at 10:50:01AM +, Masami Hiramatsu wrote: > >> Hi, > >> > >> Here is a pair of patches which introduces IPMODIFY flag for > >>

Re: [PATCH ftrace/core 0/2] ftrace, kprobes: Introduce IPMODIFY flag for ftrace_ops to detect conflicts

2014-06-12 Thread Josh Poimboeuf
On Thu, Jun 12, 2014 at 02:44:35PM +0900, Masami Hiramatsu wrote: > (2014/06/12 1:58), Josh Poimboeuf wrote: > > On Tue, Jun 10, 2014 at 10:50:01AM +, Masami Hiramatsu wrote: > >> Hi, > >> > >> Here is a pair of patches which introduces IPMODIFY flag for > >> ftrace_ops to detect conflicts of

Re: [PATCH ftrace/core 0/2] ftrace, kprobes: Introduce IPMODIFY flag for ftrace_ops to detect conflicts

2014-06-12 Thread Josh Poimboeuf
On Thu, Jun 12, 2014 at 02:44:35PM +0900, Masami Hiramatsu wrote: (2014/06/12 1:58), Josh Poimboeuf wrote: On Tue, Jun 10, 2014 at 10:50:01AM +, Masami Hiramatsu wrote: Hi, Here is a pair of patches which introduces IPMODIFY flag for ftrace_ops to detect conflicts of ftrace users

Re: [PATCH ftrace/core 0/2] ftrace, kprobes: Introduce IPMODIFY flag for ftrace_ops to detect conflicts

2014-06-12 Thread Josh Poimboeuf
On Thu, Jun 12, 2014 at 12:28:53PM +0900, Namhyung Kim wrote: Hi Josh, On Wed, 11 Jun 2014 11:58:26 -0500, Josh Poimboeuf wrote: On Tue, Jun 10, 2014 at 10:50:01AM +, Masami Hiramatsu wrote: Hi, Here is a pair of patches which introduces IPMODIFY flag for ftrace_ops to detect

Re: Re: [PATCH ftrace/core 0/2] ftrace, kprobes: Introduce IPMODIFY flag for ftrace_ops to detect conflicts

2014-06-11 Thread Masami Hiramatsu
(2014/06/12 1:58), Josh Poimboeuf wrote: > On Tue, Jun 10, 2014 at 10:50:01AM +, Masami Hiramatsu wrote: >> Hi, >> >> Here is a pair of patches which introduces IPMODIFY flag for >> ftrace_ops to detect conflicts of ftrace users who can modify >> regs->ip in their handler. >> Currently, only

Re: [PATCH ftrace/core 0/2] ftrace, kprobes: Introduce IPMODIFY flag for ftrace_ops to detect conflicts

2014-06-11 Thread Namhyung Kim
Hi Josh, On Wed, 11 Jun 2014 11:58:26 -0500, Josh Poimboeuf wrote: > On Tue, Jun 10, 2014 at 10:50:01AM +, Masami Hiramatsu wrote: >> Hi, >> >> Here is a pair of patches which introduces IPMODIFY flag for >> ftrace_ops to detect conflicts of ftrace users who can modify >> regs->ip in their

Re: [PATCH ftrace/core 0/2] ftrace, kprobes: Introduce IPMODIFY flag for ftrace_ops to detect conflicts

2014-06-11 Thread Josh Poimboeuf
On Tue, Jun 10, 2014 at 10:50:01AM +, Masami Hiramatsu wrote: > Hi, > > Here is a pair of patches which introduces IPMODIFY flag for > ftrace_ops to detect conflicts of ftrace users who can modify > regs->ip in their handler. > Currently, only kprobes can change the regs->ip in the handler, >

Re: [PATCH ftrace/core 0/2] ftrace, kprobes: Introduce IPMODIFY flag for ftrace_ops to detect conflicts

2014-06-11 Thread Josh Poimboeuf
On Tue, Jun 10, 2014 at 10:50:01AM +, Masami Hiramatsu wrote: Hi, Here is a pair of patches which introduces IPMODIFY flag for ftrace_ops to detect conflicts of ftrace users who can modify regs-ip in their handler. Currently, only kprobes can change the regs-ip in the handler, but

Re: [PATCH ftrace/core 0/2] ftrace, kprobes: Introduce IPMODIFY flag for ftrace_ops to detect conflicts

2014-06-11 Thread Namhyung Kim
Hi Josh, On Wed, 11 Jun 2014 11:58:26 -0500, Josh Poimboeuf wrote: On Tue, Jun 10, 2014 at 10:50:01AM +, Masami Hiramatsu wrote: Hi, Here is a pair of patches which introduces IPMODIFY flag for ftrace_ops to detect conflicts of ftrace users who can modify regs-ip in their handler.

Re: Re: [PATCH ftrace/core 0/2] ftrace, kprobes: Introduce IPMODIFY flag for ftrace_ops to detect conflicts

2014-06-11 Thread Masami Hiramatsu
(2014/06/12 1:58), Josh Poimboeuf wrote: On Tue, Jun 10, 2014 at 10:50:01AM +, Masami Hiramatsu wrote: Hi, Here is a pair of patches which introduces IPMODIFY flag for ftrace_ops to detect conflicts of ftrace users who can modify regs-ip in their handler. Currently, only kprobes can