Re: [PATCH net] net: dsa: mv88e6xxx: override existent unicast portvec in port_fdb_add

2021-02-01 Thread Tobias Waldekranz
On Sun, Jan 31, 2021 at 09:13, DENG Qingfang wrote: > On Sun, Jan 31, 2021 at 8:39 AM Vladimir Oltean wrote: >> >> Tobias has a point in a way too, you should get used to adding the >> 'master static' flags to your bridge fdb commands, otherwise weird >> things like this could happen. The faulty

Re: [PATCH net] net: dsa: mv88e6xxx: override existent unicast portvec in port_fdb_add

2021-02-01 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sat, 30 Jan 2021 21:43:34 +0800 you wrote: > Having multiple destination ports for a unicast address does not make > sense. > Make port_db_load_purge override existent unicast portvec instead of > adding a new port bit. > >

Re: [PATCH net] net: dsa: mv88e6xxx: override existent unicast portvec in port_fdb_add

2021-01-31 Thread Vladimir Oltean
On Sun, Jan 31, 2021 at 09:13:15AM +0800, DENG Qingfang wrote: > This bug is exposed when I try your patch series on kernel 5.4 > https://lore.kernel.org/netdev/20210106095136.224739-1-olte...@gmail.com/ > https://lore.kernel.org/netdev/20210116012515.3152-1-tob...@waldekranz.com/ > > Without this

Re: [PATCH net] net: dsa: mv88e6xxx: override existent unicast portvec in port_fdb_add

2021-01-30 Thread DENG Qingfang
On Sun, Jan 31, 2021 at 8:39 AM Vladimir Oltean wrote: > > Tobias has a point in a way too, you should get used to adding the > 'master static' flags to your bridge fdb commands, otherwise weird > things like this could happen. The faulty code can only be triggered > when going through

Re: [PATCH net] net: dsa: mv88e6xxx: override existent unicast portvec in port_fdb_add

2021-01-30 Thread Vladimir Oltean
On Sat, Jan 30, 2021 at 09:43:34PM +0800, DENG Qingfang wrote: > Having multiple destination ports for a unicast address does not make > sense. > Make port_db_load_purge override existent unicast portvec instead of > adding a new port bit. > > Fixes: 884729399260 ("net: dsa: mv88e6xxx: handle

Re: [PATCH net] net: dsa: mv88e6xxx: override existent unicast portvec in port_fdb_add

2021-01-30 Thread Vladimir Oltean
On Sat, Jan 30, 2021 at 09:47:02PM +0100, Tobias Waldekranz wrote: > root@envoy:~# bridge fdb add 02:00:de:ad:00:01 dev eth1 static vlan 1 > Why does the second add operation succeed? Am I missing some magic flag? Yes, 'master'. We talked about this before. 'bridge fdb add' is implicitly 'self'

Re: [PATCH net] net: dsa: mv88e6xxx: override existent unicast portvec in port_fdb_add

2021-01-30 Thread Tobias Waldekranz
On Sat, Jan 30, 2021 at 21:43, DENG Qingfang wrote: > Having multiple destination ports for a unicast address does not make > sense. > Make port_db_load_purge override existent unicast portvec instead of > adding a new port bit. Is this the layer we want to solve this problem at? What are the